Re: RFR: 8334169: Long arguments of attach operation are silently truncated on Windows [v3]

2024-07-15 Thread Serguei Spitsyn
On Mon, 15 Jul 2024 19:56:13 GMT, Alex Menkov wrote: >> The change fixes a bug in Attach API implementation on Windows when >> argument(s) are longer than 1023 bytes >> >> testing: test/hotspot/jtreg/serviceability/attach, >> test/jdk/com/sun/tools/attach on Oracle supported platforms > > Alex

Re: RFR: 8334169: Long arguments of attach operation are silently truncated on Windows [v3]

2024-07-15 Thread Chris Plummer
On Mon, 15 Jul 2024 19:56:13 GMT, Alex Menkov wrote: >> The change fixes a bug in Attach API implementation on Windows when >> argument(s) are longer than 1023 bytes >> >> testing: test/hotspot/jtreg/serviceability/attach, >> test/jdk/com/sun/tools/attach on Oracle supported platforms > > Alex

Re: RFR: 8334169: Long arguments of attach operation are silently truncated on Windows [v3]

2024-07-15 Thread Alex Menkov
On Sat, 13 Jul 2024 06:21:45 GMT, Serguei Spitsyn wrote: >> Currently Attach operations have restriction for argument size, so setFlag() >> is expected to fail for long values. >> This fix adds AttachOperationFailedException for the case on windows, >> linux/bsd/aix implementations throw generi

Re: RFR: 8334169: Long arguments of attach operation are silently truncated on Windows [v2]

2024-07-15 Thread Alex Menkov
On Sat, 13 Jul 2024 01:45:50 GMT, Alex Menkov wrote: >> test/hotspot/jtreg/serviceability/attach/LongArgTest.java line 79: >> >>> 77: // Value length exceeds 1K. >>> 78: Test withLongValue() { >>> 79: flagValue = generateValue(1024 + 1); >> >> Shouldn't we also be te

Re: RFR: 8334169: Long arguments of attach operation are silently truncated on Windows [v3]

2024-07-15 Thread Alex Menkov
> The change fixes a bug in Attach API implementation on Windows when > argument(s) are longer than 1023 bytes > > testing: test/hotspot/jtreg/serviceability/attach, > test/jdk/com/sun/tools/attach on Oracle supported platforms Alex Menkov has updated the pull request incrementally with one add

Re: RFR: 8334169: Long arguments of attach operation are silently truncated on Windows [v2]

2024-07-12 Thread Serguei Spitsyn
On Fri, 12 Jul 2024 20:37:49 GMT, Alex Menkov wrote: >> test/hotspot/jtreg/serviceability/attach/LongArgTest.java line 94: >> >>> 92: HotSpotVirtualMachine vm = >>> (HotSpotVirtualMachine)VirtualMachine.attach(String.valueOf(app.getPid())); >>> 93: >>> 94: if (setFlag(v

Re: RFR: 8334169: Long arguments of attach operation are silently truncated on Windows [v2]

2024-07-12 Thread Alex Menkov
On Sat, 13 Jul 2024 00:39:02 GMT, Chris Plummer wrote: >> Alex Menkov has updated the pull request incrementally with one additional >> commit since the last revision: >> >> feedback > > test/hotspot/jtreg/serviceability/attach/LongArgTest.java line 79: > >> 77: // Value length excee

Re: RFR: 8334169: Long arguments of attach operation are silently truncated on Windows [v2]

2024-07-12 Thread Alex Menkov
On Fri, 12 Jul 2024 20:25:21 GMT, Chris Plummer wrote: >> Alex Menkov has updated the pull request incrementally with one additional >> commit since the last revision: >> >> feedback > > test/hotspot/jtreg/serviceability/attach/LongArgTest.java line 98: > >> 96: >> 97: if (!

Re: RFR: 8334169: Long arguments of attach operation are silently truncated on Windows [v2]

2024-07-12 Thread Chris Plummer
On Fri, 12 Jul 2024 21:03:26 GMT, Alex Menkov wrote: >> The change fixes a bug in Attach API implementation on Windows when >> argument(s) are longer than 1023 bytes >> >> testing: test/hotspot/jtreg/serviceability/attach, >> test/jdk/com/sun/tools/attach on Oracle supported platforms > > Alex

Re: RFR: 8334169: Long arguments of attach operation are silently truncated on Windows [v2]

2024-07-12 Thread Alex Menkov
> The change fixes a bug in Attach API implementation on Windows when > argument(s) are longer than 1023 bytes > > testing: test/hotspot/jtreg/serviceability/attach, > test/jdk/com/sun/tools/attach on Oracle supported platforms Alex Menkov has updated the pull request incrementally with one add

Re: RFR: 8334169: Long arguments of attach operation are silently truncated on Windows [v2]

2024-07-12 Thread Alex Menkov
On Fri, 12 Jul 2024 06:27:46 GMT, Serguei Spitsyn wrote: >> Alex Menkov has updated the pull request incrementally with one additional >> commit since the last revision: >> >> feedback > > src/jdk.attach/windows/native/libattach/VirtualMachineImpl.c line 57: > >> 55: doPrivilegedOpenProcess(

Re: RFR: 8334169: Long arguments of attach operation are silently truncated on Windows

2024-07-12 Thread Serguei Spitsyn
On Wed, 19 Jun 2024 01:50:30 GMT, Alex Menkov wrote: > The change fixes a bug in Attach API implementation on Windows when > argument(s) are longer than 1023 bytes > > testing: test/hotspot/jtreg/serviceability/attach, > test/jdk/com/sun/tools/attach on Oracle supported platforms The fix look

RFR: 8334169: Long arguments of attach operation are silently truncated on Windows

2024-06-18 Thread Alex Menkov
The change fixes a bug in Attach API implementation on Windows when argument(s) are longer than 1023 bytes testing: test/hotspot/jtreg/serviceability/attach, test/jdk/com/sun/tools/attach on Oracle supported platforms - Commit messages: - JDK-8334168 Changes: https://git.openjdk.