Re: RFR: 8332488: Add JVMTI DataDumpRequest to the debug agent [v2]

2024-08-12 Thread Chris Plummer
On Mon, 12 Aug 2024 19:22:13 GMT, Leonid Mesnik wrote: >> It's not needed because it is in the same file. I'm not even sure it would >> work. > > ough, I mean 'is @build DataDumpTest' needed to build DataDumpTestTarg? The > DataDumpTest should be built without explicit @build command. Ok. I re

Re: RFR: 8332488: Add JVMTI DataDumpRequest to the debug agent [v2]

2024-08-12 Thread Leonid Mesnik
On Thu, 8 Aug 2024 20:56:16 GMT, Chris Plummer wrote: >> test/jdk/com/sun/jdi/DataDumpTest.java line 51: >> >>> 49: * @library /test/lib >>> 50: * @modules jdk.jdi >>> 51: * @build DataDumpTest >> >> Is the build needed to build 'DataDumpTestTarg' because it is not explicitly >> used by the

Re: RFR: 8332488: Add JVMTI DataDumpRequest to the debug agent. [v2]

2024-08-08 Thread Chris Plummer
On Thu, 8 Aug 2024 19:59:04 GMT, Leonid Mesnik wrote: >> Chris Plummer has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Minor improvment to datadump output >> - Add test cast for new debug agent datadump support > > test/jdk/com/sun/jd

Re: RFR: 8332488: Add JVMTI DataDumpRequest to the debug agent. [v2]

2024-08-08 Thread Leonid Mesnik
On Thu, 8 Aug 2024 19:28:09 GMT, Chris Plummer wrote: >> JVMTI has a somewhat unique event called DataDumpRequest. One way it is >> triggered is via the JVMTI.data_dump jcmd, which causes JVMTI to send the >> DataDumpRequest event to all agents that have registered for the event >> callback. T

Re: RFR: 8332488: Add JVMTI DataDumpRequest to the debug agent. [v2]

2024-08-08 Thread Chris Plummer
> JVMTI has a somewhat unique event called DataDumpRequest. One way it is > triggered is via the JVMTI.data_dump jcmd, which causes JVMTI to send the > DataDumpRequest event to all agents that have registered for the event > callback. The agent is free to do pretty much what it wants during the