On Fri, 15 Nov 2024 15:30:05 GMT, Coleen Phillimore wrote:
>> This change adds a couple of comments, removes some ancient bootstrapping
>> code, and adds an old test that we call the verifier for redefining a class,
>> even one in the bootclass path.
>>
>> The fix for always verifying redefine
On Wed, 5 Feb 2025 14:04:18 GMT, Amit Kumar wrote:
>> Thanks David and Johan for the reviews.
>
> Hi @coleenp,
>
> I am repeating the message from Theresa, since she is part of OpenJ9 and
> can't accept OpenJDK Terms:
>
>
> `serviceability/jvmti/RedefineClasses/RedefineVerifyError.java` I
On Thu, 21 Nov 2024 12:13:50 GMT, Coleen Phillimore wrote:
>> Coleen Phillimore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Reduce test, fix bug in verifier, move and add comments to
>> is_eligible_for_verification.
>
> Thanks David
On Fri, 15 Nov 2024 15:30:05 GMT, Coleen Phillimore wrote:
>> This change adds a couple of comments, removes some ancient bootstrapping
>> code, and adds an old test that we call the verifier for redefining a class,
>> even one in the bootclass path.
>>
>> The fix for always verifying redefine
On Fri, 15 Nov 2024 15:30:05 GMT, Coleen Phillimore wrote:
>> This change adds a couple of comments, removes some ancient bootstrapping
>> code, and adds an old test that we call the verifier for redefining a class,
>> even one in the bootclass path.
>>
>> The fix for always verifying redefine
On Thu, 21 Nov 2024 05:12:20 GMT, David Holmes wrote:
>> The JVMTI code for redefinition returns JVMTI_ERROR_FAILS_VERIFICATION and
>> not the pending exception to the caller. The agent eventually in
>> java.instrument/share/native/libinstrument/JavaExceptions.c will recreate
>> the VerifyErr
On Wed, 20 Nov 2024 12:52:45 GMT, Coleen Phillimore wrote:
>> test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/RedefineVerifyError.java
>> line 96:
>>
>>> 94: throw new RuntimeException("This should throw VerifyError");
>>> 95: } catch (VerifyError e) {
>>> 96:
On Wed, 20 Nov 2024 12:23:09 GMT, Coleen Phillimore wrote:
>> src/hotspot/share/oops/method.cpp line 339:
>>
>>> 337: int Method::validate_bci(int bci) const {
>>> 338: // Called from the verifier, and should return -1 if not valid.
>>> 339: return ((is_native() && bci == 0) || (!is_native()
On Wed, 20 Nov 2024 03:42:57 GMT, David Holmes wrote:
>> Coleen Phillimore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Reduce test, fix bug in verifier, move and add comments to
>> is_eligible_for_verification.
>
> test/hotspot/jtre
On Wed, 20 Nov 2024 03:46:46 GMT, David Holmes wrote:
>> Coleen Phillimore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Reduce test, fix bug in verifier, move and add comments to
>> is_eligible_for_verification.
>
> src/hotspot/share
On Fri, 15 Nov 2024 15:30:05 GMT, Coleen Phillimore wrote:
>> This change adds a couple of comments, removes some ancient bootstrapping
>> code, and adds an old test that we call the verifier for redefining a class,
>> even one in the bootclass path.
>>
>> The fix for always verifying redefine
On Fri, 15 Nov 2024 15:30:05 GMT, Coleen Phillimore wrote:
>> This change adds a couple of comments, removes some ancient bootstrapping
>> code, and adds an old test that we call the verifier for redefining a class,
>> even one in the bootclass path.
>>
>> The fix for always verifying redefine
On Fri, 15 Nov 2024 05:19:58 GMT, David Holmes wrote:
>> Coleen Phillimore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Reduce test, fix bug in verifier, move and add comments to
>> is_eligible_for_verification.
>
> src/hotspot/share
> This change adds a couple of comments, removes some ancient bootstrapping
> code, and adds an old test that we call the verifier for redefining a class,
> even one in the bootclass path.
> Tested with tier1-4.
Coleen Phillimore has updated the pull request incrementally with one
additional co
14 matches
Mail list logo
