On Fri, 15 Nov 2024 15:30:05 GMT, Coleen Phillimore <cole...@openjdk.org> wrote:
>> This change adds a couple of comments, removes some ancient bootstrapping >> code, and adds an old test that we call the verifier for redefining a class, >> even one in the bootclass path. >> >> The fix for always verifying redefined classes was actually pushed with >> JDK-8341094, where the verifier code respected the parameter >> "should_verify_class". By default this parameter follows the -Xverify >> setting. For redefinition, this is passed as true. The rest of the fix >> removes the special bootstrap loader cases that may have failed early on in >> the JDK development with -Xverify:all but now no longer do. If someone >> tries to redefine these classes, they should also do the verification on the >> redefined bytecodes. >> >> Tested with tier1-4. > > Coleen Phillimore has updated the pull request incrementally with one > additional commit since the last revision: > > Reduce test, fix bug in verifier, move and add comments to > is_eligible_for_verification. Thanks David and Johan for the reviews. ------------- PR Comment: https://git.openjdk.org/jdk/pull/22116#issuecomment-2490975908
