Re: RFR: 8323660: Serial: Fix header ordering and indentation [v3]

2024-01-13 Thread Kim Barrett
On Fri, 12 Jan 2024 15:26:34 GMT, Lei Zaakjyu wrote: >> follow up 8234502. > > Lei Zaakjyu has updated the pull request incrementally with one additional > commit since the last revision: > > fix Changes requested by kbarrett (Reviewer). src/hotspot/share/gc/serial/serialHeap.cpp line 105:

Re: RFR: 8323660: Serial: Fix header ordering and indentation [v3]

2024-01-12 Thread Lei Zaakjyu
On Fri, 12 Jan 2024 15:26:34 GMT, Lei Zaakjyu wrote: >> follow up 8234502. > > Lei Zaakjyu has updated the pull request incrementally with one additional > commit since the last revision: > > fix thanks for the review. - PR Comment: https://git.openjdk.org/jdk/pull/17398#issuec

Re: RFR: 8323660: Serial: Fix header ordering and indentation [v3]

2024-01-12 Thread Lei Zaakjyu
On Fri, 12 Jan 2024 20:49:47 GMT, Chris Plummer wrote: > SA change looks good. But... > > It looks like all the copyright updates to 2024 are missing from this PR and > the previous PR. We may need another PR for that. Also, the two new files in > that PR should have a copyright that just says

Re: RFR: 8323660: Serial: Fix header ordering and indentation [v3]

2024-01-12 Thread Chris Plummer
On Fri, 12 Jan 2024 15:26:34 GMT, Lei Zaakjyu wrote: >> follow up 8234502. > > Lei Zaakjyu has updated the pull request incrementally with one additional > commit since the last revision: > > fix SA change looks good. But... It looks like all the copyright updates to 2024 are missing from t

Re: RFR: 8323660: Serial: Fix header ordering and indentation [v3]

2024-01-12 Thread Albert Mingkun Yang
On Fri, 12 Jan 2024 15:26:34 GMT, Lei Zaakjyu wrote: >> follow up 8234502. > > Lei Zaakjyu has updated the pull request incrementally with one additional > commit since the last revision: > > fix Marked as reviewed by ayang (Reviewer). - PR Review: https://git.openjdk.org/jdk/p

Re: RFR: 8323660: Serial: Fix header ordering and indentation [v3]

2024-01-12 Thread Lei Zaakjyu
> follow up 8234502. Lei Zaakjyu has updated the pull request incrementally with one additional commit since the last revision: fix - Changes: - all: https://git.openjdk.org/jdk/pull/17398/files - new: https://git.openjdk.org/jdk/pull/17398/files/5c9a5e96..ed54e312 Webrevs: