On Sun, 14 Jan 2024 01:33:45 GMT, Lei Zaakjyu wrote:
>> follow up 8234502.
>
> Lei Zaakjyu has updated the pull request incrementally with one additional
> commit since the last revision:
>
> fix
Marked as reviewed by kbarrett (Reviewer).
-
PR Review: https://git.openjdk.org/jd
> follow up 8234502.
Lei Zaakjyu has updated the pull request incrementally with one additional
commit since the last revision:
fix
-
Changes:
- all: https://git.openjdk.org/jdk/pull/17398/files
- new: https://git.openjdk.org/jdk/pull/17398/files/ed54e312..c0e47a0c
Webrevs:
On Fri, 12 Jan 2024 15:26:34 GMT, Lei Zaakjyu wrote:
>> follow up 8234502.
>
> Lei Zaakjyu has updated the pull request incrementally with one additional
> commit since the last revision:
>
> fix
Changes requested by kbarrett (Reviewer).
src/hotspot/share/gc/serial/serialHeap.cpp line 105:
On Fri, 12 Jan 2024 15:26:34 GMT, Lei Zaakjyu wrote:
>> follow up 8234502.
>
> Lei Zaakjyu has updated the pull request incrementally with one additional
> commit since the last revision:
>
> fix
thanks for the review.
-
PR Comment: https://git.openjdk.org/jdk/pull/17398#issuec
On Fri, 12 Jan 2024 20:49:47 GMT, Chris Plummer wrote:
> SA change looks good. But...
>
> It looks like all the copyright updates to 2024 are missing from this PR and
> the previous PR. We may need another PR for that. Also, the two new files in
> that PR should have a copyright that just says
On Fri, 12 Jan 2024 15:26:34 GMT, Lei Zaakjyu wrote:
>> follow up 8234502.
>
> Lei Zaakjyu has updated the pull request incrementally with one additional
> commit since the last revision:
>
> fix
SA change looks good. But...
It looks like all the copyright updates to 2024 are missing from t
On Fri, 12 Jan 2024 15:26:34 GMT, Lei Zaakjyu wrote:
>> follow up 8234502.
>
> Lei Zaakjyu has updated the pull request incrementally with one additional
> commit since the last revision:
>
> fix
Marked as reviewed by ayang (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/p
> follow up 8234502.
Lei Zaakjyu has updated the pull request incrementally with one additional
commit since the last revision:
fix
-
Changes:
- all: https://git.openjdk.org/jdk/pull/17398/files
- new: https://git.openjdk.org/jdk/pull/17398/files/5c9a5e96..ed54e312
Webrevs:
On Fri, 12 Jan 2024 15:15:41 GMT, Lei Zaakjyu wrote:
>> follow up 8234502.
>
> Lei Zaakjyu has updated the pull request incrementally with one additional
> commit since the last revision:
>
> fix indent
src/hotspot/share/gc/serial/serialHeap.cpp line 81:
> 79: #include "utilities/formatBuff
> follow up 8234502.
Lei Zaakjyu has updated the pull request incrementally with one additional
commit since the last revision:
fix indent
-
Changes:
- all: https://git.openjdk.org/jdk/pull/17398/files
- new: https://git.openjdk.org/jdk/pull/17398/files/6d423eee..5c9a5e96
We
On Fri, 12 Jan 2024 14:31:54 GMT, Lei Zaakjyu wrote:
> follow up 8234502.
Some indentations of arg list are broken, e.g. `SerialHeap::collect_generation`.
-
PR Comment: https://git.openjdk.org/jdk/pull/17398#issuecomment-1889401934
follow up 8234502.
-
Commit messages:
- fix header ordering
Changes: https://git.openjdk.org/jdk/pull/17398/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=17398&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8323660
Stats: 33 lines in 4 files changed: 15 ins; 18 de
12 matches
Mail list logo
