On Fri, 5 Jan 2024 02:22:45 GMT, Denghui Dong wrote:
>> Hi,
>>
>> Please help review this patch that fixes the failures of
>> FullGCHeapDumpLimitTest.java caused by passing other gc flags.
>>
>> Thanks.
>
> Denghui Dong has updated the pull request incrementally with one additional
> commit s
On Fri, 5 Jan 2024 02:22:45 GMT, Denghui Dong wrote:
>> Hi,
>>
>> Please help review this patch that fixes the failures of
>> FullGCHeapDumpLimitTest.java caused by passing other gc flags.
>>
>> Thanks.
>
> Denghui Dong has updated the pull request incrementally with one additional
> commit s
On Fri, 5 Jan 2024 02:24:44 GMT, Denghui Dong wrote:
>>> It means that either Serial is set (and available) or it can be set
>>
>> @stefank that is subtle - and unintuitive. Thanks for explaining.
>
> @dholmes-ora Thanks for the review.
>
> This change only involves the test part. Do I need a
On Thu, 4 Jan 2024 20:37:39 GMT, David Holmes wrote:
>>> > For this test I think we can just add @requires vm.gc.Serial
>>>
>>> @stefank but it doesn't require that, it explicitly sets that. The test
>>> requires that no specific GC has been requested.
>>
>> @dholmes-ora `@requires vm.gc.Seria
> Hi,
>
> Please help review this patch that fixes the failures of
> FullGCHeapDumpLimitTest.java caused by passing other gc flags.
>
> Thanks.
Denghui Dong has updated the pull request incrementally with one additional
commit since the last revision:
update copyright
-
Change
On Fri, 5 Jan 2024 00:47:48 GMT, Denghui Dong wrote:
>> Hi,
>>
>> Please help review this patch that fixes the failures of
>> FullGCHeapDumpLimitTest.java caused by passing other gc flags.
>>
>> Thanks.
>
> Denghui Dong has updated the pull request with a new target base due to a
> merge or a
On Fri, 5 Jan 2024 00:47:48 GMT, Denghui Dong wrote:
>> Hi,
>>
>> Please help review this patch that fixes the failures of
>> FullGCHeapDumpLimitTest.java caused by passing other gc flags.
>>
>> Thanks.
>
> Denghui Dong has updated the pull request with a new target base due to a
> merge or a
> Hi,
>
> Please help review this patch that fixes the failures of
> FullGCHeapDumpLimitTest.java caused by passing other gc flags.
>
> Thanks.
Denghui Dong has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes bro
On Thu, 4 Jan 2024 15:54:50 GMT, Stefan Karlsson wrote:
> It means that either Serial is set (and available) or it can be set
@stefank that is subtle - and unintuitive. Thanks for explaining.
-
PR Comment: https://git.openjdk.org/jdk/pull/17263#issuecomment-1877728970
On Thu, 4 Jan 2024 15:37:33 GMT, Denghui Dong wrote:
>> Hi,
>>
>> Please help review this patch that fixes the failures of
>> FullGCHeapDumpLimitTest.java caused by passing other gc flags.
>>
>> Thanks.
>
> Denghui Dong has updated the pull request incrementally with one additional
> commit s
On Thu, 4 Jan 2024 16:06:26 GMT, Daniel D. Daugherty wrote:
> We're up to 48 test failures so far (8 x 6 Tier3 buildIDs) which is very,
> very noisy. Since it looks like this PR is still being discussed, I'm going
> to ProblemList this test in order to get the noise level back down.
sorry for
On Thu, 4 Jan 2024 15:37:33 GMT, Denghui Dong wrote:
>> Hi,
>>
>> Please help review this patch that fixes the failures of
>> FullGCHeapDumpLimitTest.java caused by passing other gc flags.
>>
>> Thanks.
>
> Denghui Dong has updated the pull request incrementally with one additional
> commit s
On Thu, 4 Jan 2024 11:56:45 GMT, David Holmes wrote:
> > For this test I think we can just add @requires vm.gc.Serial
>
> @stefank but it doesn't require that, it explicitly sets that. The test
> requires that no specific GC has been requested.
@dholmes-ora `@requires vm.gc.Serial` doesn't mea
> Hi,
>
> Please help review this patch that fixes the failures of
> FullGCHeapDumpLimitTest.java caused by passing other gc flags.
>
> Thanks.
Denghui Dong has updated the pull request incrementally with one additional
commit since the last revision:
update
-
Changes:
- all
> Hi,
>
> Please help review this patch that fixes the failures of
> FullGCHeapDumpLimitTest.java caused by passing other gc flags.
>
> Thanks.
Denghui Dong has updated the pull request incrementally with one additional
commit since the last revision:
update
-
Changes:
- all
On Thu, 4 Jan 2024 08:01:57 GMT, Denghui Dong wrote:
> Hi,
>
> Please help review this patch that fixes the failures of
> FullGCHeapDumpLimitTest.java caused by passing other gc flags.
>
> Thanks.
And for this test, I think `@requires vm.opt.DisableExplicitGC != "true"` is
also needed.
On Thu, 4 Jan 2024 08:01:57 GMT, Denghui Dong wrote:
> Hi,
>
> Please help review this patch that fixes the failures of
> FullGCHeapDumpLimitTest.java caused by passing other gc flags.
>
> Thanks.
I found other tests that set -XX:+UseSerialGC explicitly have `@requires
vm.gc.Serial` or `vm.
On Thu, 4 Jan 2024 10:01:41 GMT, Stefan Karlsson wrote:
> For this test I think we can just add @requires vm.gc.Serial
@stefank but it doesn't require that, it explicitly sets that. The test
requires that no specific GC has been requested.
-
PR Comment: https://git.openjdk.org/jdk
On Thu, 4 Jan 2024 08:01:57 GMT, Denghui Dong wrote:
> Hi,
>
> Please help review this patch that fixes the failures of
> FullGCHeapDumpLimitTest.java caused by passing other gc flags.
>
> Thanks.
I prefer if we stay away from using `@requires vm.flagless` if possible. For
this test I think
Hi,
Please help review this patch that fixes the failures of
FullGCHeapDumpLimitTest.java caused by passing other gc flags.
Thanks.
-
Commit messages:
- 8322989: New test serviceability/HeapDump/FullGCHeapDumpLimitTest.java fails
Changes: https://git.openjdk.org/jdk/pull/17263/fi
20 matches
Mail list logo
