Re: RFR: 8318447: Move NMT source code to own subdirectory [v5]

2023-10-24 Thread Johan Sjölen
On Mon, 23 Oct 2023 08:23:44 GMT, Stefan Karlsson wrote: >> Johan Sjölen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix messed up include > > src/hotspot/share/nmt/nmtPreInit.hpp line 35: > >> 33: #include "utilities/macros.hpp" >>

Re: RFR: 8318447: Move NMT source code to own subdirectory [v5]

2023-10-23 Thread Stefan Karlsson
On Fri, 20 Oct 2023 12:49:46 GMT, Johan Sjölen wrote: >> I think that NMT is deserving of its own subdirectory. Can we do a review of >> the changes before I fix the merge conflicts? >> >> 1. Moved all the nmt source code from services/ to nmt/ >> 2. Renamed all the include statements and sorte

Re: RFR: 8318447: Move NMT source code to own subdirectory [v5]

2023-10-22 Thread David Holmes
On Fri, 20 Oct 2023 12:49:46 GMT, Johan Sjölen wrote: >> I think that NMT is deserving of its own subdirectory. Can we do a review of >> the changes before I fix the merge conflicts? >> >> 1. Moved all the nmt source code from services/ to nmt/ >> 2. Renamed all the include statements and sorte

Re: RFR: 8318447: Move NMT source code to own subdirectory [v5]

2023-10-20 Thread Johan Sjölen
> I think that NMT is deserving of its own subdirectory. Can we do a review of > the changes before I fix the merge conflicts? > > 1. Moved all the nmt source code from services/ to nmt/ > 2. Renamed all the include statements and sorted them > 3. Fixed the include guards Johan Sjölen has update