Re: RFR: 8315966: Relativize initial_sp in interpreter frames [v3]

2023-09-27 Thread Fredrik Bredberg
On Wed, 27 Sep 2023 09:07:23 GMT, Fredrik Bredberg wrote: >> Relativize initial_sp in interpreter frames. >> >> By changing the "initial_sp" (AKA "monitor_block_top" or "monitors" on >> PowerPC) member in interpreter frames from being an absolute address into an >> offset that is relative to

Re: RFR: 8315966: Relativize initial_sp in interpreter frames [v3]

2023-09-27 Thread Fei Yang
On Wed, 27 Sep 2023 09:07:23 GMT, Fredrik Bredberg wrote: >> Relativize initial_sp in interpreter frames. >> >> By changing the "initial_sp" (AKA "monitor_block_top" or "monitors" on >> PowerPC) member in interpreter frames from being an absolute address into an >> offset that is relative to

Re: RFR: 8315966: Relativize initial_sp in interpreter frames [v3]

2023-09-27 Thread Fredrik Bredberg
> Relativize initial_sp in interpreter frames. > > By changing the "initial_sp" (AKA "monitor_block_top" or "monitors" on > PowerPC) member in interpreter frames from being an absolute address into an > offset that is relative to the frame pointer, we don't need to change the > value as we free

Re: RFR: 8315966: Relativize initial_sp in interpreter frames [v2]

2023-09-26 Thread Martin Doerr
On Tue, 26 Sep 2023 11:41:52 GMT, Fredrik Bredberg wrote: >> Relativize initial_sp in interpreter frames. >> >> By changing the "initial_sp" (AKA "monitor_block_top" or "monitors" on >> PowerPC) member in interpreter frames from being an absolute address into an >> offset that is relative to

Re: RFR: 8315966: Relativize initial_sp in interpreter frames [v2]

2023-09-26 Thread Fei Yang
On Tue, 26 Sep 2023 12:01:34 GMT, Fredrik Bredberg wrote: > The "Updated after review" version contains the following changes. > > 1. The extra space in `interp_masm_riscv.cpp` was removed. I see `shadd` added in other files are not covered? They have similar issues. Looks good otherwise. Tha

Re: RFR: 8315966: Relativize initial_sp in interpreter frames [v2]

2023-09-26 Thread Fredrik Bredberg
On Thu, 21 Sep 2023 12:45:07 GMT, Fei Yang wrote: >> Hi, I have arranged tier1-3 test on linux-riscv64 platform. Thanks for >> adding handling for riscv. > >> Hi, I have arranged tier1-3 test on linux-riscv64 platform. Thanks for >> adding handling for riscv. > > Tier1-3 test is clean. The ris

Re: RFR: 8315966: Relativize initial_sp in interpreter frames [v2]

2023-09-26 Thread Fredrik Bredberg
On Wed, 20 Sep 2023 08:46:39 GMT, Fei Yang wrote: >> Fredrik Bredberg has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Updated after review. > > src/hotspot/cpu/riscv/interp_masm_riscv.cpp line 704: > >> 702: // register for unlock_o

Re: RFR: 8315966: Relativize initial_sp in interpreter frames [v2]

2023-09-26 Thread Fredrik Bredberg
> Relativize initial_sp in interpreter frames. > > By changing the "initial_sp" (AKA "monitor_block_top" or "monitors" on > PowerPC) member in interpreter frames from being an absolute address into an > offset that is relative to the frame pointer, we don't need to change the > value as we free

Re: RFR: 8315966: Relativize initial_sp in interpreter frames

2023-09-25 Thread Patricio Chilano Mateo
On Tue, 19 Sep 2023 09:00:01 GMT, Fredrik Bredberg wrote: > Relativize initial_sp in interpreter frames. > > By changing the "initial_sp" (AKA "monitor_block_top" or "monitors" on > PowerPC) member in interpreter frames from being an absolute address into an > offset that is relative to the f

Re: RFR: 8315966: Relativize initial_sp in interpreter frames

2023-09-21 Thread Fei Yang
On Wed, 20 Sep 2023 08:52:09 GMT, Fei Yang wrote: > Hi, I have arranged tier1-3 test on linux-riscv64 platform. Thanks for adding > handling for riscv. Tier1-3 test is clean. The riscv part looks good except for the nit. - PR Comment: https://git.openjdk.org/jdk/pull/15815#issueco

Re: RFR: 8315966: Relativize initial_sp in interpreter frames

2023-09-20 Thread Martin Doerr
On Tue, 19 Sep 2023 09:00:01 GMT, Fredrik Bredberg wrote: > Relativize initial_sp in interpreter frames. > > By changing the "initial_sp" (AKA "monitor_block_top" or "monitors" on > PowerPC) member in interpreter frames from being an absolute address into an > offset that is relative to the f

Re: RFR: 8315966: Relativize initial_sp in interpreter frames

2023-09-20 Thread Fei Yang
On Tue, 19 Sep 2023 09:00:01 GMT, Fredrik Bredberg wrote: > Relativize initial_sp in interpreter frames. > > By changing the "initial_sp" (AKA "monitor_block_top" or "monitors" on > PowerPC) member in interpreter frames from being an absolute address into an > offset that is relative to the f

Re: RFR: 8315966: Relativize initial_sp in interpreter frames

2023-09-19 Thread Martin Doerr
On Tue, 19 Sep 2023 09:00:01 GMT, Fredrik Bredberg wrote: > Relativize initial_sp in interpreter frames. > > By changing the "initial_sp" (AKA "monitor_block_top" or "monitors" on > PowerPC) member in interpreter frames from being an absolute address into an > offset that is relative to the f

Re: RFR: 8315966: Relativize initial_sp in interpreter frames

2023-09-19 Thread Fredrik Bredberg
On Tue, 19 Sep 2023 09:00:01 GMT, Fredrik Bredberg wrote: > Relativize initial_sp in interpreter frames. > > By changing the "initial_sp" (AKA "monitor_block_top" or "monitors" on > PowerPC) member in interpreter frames from being an absolute address into an > offset that is relative to the f

RFR: 8315966: Relativize initial_sp in interpreter frames

2023-09-19 Thread Fredrik Bredberg
Relativize initial_sp in interpreter frames. By changing the "initial_sp" (AKA "monitor_block_top" or "monitors" on PowerPC) member in interpreter frames from being an absolute address into an offset that is relative to the frame pointer, we don't need to change the value as we freeze and thaw