Re: RFR: 8315149: Add hsperf counters for CPU time of internal GC threads [v53]

2023-12-04 Thread Stefan Johansson
On Sat, 2 Dec 2023 01:22:33 GMT, Jonathan Joo wrote: >> I still think that a total counter is useful and I'd appreciate if you can >> keep it. To second what @caoman said before, it is GC agnostic, easy to use >> even for non GC experts and future proof with regards to implementation >> change

Re: RFR: 8315149: Add hsperf counters for CPU time of internal GC threads [v53]

2023-12-01 Thread Jonathan Joo
On Fri, 1 Dec 2023 14:42:22 GMT, Albert Mingkun Yang wrote: >> I would say it depends on the use-case and here when switching to use static >> functions to use the instance it felt more like an all-static class. I agree >> that it would be nice to avoid the additional memory usage if `UsePerfDa

Re: RFR: 8315149: Add hsperf counters for CPU time of internal GC threads [v53]

2023-12-01 Thread Jonathan Joo
On Fri, 1 Dec 2023 16:19:49 GMT, Volker Simonis wrote: >> src/hotspot/share/gc/parallel/parallelScavengeHeap.cpp line 905: >> >>> 903: gc_threads_do(&tttc); >>> 904: >>> 905: CPUTimeCounters::publish_gc_total_cpu_time(); >> >> As I suggested in the other comment, maybe we should not keep t

Re: RFR: 8315149: Add hsperf counters for CPU time of internal GC threads [v53]

2023-12-01 Thread Volker Simonis
On Thu, 30 Nov 2023 09:46:03 GMT, Stefan Johansson wrote: >> Jonathan Joo has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Add missing include > > src/hotspot/share/gc/parallel/parallelScavengeHeap.cpp line 905: > >> 903: gc_threads_do

Re: RFR: 8315149: Add hsperf counters for CPU time of internal GC threads [v53]

2023-12-01 Thread Albert Mingkun Yang
On Fri, 1 Dec 2023 09:58:16 GMT, Stefan Johansson wrote: >> I thought it is typically preferred to initialize a singleton object on the >> heap, rather than using several static variables. It is easier to control >> the initialization order and timing of an on-heap singleton object than >> sta

Re: RFR: 8315149: Add hsperf counters for CPU time of internal GC threads [v53]

2023-12-01 Thread Stefan Johansson
On Thu, 30 Nov 2023 21:59:41 GMT, Man Cao wrote: >> src/hotspot/share/runtime/cpuTimeCounters.hpp line 59: >> >>> 57: NONCOPYABLE(CPUTimeCounters); >>> 58: >>> 59: static CPUTimeCounters* _instance; >> >> I would prefer if we made the whole class static and got rid of the instance >> and

Re: RFR: 8315149: Add hsperf counters for CPU time of internal GC threads [v53]

2023-11-30 Thread Man Cao
On Thu, 30 Nov 2023 09:41:55 GMT, Stefan Johansson wrote: >> Jonathan Joo has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Add missing include > > src/hotspot/share/runtime/cpuTimeCounters.hpp line 59: > >> 57: NONCOPYABLE(CPUTimeCount

Re: RFR: 8315149: Add hsperf counters for CPU time of internal GC threads [v53]

2023-11-30 Thread Stefan Johansson
On Thu, 30 Nov 2023 02:45:45 GMT, Jonathan Joo wrote: >> 8315149: Add hsperf counters for CPU time of internal GC threads > > Jonathan Joo has updated the pull request incrementally with one additional > commit since the last revision: > > Add missing include src/hotspot/share/runtime/cpuTim

Re: RFR: 8315149: Add hsperf counters for CPU time of internal GC threads [v53]

2023-11-30 Thread Stefan Johansson
On Thu, 30 Nov 2023 02:45:45 GMT, Jonathan Joo wrote: >> 8315149: Add hsperf counters for CPU time of internal GC threads > > Jonathan Joo has updated the pull request incrementally with one additional > commit since the last revision: > > Add missing include Few more comments after the late

Re: RFR: 8315149: Add hsperf counters for CPU time of internal GC threads [v53]

2023-11-29 Thread Jonathan Joo
> 8315149: Add hsperf counters for CPU time of internal GC threads Jonathan Joo has updated the pull request incrementally with one additional commit since the last revision: Add missing include - Changes: - all: https://git.openjdk.org/jdk/pull/15082/files - new: https://git