Re: RFR: 8315149: Add hsperf counters for CPU time of internal GC threads [v24]

2023-09-26 Thread Volker Simonis
On Tue, 19 Sep 2023 22:48:16 GMT, Jonathan Joo wrote: >> 8315149: Add hsperf counters for CPU time of internal GC threads > > Jonathan Joo has updated the pull request incrementally with one additional > commit since the last revision: > > Fix build issues Thanks for your continued work on t

Re: RFR: 8315149: Add hsperf counters for CPU time of internal GC threads [v24]

2023-09-26 Thread Aleksey Shipilev
On Fri, 22 Sep 2023 03:28:18 GMT, David Holmes wrote: >> Using `long` is to avoid build failure on 32-bit ARM and x86. `jlong` is >> `long long` on 32-bit, and Atomic template does not support `long long` on >> 32-bit. Example failure: >> https://github.com/jjoo172/jdk/actions/runs/6229455243/

Re: RFR: 8315149: Add hsperf counters for CPU time of internal GC threads [v24]

2023-09-21 Thread David Holmes
On Fri, 22 Sep 2023 00:11:19 GMT, Man Cao wrote: >> src/hotspot/share/gc/shared/collectedHeap.cpp line 161: >> >>> 159: } >>> 160: >>> 161: void CollectedHeap::inc_total_cpu_time(long diff) { >> >> We don't use `long` in shared code as it has different size on different >> platforms. > > Usin

Re: RFR: 8315149: Add hsperf counters for CPU time of internal GC threads [v24]

2023-09-21 Thread Man Cao
On Wed, 20 Sep 2023 00:39:44 GMT, David Holmes wrote: >> Jonathan Joo has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix build issues > > src/hotspot/share/gc/shared/collectedHeap.cpp line 161: > >> 159: } >> 160: >> 161: void Collect

Re: RFR: 8315149: Add hsperf counters for CPU time of internal GC threads [v24]

2023-09-19 Thread David Holmes
On Tue, 19 Sep 2023 22:48:16 GMT, Jonathan Joo wrote: >> 8315149: Add hsperf counters for CPU time of internal GC threads > > Jonathan Joo has updated the pull request incrementally with one additional > commit since the last revision: > > Fix build issues Changes requested by dholmes (Revie

Re: RFR: 8315149: Add hsperf counters for CPU time of internal GC threads [v24]

2023-09-19 Thread Jonathan Joo
> 8315149: Add hsperf counters for CPU time of internal GC threads Jonathan Joo has updated the pull request incrementally with one additional commit since the last revision: Fix build issues - Changes: - all: https://git.openjdk.org/jdk/pull/15082/files - new: https://git.op