Re: RFR: 8307244: Remove redundant class RMIIIOPServerImpl [v2]

2023-05-10 Thread Kevin Walls
On Wed, 10 May 2023 09:02:40 GMT, Kevin Walls wrote: >> src/java.management.rmi/share/classes/javax/management/remote/rmi/RMIConnector.java >> line 188: >> >>> 186: * >>> 187: * >>> 188: * >>> service:jmx:protocolname://[host[:port]]/stub/encoded-stub >> >> "protocolname" coul

Re: RFR: 8307244: Remove redundant class RMIIIOPServerImpl [v2]

2023-05-10 Thread Kevin Walls
On Wed, 10 May 2023 09:01:16 GMT, Alan Bateman wrote: >> Kevin Walls has updated the pull request incrementally with one additional >> commit since the last revision: >> >> example update > > src/java.management.rmi/share/classes/javax/management/remote/rmi/RMIConnector.java > line 188: > >

Re: RFR: 8307244: Remove redundant class RMIIIOPServerImpl [v2]

2023-05-10 Thread Alan Bateman
On Wed, 10 May 2023 08:49:47 GMT, Kevin Walls wrote: >> Removal of class, looks like it was missed in the JDK9 removal of RMIIIOP. >> This class is not referenced by other classes or tests. > > Kevin Walls has updated the pull request incrementally with one additional > commit since the last rev

Re: RFR: 8307244: Remove redundant class RMIIIOPServerImpl [v3]

2023-05-10 Thread Kevin Walls
> Removal of class, looks like it was missed in the JDK9 removal of RMIIIOP. > This class is not referenced by other classes or tests. Kevin Walls has updated the pull request incrementally with one additional commit since the last revision: example update - Changes: - all: htt

Re: RFR: 8307244: Remove redundant class RMIIIOPServerImpl

2023-05-10 Thread Kevin Walls
On Tue, 2 May 2023 17:57:14 GMT, Kevin Walls wrote: > Removal of class, looks like it was missed in the JDK9 removal of RMIIIOP. > This class is not referenced by other classes or tests. Putting the example back in RMIConnector, but I was keen to remove "iiop" from search results here, so with

Re: RFR: 8307244: Remove redundant class RMIIIOPServerImpl [v2]

2023-05-10 Thread Kevin Walls
> Removal of class, looks like it was missed in the JDK9 removal of RMIIIOP. > This class is not referenced by other classes or tests. Kevin Walls has updated the pull request incrementally with one additional commit since the last revision: example update - Changes: - all: htt

Re: RFR: 8307244: Remove redundant class RMIIIOPServerImpl

2023-05-03 Thread Kevin Walls
On Tue, 2 May 2023 17:57:14 GMT, Kevin Walls wrote: > Removal of class, looks like it was missed in the JDK9 removal of RMIIIOP. > This class is not referenced by other classes or tests. Thanks for all the comments and reviews. On the RMIConnector example, I had thought it was misleading to use

Re: RFR: 8307244: Remove redundant class RMIIIOPServerImpl

2023-05-03 Thread Alan Bateman
On Tue, 2 May 2023 17:57:14 GMT, Kevin Walls wrote: > Removal of class, looks like it was missed in the JDK9 removal of RMIIIOP. > This class is not referenced by other classes or tests. Removing RMIIIOPServerImpl is fine, I think I agree with Daniel on leaving out the change to RMIConnector. I

Re: RFR: 8307244: Remove redundant class RMIIIOPServerImpl

2023-05-03 Thread Daniel Fuchs
On Tue, 2 May 2023 17:57:14 GMT, Kevin Walls wrote: > Removal of class, looks like it was missed in the JDK9 removal of RMIIIOP. > This class is not referenced by other classes or tests. Marked as reviewed by dfuchs (Reviewer). Looks good to me. I probably wouldn't have bothered with removing t

Re: RFR: 8307244: Remove redundant class RMIIIOPServerImpl

2023-05-02 Thread Alan Bateman
On Tue, 2 May 2023 17:57:14 GMT, Kevin Walls wrote: > Removal of class, looks like it was missed in the JDK9 removal of RMIIIOP. > This class is not referenced by other classes or tests. JSR-160 MR3 changed RMIConnector to make the IIOP transport optional. For Java 8 this was JDK-8001048. For J

Re: RFR: 8307244: Remove redundant class RMIIIOPServerImpl

2023-05-02 Thread Kevin Walls
On Tue, 2 May 2023 17:57:14 GMT, Kevin Walls wrote: > Removal of class, looks like it was missed in the JDK9 removal of RMIIIOP. > This class is not referenced by other classes or tests. Thanks Alan - I had read JDK-8043937 as being where we remove IIOP completely as a transport for JMX (after

Re: RFR: 8307244: Remove redundant class RMIIIOPServerImpl

2023-05-02 Thread Alan Bateman
On Tue, 2 May 2023 18:43:26 GMT, Serguei Spitsyn wrote: > As I see, this transport was deprecated for some time. > But it is not clear in what release. There were a couple of steps in this. The JSR-160 specification was updated for Java 8 so that the RMI connector wasn't require to support the

Re: RFR: 8307244: Remove redundant class RMIIIOPServerImpl

2023-05-02 Thread Serguei Spitsyn
On Tue, 2 May 2023 17:57:14 GMT, Kevin Walls wrote: > Removal of class, looks like it was missed in the JDK9 removal of RMIIIOP. > This class is not referenced by other classes or tests. As I see, this transport was deprecated for some time. But it is not clear in what release. The fix looks goo

RFR: 8307244: Remove redundant class RMIIIOPServerImpl

2023-05-02 Thread Kevin Walls
Removal of class, looks like it was missed in the JDK9 removal of RMIIIOP. This class is not referenced by other classes or tests. - Commit messages: - 8307244: Remove redundant class RMIIIOPServerImpl Changes: https://git.openjdk.org/jdk/pull/13758/files Webrev: https://webrevs.op