Re: RFR: 8307153: JVMTI GetThreadState on carrier should return STATE_WAITING [v2]

2023-06-06 Thread Serguei Spitsyn
On Tue, 6 Jun 2023 21:22:40 GMT, Alex Menkov wrote: >> Serguei Spitsyn has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains three additional >> commi

Re: RFR: 8307153: JVMTI GetThreadState on carrier should return STATE_WAITING [v2]

2023-06-06 Thread Alex Menkov
On Mon, 5 Jun 2023 19:00:49 GMT, Serguei Spitsyn wrote: >> When a virtual thread is mounted, the carrier thread should be reported as >> "waiting" until the virtual thread unmounts. Right now, GetThreadState >> reports a state based the JavaThread status when it should return >> JVMTI_THREAD_S

Re: RFR: 8307153: JVMTI GetThreadState on carrier should return STATE_WAITING [v2]

2023-06-06 Thread Alan Bateman
On Mon, 5 Jun 2023 21:26:39 GMT, Serguei Spitsyn wrote: > Okay, I see you point. Unfortunately, I've always referred the platform > thread with an executed FJP schedular as a carrier thread. The term 'carrier' > with this meaning is everywhere in the JVMTI code. It looks very confusing to > ca

Re: RFR: 8307153: JVMTI GetThreadState on carrier should return STATE_WAITING [v2]

2023-06-05 Thread Serguei Spitsyn
On Sun, 4 Jun 2023 11:14:06 GMT, Alan Bateman wrote: >> The lines 763-764 are to correct the state exactly for passive carrier >> thread, a carrier thread which can't progress until the execution control >> has not been returned from a virtual thread executed on the top. It is never >> for a p

Re: RFR: 8307153: JVMTI GetThreadState on carrier should return STATE_WAITING [v2]

2023-06-05 Thread Serguei Spitsyn
On Mon, 5 Jun 2023 19:00:49 GMT, Serguei Spitsyn wrote: >> When a virtual thread is mounted, the carrier thread should be reported as >> "waiting" until the virtual thread unmounts. Right now, GetThreadState >> reports a state based the JavaThread status when it should return >> JVMTI_THREAD_S

Re: RFR: 8307153: JVMTI GetThreadState on carrier should return STATE_WAITING [v2]

2023-06-05 Thread Chris Plummer
On Mon, 5 Jun 2023 19:00:49 GMT, Serguei Spitsyn wrote: >> When a virtual thread is mounted, the carrier thread should be reported as >> "waiting" until the virtual thread unmounts. Right now, GetThreadState >> reports a state based the JavaThread status when it should return >> JVMTI_THREAD_S

Re: RFR: 8307153: JVMTI GetThreadState on carrier should return STATE_WAITING [v2]

2023-06-05 Thread Serguei Spitsyn
> When a virtual thread is mounted, the carrier thread should be reported as > "waiting" until the virtual thread unmounts. Right now, GetThreadState > reports a state based the JavaThread status when it should return > JVMTI_THREAD_STATE_WAITING | JVMTI_THREAD_STATE_WAITING_INDEFINITELY. > The