On Mon, 27 Feb 2023 13:23:12 GMT, Julian Waters wrote:
> Ah I see, was the initial commit made with the assumption that inttypes.h was
> already included? It's just a final confirmation before integration
Could be.
-
PR: https://git.openjdk.org/jdk/pull/12744
On Mon, 27 Feb 2023 08:29:37 GMT, Julian Waters wrote:
>> We no longer need to define PrId64 ourselves since the Visual C++ compiler
>> supports inttypes.h on the only versions we support, so we can just replace
>> it with an include to the standard header instead
>
> Julian Waters has updated
> We no longer need to define PrId64 ourselves since the Visual C++ compiler
> supports inttypes.h on the only versions we support, so we can just replace
> it with an include to the standard header instead
Julian Waters has updated the pull request with a new target base due to a
merge or a re
On Sun, 26 Feb 2023 21:02:43 GMT, Christoph Langer wrote:
> PS I guess you should update the copyright year before pushing.
Ah right, thanks for the reminder
> > @RealCLanger Sorry for the ping, just wanted to check since you're the
> > original commit Author for the format string, is there
On Sun, 26 Feb 2023 15:10:08 GMT, Julian Waters wrote:
> @RealCLanger Sorry for the ping, just wanted to check since you're the
> original commit Author for the format string, is there someplace else where
> inttypes.h or stdint.h is included or should be included that I missed?
Hah, that was
On Fri, 24 Feb 2023 15:36:36 GMT, Julian Waters wrote:
> We no longer need to define PrId64 ourselves since the Visual C++ compiler
> supports inttypes.h on the only versions we support, so we can just replace
> it with an include to the standard header instead
Marked as reviewed by clanger (R
On Fri, 24 Feb 2023 15:36:36 GMT, Julian Waters wrote:
> We no longer need to define PrId64 ourselves since the Visual C++ compiler
> supports inttypes.h on the only versions we support, so we can just replace
> it with an include to the standard header instead
@RealCLanger Sorry for the ping,
On Fri, 24 Feb 2023 15:36:36 GMT, Julian Waters wrote:
> We no longer need to define PrId64 ourselves since the Visual C++ compiler
> supports inttypes.h on the only versions we support, so we can just replace
> it with an include to the standard header instead
Little bit of a quick note from
On Fri, 24 Feb 2023 15:36:36 GMT, Julian Waters wrote:
> We no longer need to define PrId64 ourselves since the Visual C++ compiler
> supports inttypes.h on the only versions we support, so we can just replace
> it with an include to the standard header instead
Looks okay to me.
Thanks,
Sergue
On Fri, 24 Feb 2023 15:36:36 GMT, Julian Waters wrote:
> We no longer need to define PrId64 ourselves since the Visual C++ compiler
> supports inttypes.h on the only versions we support, so we can just replace
> it with an include to the standard header instead
Marked as reviewed by cjplummer
We no longer need to define PrId64 ourselves since the Visual C++ compiler
supports inttypes.h on the only versions we support, so we can just replace it
with an include to the standard header instead
-
Commit messages:
- Remove Windows specific workaround from libdt
Changes: http
11 matches
Mail list logo
