On Mon, 28 Nov 2022 15:49:30 GMT, Erik Österlund wrote:
>> The current loom code makes some assumptions about GC that will not work
>> with generational ZGC. We should make this code more GC agnostic, and
>> provide a better interface for talking to the GC.
>>
>> In particular,
>> 1) All GCs h
On Mon, 28 Nov 2022 12:14:59 GMT, Erik Österlund wrote:
>> The current loom code makes some assumptions about GC that will not work
>> with generational ZGC. We should make this code more GC agnostic, and
>> provide a better interface for talking to the GC.
>>
>> In particular,
>> 1) All GCs h
> The current loom code makes some assumptions about GC that will not work with
> generational ZGC. We should make this code more GC agnostic, and provide a
> better interface for talking to the GC.
>
> In particular,
> 1) All GCs have a way of encoding oops inside of the heap differently to oop
On Mon, 21 Nov 2022 12:17:02 GMT, Patricio Chilano Mateo
wrote:
>> Erik Österlund has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix Richard comments
>
> I went through the changes and all looks good to me. Only minor comments.
>
> Th
On Mon, 28 Nov 2022 12:14:59 GMT, Erik Österlund wrote:
>> The current loom code makes some assumptions about GC that will not work
>> with generational ZGC. We should make this code more GC agnostic, and
>> provide a better interface for talking to the GC.
>>
>> In particular,
>> 1) All GCs h
On Mon, 21 Nov 2022 12:17:02 GMT, Patricio Chilano Mateo
wrote:
>> Erik Österlund has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix Richard comments
>
> I went through the changes and all looks good to me. Only minor comments.
>
> Th
> The current loom code makes some assumptions about GC that will not work with
> generational ZGC. We should make this code more GC agnostic, and provide a
> better interface for talking to the GC.
>
> In particular,
> 1) All GCs have a way of encoding oops inside of the heap differently to oop
On Thu, 17 Nov 2022 09:24:04 GMT, Erik Österlund wrote:
>> The current loom code makes some assumptions about GC that will not work
>> with generational ZGC. We should make this code more GC agnostic, and
>> provide a better interface for talking to the GC.
>>
>> In particular,
>> 1) All GCs h
On Thu, 17 Nov 2022 11:16:52 GMT, Richard Reingruber wrote:
>> The compiler should be able to do that already. We devirtualize calls into
>> oop closures, and the closure is stack allocated. So the compiler should be
>> able to do that if it finds that it is a good idea. I'd prefer to leave tha
On Thu, 17 Nov 2022 11:23:07 GMT, Richard Reingruber wrote:
>> Erik Österlund has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix Richard comments
>
> Marked as reviewed by rrich (Reviewer).
Thanks for the review, @reinrich!
--
On Thu, 17 Nov 2022 09:24:04 GMT, Erik Österlund wrote:
>> The current loom code makes some assumptions about GC that will not work
>> with generational ZGC. We should make this code more GC agnostic, and
>> provide a better interface for talking to the GC.
>>
>> In particular,
>> 1) All GCs h
On Thu, 17 Nov 2022 09:23:48 GMT, Erik Österlund wrote:
>> src/hotspot/share/gc/shared/barrierSetStackChunk.cpp line 68:
>>
>>> 66:
>>> 67: virtual void do_oop(oop* p) override {
>>> 68: if (UseCompressedOops) {
>>
>> Wouldn't it be better to hoist the check for `UseCompressedOops`?
>
>
On Wed, 16 Nov 2022 15:47:37 GMT, Richard Reingruber wrote:
>> Erik Österlund has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Indentation fix
>
> Hi @fisk, I've skimmed the changes. They look good to me. I do have a few
> comments/quest
> The current loom code makes some assumptions about GC that will not work with
> generational ZGC. We should make this code more GC agnostic, and provide a
> better interface for talking to the GC.
>
> In particular,
> 1) All GCs have a way of encoding oops inside of the heap differently to oop
On Mon, 14 Nov 2022 16:07:34 GMT, Erik Österlund wrote:
>> The current loom code makes some assumptions about GC that will not work
>> with generational ZGC. We should make this code more GC agnostic, and
>> provide a better interface for talking to the GC.
>>
>> In particular,
>> 1) All GCs h
On Tue, 15 Nov 2022 09:39:27 GMT, Fei Yang wrote:
>> PS: I see JVM crashes when running Skynet with extra VM option:
>> -XX:+VerifyContinuations on linux-aarch64 platform.
>>
>> $java --enable-preview -XX:+VerifyContinuations Skynet
>>
>>
>> # A fatal error has been detected by the Java Runt
On Sat, 12 Nov 2022 08:08:15 GMT, Fei Yang wrote:
>> The current loom code makes some assumptions about GC that will not work
>> with generational ZGC. We should make this code more GC agnostic, and
>> provide a better interface for talking to the GC.
>>
>> In particular,
>> 1) All GCs have a
On Sat, 12 Nov 2022 08:08:15 GMT, Fei Yang wrote:
>> The current loom code makes some assumptions about GC that will not work
>> with generational ZGC. We should make this code more GC agnostic, and
>> provide a better interface for talking to the GC.
>>
>> In particular,
>> 1) All GCs have a
> The current loom code makes some assumptions about GC that will not work with
> generational ZGC. We should make this code more GC agnostic, and provide a
> better interface for talking to the GC.
>
> In particular,
> 1) All GCs have a way of encoding oops inside of the heap differently to oop
On Mon, 14 Nov 2022 10:43:23 GMT, Stefan Karlsson wrote:
>> Erik Österlund has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix verification and RISC-V support
>
> Looks good to me. I wrote parts of this code, so I want wan extra Reviewer
On Mon, 14 Nov 2022 10:15:41 GMT, Erik Österlund wrote:
>> The current loom code makes some assumptions about GC that will not work
>> with generational ZGC. We should make this code more GC agnostic, and
>> provide a better interface for talking to the GC.
>>
>> In particular,
>> 1) All GCs h
On Sat, 12 Nov 2022 08:08:15 GMT, Fei Yang wrote:
> PS: I see JVM crashes when running Skynet with extra VM option:
> -XX:+VerifyContinuations on linux-aarch64 platform.
>
> $java --enable-preview -XX:+VerifyContinuations Skynet
>
> ```
> # A fatal error has been detected by the Java Runtime E
On Sat, 12 Nov 2022 01:30:57 GMT, Fei Yang wrote:
> > Nice to have PR 1. It's gonna take a long time until we see 11.
>
> Nice PR number :-) May I ask if you could also add handling for riscv while
> you are at it? We have ported loom to this platform recently [1]. I can help
> perform
> The current loom code makes some assumptions about GC that will not work with
> generational ZGC. We should make this code more GC agnostic, and provide a
> better interface for talking to the GC.
>
> In particular,
> 1) All GCs have a way of encoding oops inside of the heap differently to oop
On Fri, 11 Nov 2022 16:16:18 GMT, Erik Österlund wrote:
> The current loom code makes some assumptions about GC that will not work with
> generational ZGC. We should make this code more GC agnostic, and provide a
> better interface for talking to the GC.
>
> In particular,
> 1) All GCs have a
On Fri, 11 Nov 2022 19:41:56 GMT, Erik Österlund wrote:
> Nice to have PR 1. It's gonna take a long time until we see 11.
Nice PR number :-)
May I ask if you could also add handling for riscv while you are at it? We have
ported loom to this platform recently [1].
[1] https://git.openjd
On Fri, 11 Nov 2022 16:16:18 GMT, Erik Österlund wrote:
> The current loom code makes some assumptions about GC that will not work with
> generational ZGC. We should make this code more GC agnostic, and provide a
> better interface for talking to the GC.
>
> In particular,
> 1) All GCs have a
The current loom code makes some assumptions about GC that will not work with
generational ZGC. We should make this code more GC agnostic, and provide a
better interface for talking to the GC.
In particular,
1) All GCs have a way of encoding oops inside of the heap differently to oops
outside o
28 matches
Mail list logo
