On Thu, 17 Nov 2022 01:55:44 GMT, David Holmes wrote:
>> Lutz Schmidt has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - 8296709: Copyright, descriptive text, @compile directive removed
>> - 8296709: Fix test run spec, exclude jdwp agent
On Wed, 16 Nov 2022 12:00:56 GMT, Lutz Schmidt wrote:
>> This small change fixes a warning that may pop up during runtime. May I
>> please request reviews? Thank you!
>
> Lutz Schmidt has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - 82967
On Wed, 16 Nov 2022 12:00:56 GMT, Lutz Schmidt wrote:
>> This small change fixes a warning that may pop up during runtime. May I
>> please request reviews? Thank you!
>
> Lutz Schmidt has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - 82967
On Wed, 16 Nov 2022 12:00:56 GMT, Lutz Schmidt wrote:
>> This small change fixes a warning that may pop up during runtime. May I
>> please request reviews? Thank you!
>
> Lutz Schmidt has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - 82967
On Wed, 16 Nov 2022 12:00:56 GMT, Lutz Schmidt wrote:
>> This small change fixes a warning that may pop up during runtime. May I
>> please request reviews? Thank you!
>
> Lutz Schmidt has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - 82967
> This small change fixes a warning that may pop up during runtime. May I
> please request reviews? Thank you!
Lutz Schmidt has updated the pull request incrementally with two additional
commits since the last revision:
- 8296709: Copyright, descriptive text, @compile directive removed
- 8296
On Tue, 15 Nov 2022 13:38:51 GMT, Christoph Langer wrote:
>> Lutz Schmidt has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8296709: use multiple test ids
>
> test/jdk/tools/launcher/TestXcheckJNIWarnings.java line 31:
>
>> 29: * @test i
On Tue, 15 Nov 2022 12:58:12 GMT, Lutz Schmidt wrote:
>> This small change fixes a warning that may pop up during runtime. May I
>> please request reviews? Thank you!
>
> Lutz Schmidt has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8296709
On Tue, 15 Nov 2022 12:58:12 GMT, Lutz Schmidt wrote:
>> This small change fixes a warning that may pop up during runtime. May I
>> please request reviews? Thank you!
>
> Lutz Schmidt has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8296709
> This small change fixes a warning that may pop up during runtime. May I
> please request reviews? Thank you!
Lutz Schmidt has updated the pull request incrementally with one additional
commit since the last revision:
8296709: use multiple test ids
-
Changes:
- all: https://g
On Mon, 14 Nov 2022 14:19:48 GMT, Lutz Schmidt wrote:
>> This small change fixes a warning that may pop up during runtime. May I
>> please request reviews? Thank you!
>
> Lutz Schmidt has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8296709
On Mon, 14 Nov 2022 14:19:48 GMT, Lutz Schmidt wrote:
>> This small change fixes a warning that may pop up during runtime. May I
>> please request reviews? Thank you!
>
> Lutz Schmidt has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8296709
On Mon, 14 Nov 2022 11:36:21 GMT, Christoph Langer wrote:
> Hm, I also don't like the code duplication...
Code duplication is gone. Just one test file with two @run tags.
-
PR: https://git.openjdk.org/jdk/pull/11083
> This small change fixes a warning that may pop up during runtime. May I
> please request reviews? Thank you!
Lutz Schmidt has updated the pull request incrementally with one additional
commit since the last revision:
8296709: use multiple @run tags instead of multiple files
-
On Mon, 14 Nov 2022 11:07:52 GMT, Lutz Schmidt wrote:
> > Couldn't you simply add a second `doExec` statement in the existing test
> > rather than copy the entire test file?
>
> Actually, I first did it that way. And I did not like it. It's not just the
> doExec, you need to duplicate the chec
> This small change fixes a warning that may pop up during runtime. May I
> please request reviews? Thank you!
Lutz Schmidt has updated the pull request incrementally with two additional
commits since the last revision:
- 8296709: typo
- 8296709: Copyright year and more specific summary text
On Sun, 13 Nov 2022 23:51:28 GMT, David Holmes wrote:
> Couldn't you simply add a second `doExec` statement in the existing test
> rather than copy the entire test file?
Actually, I first did it that way. And I did not like it. It's not just the
doExec, you need to duplicate the checks as well
On Fri, 11 Nov 2022 23:01:12 GMT, Christoph Langer wrote:
>> Lutz Schmidt has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8296709: fix testcase naming
>
> test/jdk/tools/launcher/TestXcheckJdwpJNIWarnings.java line 2:
>
>> 1: /*
>> 2:
On Fri, 11 Nov 2022 16:26:59 GMT, Lutz Schmidt wrote:
>> This small change fixes a warning that may pop up during runtime. May I
>> please request reviews? Thank you!
>
> Lutz Schmidt has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8296709
On Fri, 11 Nov 2022 16:26:59 GMT, Lutz Schmidt wrote:
>> This small change fixes a warning that may pop up during runtime. May I
>> please request reviews? Thank you!
>
> Lutz Schmidt has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8296709
> This small change fixes a warning that may pop up during runtime. May I
> please request reviews? Thank you!
Lutz Schmidt has updated the pull request incrementally with one additional
commit since the last revision:
8296709: fix testcase naming
-
Changes:
- all: https://git
On Fri, 11 Nov 2022 15:33:20 GMT, Lutz Schmidt wrote:
>> This small change fixes a warning that may pop up during runtime. May I
>> please request reviews? Thank you!
>
> Lutz Schmidt has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8296709
> This small change fixes a warning that may pop up during runtime. May I
> please request reviews? Thank you!
Lutz Schmidt has updated the pull request incrementally with one additional
commit since the last revision:
8296709: add testcase with active jdwp agent
-
Changes:
-
On Fri, 11 Nov 2022 06:26:19 GMT, Christoph Langer wrote:
>> This small change fixes a warning that may pop up during runtime. May I
>> please request reviews? Thank you!
>
> Maybe you could also call "bin/java -Xcheck:jni
> -agentlib:jdwp=transport=dt_socket,server=y,suspend=n -version" which
On Fri, 11 Nov 2022 06:26:19 GMT, Christoph Langer wrote:
>> This small change fixes a warning that may pop up during runtime. May I
>> please request reviews? Thank you!
>
> Maybe you could also call "bin/java -Xcheck:jni
> -agentlib:jdwp=transport=dt_socket,server=y,suspend=n -version" which
On Thu, 10 Nov 2022 09:02:02 GMT, Lutz Schmidt wrote:
> This small change fixes a warning that may pop up during runtime. May I
> please request reviews? Thank you!
Maybe you could also call "bin/java -Xcheck:jni
-agentlib:jdwp=transport=dt_socket,server=y,suspend=n -version" which would
show
On Thu, 10 Nov 2022 12:20:58 GMT, David Holmes wrote:
> Can the test be augmented to catch this case too?
David,
the test already catches both warnings. The warnings are only issued under
special circumstances. That's why everything looks fine in most cases. SAP's
commercial vm has a feature c
On Thu, 10 Nov 2022 09:02:02 GMT, Lutz Schmidt wrote:
> This small change fixes a warning that may pop up during runtime. May I
> please request reviews? Thank you!
Can the test be augmented to catch this case too?
-
PR: https://git.openjdk.org/jdk/pull/11083
On Thu, 10 Nov 2022 09:02:02 GMT, Lutz Schmidt wrote:
> This small change fixes a warning that may pop up during runtime. May I
> please request reviews? Thank you!
Thanks for the review, Kevin!
I'm looking into the "exceeds capacity" warning separately. Need to find out
who is holding so man
On Thu, 10 Nov 2022 09:02:02 GMT, Lutz Schmidt wrote:
> This small change fixes a warning that may pop up during runtime. May I
> please request reviews? Thank you!
Looks good.
Thank you for taking care about this.
Serguei
-
Marked as reviewed by sspitsyn (Reviewer).
PR: https://
On Thu, 10 Nov 2022 09:02:02 GMT, Lutz Schmidt wrote:
> This small change fixes a warning that may pop up during runtime. May I
> please request reviews? Thank you!
Looks good I think. Got to check for those exceptions!
The example invocation also shows the me "exceeds capacity" warning, whic
This small change fixes a warning that may pop up during runtime. May I please
request reviews? Thank you!
-
Commit messages:
- 8296709: WARNING: JNI call made without checking exceptions
Changes: https://git.openjdk.org/jdk/pull/11083/files
Webrev: https://webrevs.openjdk.org/?re
32 matches
Mail list logo
