On Fri, 28 Oct 2022 04:01:18 GMT, David Holmes wrote:
>> I moved misc_flags out to their own misc flags class so that we can put the
>> writeable accessFlags there too with atomic access.
>>
>> Tested with tier1-4.
>
> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/oops/InstanceKlass.java
On Fri, 28 Oct 2022 03:59:45 GMT, David Holmes wrote:
>> src/hotspot/share/prims/jvmtiRedefineClasses.cpp line 4408:
>>
>>> 4406: if (!the_class->has_been_redefined()) {
>>> 4407: the_class->set_has_been_redefined();
>>> 4408: }
>>
>> Nit: Is this change really needed?
>
> Seems unrelat
On Tue, 13 Sep 2022 13:29:45 GMT, Coleen Phillimore wrote:
> I moved misc_flags out to their own misc flags class so that we can put the
> writeable accessFlags there too with atomic access.
>
> Tested with tier1-4.
Thank you for the code reviews, David and Serguei.
-
PR: https:/
On Fri, 28 Oct 2022 01:36:56 GMT, Serguei Spitsyn wrote:
>> I moved misc_flags out to their own misc flags class so that we can put the
>> writeable accessFlags there too with atomic access.
>>
>> Tested with tier1-4.
>
> src/hotspot/share/prims/jvmtiRedefineClasses.cpp line 4408:
>
>> 4406:
On Tue, 13 Sep 2022 13:29:45 GMT, Coleen Phillimore wrote:
> I moved misc_flags out to their own misc flags class so that we can put the
> writeable accessFlags there too with atomic access.
>
> Tested with tier1-4.
Refactoring looks good. These are all the immutable flags right? (ie set once
On Tue, 13 Sep 2022 13:29:45 GMT, Coleen Phillimore wrote:
> I moved misc_flags out to their own misc flags class so that we can put the
> writeable accessFlags there too with atomic access.
>
> Tested with tier1-4.
Nice refactoring and simplification.
It looks good to me.
Thanks,
Serguei
src
I moved misc_flags out to their own misc flags class so that we can put the
writeable accessFlags there too with atomic access.
Tested with tier1-4.
-
Commit messages:
- 8295964: Move InstanceKlass::_misc_flags
Changes: https://git.openjdk.org/jdk/pull/10249/files
Webrev: https:/
