Re: RFR: 8291555: Implement alternative fast-locking scheme [v60]

2023-04-28 Thread Thomas Stuefe
On Wed, 26 Apr 2023 18:58:13 GMT, Roman Kennke wrote: >>> @rkennke - I'm planning to do another crawl thru review next week. >> >> Thanks! That is greatly appeciated! > >> @rkennke - finished my second crawl thru review of 60/68 files changed. I >> only skipped the RISC-V files since I know nad

Re: RFR: 8291555: Implement alternative fast-locking scheme [v60]

2023-04-26 Thread Roman Kennke
On Mon, 24 Apr 2023 19:42:35 GMT, Roman Kennke wrote: >> Hi there, >> what is needed to bring this PR over the approval line? > >> @rkennke - I'm planning to do another crawl thru review next week. > > Thanks! That is greatly appeciated! > @rkennke - finished my second crawl thru review of 60/6

Re: RFR: 8291555: Implement alternative fast-locking scheme [v60]

2023-04-26 Thread Daniel D . Daugherty
On Mon, 24 Apr 2023 19:42:35 GMT, Roman Kennke wrote: >> Hi there, >> what is needed to bring this PR over the approval line? > >> @rkennke - I'm planning to do another crawl thru review next week. > > Thanks! That is greatly appeciated! @rkennke - finished my second crawl thru review of 60/68

Re: RFR: 8291555: Implement alternative fast-locking scheme [v60]

2023-04-24 Thread Roman Kennke
On Mon, 17 Apr 2023 20:00:58 GMT, Roman Kennke wrote: >> Roman Kennke has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 156 commits: >> >> - Merge remote-tracking branch 'upstream/master' into JDK-8291555-v2 >> - A few more LM_ pr

Re: RFR: 8291555: Implement alternative fast-locking scheme [v60]

2023-04-21 Thread Daniel D . Daugherty
On Mon, 17 Apr 2023 20:00:58 GMT, Roman Kennke wrote: >> Roman Kennke has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 156 commits: >> >> - Merge remote-tracking branch 'upstream/master' into JDK-8291555-v2 >> - A few more LM_ pr

Re: RFR: 8291555: Implement alternative fast-locking scheme [v60]

2023-04-17 Thread Roman Kennke
On Fri, 14 Apr 2023 11:19:32 GMT, Roman Kennke wrote: >> This change adds a fast-locking scheme as an alternative to the current >> stack-locking implementation. It retains the advantages of stack-locking >> (namely fast locking in uncontended code-paths), while avoiding the overload >> of the

Re: RFR: 8291555: Implement alternative fast-locking scheme [v60]

2023-04-14 Thread Roman Kennke
> This change adds a fast-locking scheme as an alternative to the current > stack-locking implementation. It retains the advantages of stack-locking > (namely fast locking in uncontended code-paths), while avoiding the overload > of the mark word. That overloading causes massive problems with Li