On Wed, 22 Mar 2023 09:18:51 GMT, David Holmes wrote:
>> src/hotspot/share/prims/jvmtiEnvBase.hpp line 166:
>>
>>> 164:
>>> 165: const void* get_env_local_storage() { return _env_local_storage; }
>>> 166:
>>
>> Why was this change/move necessary? Do I miss anything?
>
> It is now public, no
On Tue, 14 Mar 2023 12:22:16 GMT, Markus Grönlund wrote:
>> n.b. that also applies for accesses/updates to field _next.
>
> I wanted all accesses to use the iterator. The only access is given to the
> iterator and AgentList by way of being friends. No need to expose more.
I updated all external
On Tue, 14 Mar 2023 12:26:16 GMT, Markus Grönlund wrote:
> I've had a good look through now and have a better sense of the refactoring.
> Seems good.
>
> I'll wait for any tweaks before hitting the approve button though.
>
> Thanks
Moving the loading logic to the agent.cpp module was a bit ha
On Tue, 14 Mar 2023 12:23:08 GMT, Markus Grönlund wrote:
>> src/hotspot/share/prims/agentList.cpp line 419:
>>
>>> 417: const jint err = (*on_load_entry)(&main_vm,
>>> const_cast(agent->options()), NULL);
>>> 418: if (err != JNI_OK) {
>>> 419: vm_exit_during_initialization("-Xrun
On Tue, 21 Mar 2023 00:53:31 GMT, Serguei Spitsyn wrote:
>> Markus Grönlund has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> more cleanup
>
> src/hotspot/share/prims/jvmtiEnvBase.hpp line 166:
>
>> 164:
>> 165: const void* get_env_loc
On Fri, 10 Mar 2023 10:43:23 GMT, Markus Grönlund wrote:
>> Greetings,
>>
>> We are adding support to let JFR report on Agents.
>>
>> Design
>>
>> An Agent is a library that uses any instrumentation or profiling APIs. Most
>> agents are started and initialized on the command line, but ag
On Tue, 14 Mar 2023 12:26:16 GMT, Markus Grönlund wrote:
>> I've had a good look through now and have a better sense of the refactoring.
>> Seems good.
>>
>> I'll wait for any tweaks before hitting the approve button though.
>>
>> Thanks
>
>> I've had a good look through now and have a better
On Mon, 13 Mar 2023 09:46:04 GMT, Andrew Dinn wrote:
>> Markus Grönlund has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> more cleanup
>
> src/hotspot/share/jfr/metadata/metadata.xml line 1182:
>
>> 1180: > description="The time the J
On Tue, 14 Mar 2023 06:01:05 GMT, David Holmes wrote:
> I've had a good look through now and have a better sense of the refactoring.
> Seems good.
>
>
>
> I'll wait for any tweaks before hitting the approve button though.
>
>
>
> Thanks
Thanks so much for taking a look. I realized that im
On Mon, 13 Mar 2023 09:49:39 GMT, Andrew Dinn wrote:
>> src/hotspot/share/prims/agentList.cpp line 64:
>>
>>> 62: void AgentList::add_xrun(const char* name, char* options, bool
>>> absolute_path) {
>>> 63: Agent* agent = new Agent(name, options, absolute_path);
>>> 64: agent->_is_xrun = tru
On Mon, 13 Mar 2023 06:22:21 GMT, David Holmes wrote:
>> Markus Grönlund has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> more cleanup
>
> src/hotspot/share/prims/agent.cpp line 34:
>
>> 32: }
>> 33:
>> 34: static const char* allocate_c
On Fri, 10 Mar 2023 10:43:23 GMT, Markus Grönlund wrote:
>> Greetings,
>>
>> We are adding support to let JFR report on Agents.
>>
>> Design
>>
>> An Agent is a library that uses any instrumentation or profiling APIs. Most
>> agents are started and initialized on the command line, but ag
On Thu, 9 Mar 2023 09:29:41 GMT, Markus Grönlund wrote:
>> src/hotspot/share/runtime/threads.cpp line 338:
>>
>>> 336: if (EagerXrunInit && Arguments::init_libraries_at_startup()) {
>>> 337: create_vm_init_libraries();
>>> 338: }
>>
>> Not obvious where this went. Changes to the initial
On Mon, 13 Mar 2023 06:29:11 GMT, David Holmes wrote:
>> Markus Grönlund has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> more cleanup
>
> src/hotspot/share/prims/agentList.cpp line 64:
>
>> 62: void AgentList::add_xrun(const char* name,
On Fri, 10 Mar 2023 10:43:23 GMT, Markus Grönlund wrote:
>> Greetings,
>>
>> We are adding support to let JFR report on Agents.
>>
>> Design
>>
>> An Agent is a library that uses any instrumentation or profiling APIs. Most
>> agents are started and initialized on the command line, but ag
On Fri, 10 Mar 2023 10:43:23 GMT, Markus Grönlund wrote:
>> Greetings,
>>
>> We are adding support to let JFR report on Agents.
>>
>> Design
>>
>> An Agent is a library that uses any instrumentation or profiling APIs. Most
>> agents are started and initialized on the command line, but ag
> Greetings,
>
> We are adding support to let JFR report on Agents.
>
> Design
>
> An Agent is a library that uses any instrumentation or profiling APIs. Most
> agents are started and initialized on the command line, but agents can also
> be loaded dynamically during runtime. Because comm
17 matches
Mail list logo
