On Mon, 13 Mar 2023 09:46:04 GMT, Andrew Dinn <ad...@openjdk.org> wrote:

>> Markus Grönlund has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   more cleanup
>
> src/hotspot/share/jfr/metadata/metadata.xml line 1182:
> 
>> 1180:     <Field type="Ticks" name="initialization" label="Initialization" 
>> description="The time the JVM initialized the agent" />
>> 1181:     <Field type="Tickspan" name="initializationTime" 
>> label="Initialization Time" description="The duration of executing the 
>> initialization method exported by the agent" />
>> 1182:   </Event>
> 
> @mgronlun A somewhat drive-by comment. It might be clearer if you renamed 
> these event fields and accessors, plus also the corresponding fields and 
> accessors in class Agent, as `initializationTime` and 
> `initializationDuration`.

Makes sense.

-------------

PR: https://git.openjdk.org/jdk/pull/12923

Reply via email to