Re: RFR: 8256811: Delayed/missed jdwp class unloading events [v17]

2022-07-22 Thread Zhengyu Gu
On Thu, 21 Jul 2022 15:31:48 GMT, Chris Plummer wrote: >>> > The following RN is related to this question: >>> > https://bugs.openjdk.org/browse/JDK-8256558 >>> > It explicitly says: `SetNotificationMode can be used to explicitly flush >>> > ObjectFree events, if needed.` >>> >>> That wasn't qu

Re: RFR: 8256811: Delayed/missed jdwp class unloading events [v17]

2022-07-21 Thread Serguei Spitsyn
On Thu, 21 Jul 2022 15:31:48 GMT, Chris Plummer wrote: > This becomes a problem when the test tries to free a raw monitor on exit. It > first disable events, then it frees the raw monitor that the even handler > synchronizes on. However, it's possible that an event can be in flight when > doin

Re: RFR: 8256811: Delayed/missed jdwp class unloading events [v17]

2022-07-21 Thread Chris Plummer
On Thu, 21 Jul 2022 05:42:49 GMT, Serguei Spitsyn wrote: > > That wasn't quite what I was getting at. My comment / question was much > > more general. If you call SetEventNotificationMode() to disable a specific > > event, once it returns are you guaranteed that no more events will be > > deli

Re: RFR: 8256811: Delayed/missed jdwp class unloading events [v17]

2022-07-20 Thread Serguei Spitsyn
On Thu, 21 Jul 2022 04:11:05 GMT, Chris Plummer wrote: > > The following RN is related to this question: > > https://bugs.openjdk.org/browse/JDK-8256558 > > It explicitly says: `SetNotificationMode can be used to explicitly flush > > ObjectFree events, if needed.` > > That wasn't quite what I w

Re: RFR: 8256811: Delayed/missed jdwp class unloading events [v17]

2022-07-20 Thread Chris Plummer
On Thu, 21 Jul 2022 03:51:32 GMT, Serguei Spitsyn wrote: > The following RN is related to this question: > https://bugs.openjdk.org/browse/JDK-8256558 > It explicitly says: `SetNotificationMode can be used to explicitly flush > ObjectFree events, if needed.` That wasn't quite what I was getting

Re: RFR: 8256811: Delayed/missed jdwp class unloading events [v17]

2022-07-20 Thread Serguei Spitsyn
On Wed, 13 Jul 2022 18:46:07 GMT, Chris Plummer wrote: > `Actually I'm going to amend my previous comment about concerns with > synchronization of the test. I think once the SetEventNotificationMode() call > returns (after passing JVMTI_DISABLE), the caller should be guaranteed that > any call

Re: RFR: 8256811: Delayed/missed jdwp class unloading events [v17]

2022-07-18 Thread Zhengyu Gu
On Mon, 18 Jul 2022 20:04:14 GMT, Coleen Phillimore wrote: >> Zhengyu Gu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix a bug > > src/hotspot/share/prims/jvmtiTagMap.cpp line 1223: > >> 1221: MonitorLocker ml(lock(), Mutex::_

Re: RFR: 8256811: Delayed/missed jdwp class unloading events [v17]

2022-07-18 Thread Coleen Phillimore
On Tue, 12 Jul 2022 22:02:59 GMT, Zhengyu Gu wrote: >> Currently, jdi only check and process class unloading event when it detects >> a new GC cycle. >> >> After [JDK-8212879](https://bugs.openjdk.org/browse/JDK-8212879), posting >> class events can overlap with GC finish event, that results,

Re: RFR: 8256811: Delayed/missed jdwp class unloading events [v17]

2022-07-13 Thread Chris Plummer
On Wed, 13 Jul 2022 13:20:45 GMT, Zhengyu Gu wrote: >> Ok. Everything is passing after your latest fix. >> >> I think the test still has a synchronization bug, but probably not something >> important enough to worry about, and I'm guessing a lot of tests have this >> issue. The test disables e

Re: RFR: 8256811: Delayed/missed jdwp class unloading events [v17]

2022-07-13 Thread Chris Plummer
On Tue, 12 Jul 2022 22:02:59 GMT, Zhengyu Gu wrote: >> Currently, jdi only check and process class unloading event when it detects >> a new GC cycle. >> >> After [JDK-8212879](https://bugs.openjdk.org/browse/JDK-8212879), posting >> class events can overlap with GC finish event, that results,

Re: RFR: 8256811: Delayed/missed jdwp class unloading events [v17]

2022-07-13 Thread Zhengyu Gu
On Wed, 13 Jul 2022 01:14:48 GMT, Chris Plummer wrote: > Ok. Everything is passing after your latest fix. > > I think the test still has a synchronization bug, but probably not something > important enough to worry about, and I'm guessing a lot of tests have this > issue. The test disables eve

Re: RFR: 8256811: Delayed/missed jdwp class unloading events [v17]

2022-07-12 Thread Chris Plummer
On Tue, 12 Jul 2022 22:02:59 GMT, Zhengyu Gu wrote: >> Currently, jdi only check and process class unloading event when it detects >> a new GC cycle. >> >> After [JDK-8212879](https://bugs.openjdk.org/browse/JDK-8212879), posting >> class events can overlap with GC finish event, that results,

Re: RFR: 8256811: Delayed/missed jdwp class unloading events [v17]

2022-07-12 Thread Chris Plummer
On Tue, 12 Jul 2022 22:02:59 GMT, Zhengyu Gu wrote: >> Currently, jdi only check and process class unloading event when it detects >> a new GC cycle. >> >> After [JDK-8212879](https://bugs.openjdk.org/browse/JDK-8212879), posting >> class events can overlap with GC finish event, that results,

Re: RFR: 8256811: Delayed/missed jdwp class unloading events [v17]

2022-07-12 Thread Zhengyu Gu
> Currently, jdi only check and process class unloading event when it detects a > new GC cycle. > > After [JDK-8212879](https://bugs.openjdk.org/browse/JDK-8212879), posting > class events can overlap with GC finish event, that results, sometimes, it > only captures partial or even empty unload