On Tue, 10 Dec 2024 12:41:00 GMT, Simon Tooke wrote:
>> This is a port of #16301 to macOS.
>>
>> System.map and System.dump_map are implemented using the macOS API and
>> provide roughly the same information in the same format. Most of the heavy
>> lifting was implemented by @tstuefe in
>> h
On Thu, 12 Dec 2024 11:39:33 GMT, Thomas Stuefe wrote:
> Two fixes to fix the 32-bit build.
>
> See JBS issue and code comment for details.
>
> I ran nNoClassDefFoundErrorTest x64 and x86 fastdebug and release. On
> fastdebug, the giant string test now gets silently skipped as expected.
I am
On Tue, 5 Nov 2024 14:22:06 GMT, Sonia Zaldana Calles
wrote:
>> - Changed several "NULL" in comments to "null"
>> - Changed several `NULL` in code to `nullptr`
>
> Hi @theoweidmannoracle, I think the GHA tests are not running because you
> haven
On Fri, 1 Nov 2024 13:35:56 GMT, theoweidmannoracle wrote:
> - Changed several "NULL" in comments to "null"
> - Changed several `NULL` in code to `nullptr`
Hi @theoweidmannoracle, I think the GHA tests are not running because you
haven't enabled GHA on your personal fork. See
https://wiki.open
On Fri, 1 Nov 2024 13:35:56 GMT, theoweidmannoracle wrote:
> - Changed several "NULL" in comments to "null"
> - Changed several `NULL` in code to `nullptr`
I am not a Reviewer but I left a small comment.
Cheers!
src/hotspot/os/linux/cgroupSubsystem_linux.cpp line 1:
> 1: /*
Missing copyrigh
On Tue, 10 Sep 2024 15:42:57 GMT, Sonia Zaldana Calles
wrote:
>> Hi all,
>>
>> This PR addresses [8204681](https://bugs.openjdk.org/browse/JDK-8204681)
>> enabling support for timestamp expansion in filenames specified in
>> `-XX:HeapDumpPath` using `%t`
On Thu, 17 Oct 2024 16:12:26 GMT, Kevin Walls wrote:
>> Man page update for jcmd.
>>
>> Add updates for the filename options/arguments affected by:
>> 8334492: DiagnosticCommands (jcmd) should accept %p in output filenames and
>> substitute PID
>>
>> Also:
>> In the initial "command" summary,
On Mon, 16 Sep 2024 15:39:58 GMT, Kevin Walls wrote:
> The few uses of the operation parameter type "JULONG" in Diagnostic Commands
> should be changed to INT.
Hi Kevin,
I had some questions about this change.
Regarding the `INTEGER` -> `INT` change, I was wondering if the plan was to
also
On Mon, 16 Sep 2024 19:51:20 GMT, Leonid Mesnik wrote:
>> The inner 'int max;' declaration hide previous max.
>
> Leonid Mesnik has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - typo fixed.
> - check added.
Thanks!
test/hotspot/jtreg/se
On Mon, 16 Sep 2024 19:14:01 GMT, Leonid Mesnik wrote:
> The inner 'int max;' declaration hide previous max.
I am not a Reviewer but this looks good to me.
test/hotspot/jtreg/serviceability/dcmd/vm/EventsTest.java line 81:
> 79: long lines = output.asLines().stream().filter(x ->
> x.
On Thu, 12 Sep 2024 14:04:54 GMT, Simon Tooke wrote:
>> This is a port of [JDK-8318636](https://github.com/openjdk/jdk/pull/16301)
>> to Windows.
>>
>> System.map and System.dump_map are implemented using the Windows API and
>> provide roughly the same information in the same format. Most of
On Wed, 11 Sep 2024 14:49:50 GMT, Simon Tooke wrote:
>
> I agree, and will probably do this next week. If it looks good to you, could
> you please mark as reviewed? You're on the list of reviewers.
FYI, I filed [JDK-8339970](https://bugs.openjdk.org/browse/JDK-8339970) to
track this.
---
On Wed, 11 Sep 2024 13:32:49 GMT, Simon Tooke wrote:
>> This is a port of [JDK-8318636](https://github.com/openjdk/jdk/pull/16301)
>> to Windows.
>>
>> System.map and System.dump_map are implemented using the Windows API and
>> provide roughly the same information in the same format. Most of
On Tue, 10 Sep 2024 15:42:57 GMT, Sonia Zaldana Calles
wrote:
>> Hi all,
>>
>> This PR addresses [8204681](https://bugs.openjdk.org/browse/JDK-8204681)
>> enabling support for timestamp expansion in filenames specified in
>> `-XX:HeapDumpPath` using `%t`
think we can edit it to more broadly support filename expansion to
> support `%t` for jcmd as well.
>
> Testing:
> - [x] Added test cases pass with all platforms (verified with a GHA job).
> - [x] Tier 1 passes with GHA.
>
> Looking forward to hearing your thoughts!
>
&g
On Tue, 27 Aug 2024 22:58:52 GMT, Simon Tooke wrote:
>> This is a port of [JDK-8318636](https://github.com/openjdk/jdk/pull/16301)
>> to Windows.
>>
>> System.map and System.dump_map are implemented using the Windows API and
>> provide roughly the same information in the same format. Most of
On Tue, 13 Aug 2024 15:07:17 GMT, Sonia Zaldana Calles
wrote:
> Hi all,
>
> This PR addresses [8204681](https://bugs.openjdk.org/browse/JDK-8204681)
> enabling support for timestamp expansion in filenames specified in
> `-XX:HeapDumpPath` using `%t`.
>
> As mentioned
On Tue, 13 Aug 2024 15:07:17 GMT, Sonia Zaldana Calles
wrote:
> Hi all,
>
> This PR addresses [8204681](https://bugs.openjdk.org/browse/JDK-8204681)
> enabling support for timestamp expansion in filenames specified in
> `-XX:HeapDumpPath` using `%t`.
>
> As mentioned
Hi all,
This PR addresses [8204681](https://bugs.openjdk.org/browse/JDK-8204681)
enabling support for timestamp expansion in filenames specified in
`-XX:HeapDumpPath` using `%t`.
As mentioned in this comments for this issue, this is somewhat related to
[8334492](https://bugs.openjdk.org/brow
On Wed, 31 Jul 2024 08:30:47 GMT, Kevin Walls wrote:
> Man page update for jcmd.
>
> Add updates for the filename options/arguments affected by:
> 8334492: DiagnosticCommands (jcmd) should accept %p in output filenames and
> substitute PID
>
> Also:
> In the initial "command" summary, remove t
On Thu, 1 Aug 2024 14:25:47 GMT, Sonia Zaldana Calles
wrote:
> Hi all,
>
> This PR addresses [8337667](https://bugs.openjdk.org/browse/JDK-8337667) .
>
> The `Compiler.perfmap` test case is failing on mac and windows as it is only
> enabled in linux. I am removing this te
On Tue, 6 Aug 2024 19:01:45 GMT, Chris Plummer wrote:
>> Hi all,
>>
>> This PR addresses [8337667](https://bugs.openjdk.org/browse/JDK-8337667) .
>>
>> The `Compiler.perfmap` test case is failing on mac and windows as it is only
>> enabled in linux. I am removing this test case and noting th
Hi all,
This PR addresses [8337667](https://bugs.openjdk.org/browse/JDK-8337667) .
The `Compiler.perfmap` test case is failing on mac and windows as it is only
enabled in linux. I am removing this test case and noting that this use case is
already tested in
[test/hotspot/jtreg/serviceability
On Tue, 16 Jul 2024 16:25:50 GMT, Sonia Zaldana Calles
wrote:
> Hi all,
>
> This PR addresses [8334492](https://bugs.openjdk.org/browse/JDK-8334492)
> enabling jcmd diagnostic commands that issue an output file to accept the
> `%p` pattern in the file name and substitute
his PR can’t
> address that.
>
> Testing:
>
> - [x] Added test case passes.
> - [x] Modified existing VM.cds tests to also check for `%p` filenames.
>
> Looking forward to your comments and addressing any diagnostic commands I
> might have missed (if any
On Mon, 29 Jul 2024 09:39:07 GMT, Kevin Walls wrote:
>>> One more thing that's troubling me. (Apologies it's now and not last week.)
>>>
>>> I was looking at the _filename.value().get() usage and finding it
>>> uncomfortable, compared to the previous simple _filename.value() 8-) Harder
>>> to
his PR can’t
> address that.
>
> Testing:
>
> - [x] Added test case passes.
> - [x] Modified existing VM.cds tests to also check for `%p` filenames.
>
> Looking forward to your comments and addressing any diagnostic commands I
> might have missed (if any).
>
&g
his PR can’t
> address that.
>
> Testing:
>
> - [x] Added test case passes.
> - [x] Modified existing VM.cds tests to also check for `%p` filenames.
>
> Looking forward to your comments and addressing any diagnostic commands I
> might have missed (if an
his PR can’t
> address that.
>
> Testing:
>
> - [x] Added test case passes.
> - [x] Modified existing VM.cds tests to also check for `%p` filenames.
>
> Looking forward to your comments and addressing any diagnostic commands I
> might have missed (if any).
>
>
On Thu, 25 Jul 2024 14:51:22 GMT, Kevin Walls wrote:
> > > good as it's a way of telling people these are FILEs therefore %p is
> > > interpreted, rather than just a STRING.
> >
> >
> > Hi Kevin,
> > I feel this could be more explicit by updating the manpage to explain the
> > %p substitution
his PR can’t
> address that.
>
> Testing:
>
> - [x] Added test case passes.
> - [x] Modified existing VM.cds tests to also check for `%p` filenames.
>
> Looking forward to your comments and addressing any diagnostic commands I
> might have missed (if any).
&
On Thu, 25 Jul 2024 13:11:00 GMT, Kevin Walls wrote:
> good as it's a way of telling people these are FILEs therefore %p is
> interpreted, rather than just a STRING.
Hi Kevin,
I feel this could be more explicit by updating the manpage to explain the %p
substitution rather than updating the t
his PR can’t
> address that.
>
> Testing:
>
> - [x] Added test case passes.
> - [x] Modified existing VM.cds tests to also check for `%p` filenames.
>
> Looking forward to your comments and addressing any diagnostic commands I
> might have missed (if any).
>
On Wed, 24 Jul 2024 10:38:01 GMT, Kevin Walls wrote:
> In src/hotspot/share/runtime/java.cpp: if (DumpPerfMapAtExit) {
> CodeCache::write_perf_map(
>
> It may need to pass DEFAULT_PERFMAP_FILENAME (and tty).
>
> Do you have the change from JDK-8327054 merged into this branch?
Good point -
his PR can’t
> address that.
>
> Testing:
>
> - [x] Added test case passes.
> - [x] Modified existing VM.cds tests to also check for `%p` filenames.
>
> Looking forward to your comments and addressing any diagnostic commands I
> might have missed (if any).
>
&
his PR can’t
> address that.
>
> Testing:
>
> - [x] Added test case passes.
> - [x] Modified existing VM.cds tests to also check for `%p` filenames.
>
> Looking forward to your comments and addressing any diagnostic commands I
> might have missed (if
his PR can’t
> address that.
>
> Testing:
>
> - [x] Added test case passes.
> - [x] Modified existing VM.cds tests to also check for `%p` filenames.
>
> Looking forward to your comments and addressing any diagnostic commands I
> might have missed (if any).
>
&
On Wed, 24 Jul 2024 10:35:35 GMT, Kevin Walls wrote:
>> Sonia Zaldana Calles has updated the pull request with a new target base due
>> to a merge or a rebase. The pull request now contains 15 commits:
>>
>> - Merge master
>> - Fixing formatting
>> - Inli
On Wed, 17 Jul 2024 14:21:05 GMT, Thomas Stuefe wrote:
> * In all cases: please, in case of an error, don't THROW, don't do `warning`.
> Instead, just print to the `output()` of the DCmd. You want an error to
> appear to the user of the dcmd - so, to stdout or stderr of the jcmd process
> issu
his PR can’t
> address that.
>
> Testing:
>
> - [x] Added test case passes.
> - [x] Modified existing VM.cds tests to also check for `%p` filenames.
>
> Looking forward to your comments and addressing any diagnostic commands I
> might have missed (if any).
>
his PR can’t
> address that.
>
> Testing:
>
> - [x] Added test case passes.
> - [x] Modified existing VM.cds tests to also check for `%p` filenames.
>
> Looking forward to your comments and addressing any diagnostic commands I
> might have missed (if any).
>
&
On Fri, 19 Jul 2024 15:07:39 GMT, Sonia Zaldana Calles
wrote:
> Hi all,
>
> This is a small patch to address
> [8327054](https://bugs.openjdk.org/browse/JDK-8327054) making
> `CodeCache::write_perf_map` aware of which output stream errors and warning
> message
On Mon, 22 Jul 2024 16:31:32 GMT, Kevin Walls wrote:
> I think it was returning an "exit value" of -1, the
> test/lib/jdk/test/lib/process/OutputBuffer.java default.
Correct, that was the exit value.
> But yes just don't check exit code for a JMX Executor, and jcmd would return
> zero but we
On Sat, 20 Jul 2024 08:02:34 GMT, Thomas Stuefe wrote:
>> src/hotspot/share/services/diagnosticArgument.hpp line 66:
>>
>>> 64: public:
>>> 65: char *_name;
>>> 66: };
>>
>> Something is off about this. What is the lifetime of this object?
>>
>> You don't free it. Running a command in a
On Sun, 21 Jul 2024 10:08:38 GMT, Thomas Stuefe wrote:
>> Sonia, my bad if you already know this stuff but since it's fairly esoteric
>> knowledge nowadays I'd like to help you out in advance: Thomas is proposing
>> the usage of a X macro https://en.wikipedia.org/wiki/X_macro
>>
>> These can b
his PR can’t
> address that.
>
> Testing:
>
> - [x] Added test case passes.
> - [x] Modified existing VM.cds tests to also check for `%p` filenames.
>
> Looking forward to your comments and addressing any diagnostic commands I
> might have missed (if any).
>
>
his PR can’t
> address that.
>
> Testing:
>
> - [x] Added test case passes.
> - [x] Modified existing VM.cds tests to also check for `%p` filenames.
>
> Looking forward to your comments and addressing any diagnostic commands I
> might have missed (if any).
>
>
On Mon, 22 Jul 2024 14:41:16 GMT, Kevin Walls wrote:
>> Sonia Zaldana Calles has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Adding comment
>
> test/hotspot/jtreg/serviceability/dcmd/compiler/PerfMa
ses.
>
> Thanks,
> Sonia
Sonia Zaldana Calles has updated the pull request incrementally with one
additional commit since the last revision:
Updating warning message
-
Changes:
- all: https://git.openjdk.org/jdk/pull/20257/files
- new: https://git.openjdk.org/jdk
ses.
>
> Thanks,
> Sonia
Sonia Zaldana Calles has updated the pull request incrementally with one
additional commit since the last revision:
Adding comment
-
Changes:
- all: https://git.openjdk.org/jdk/pull/20257/files
- new: https://git.openjdk.org/jdk/pull/202
On Fri, 19 Jul 2024 19:21:05 GMT, Chris Plummer wrote:
>> Sonia Zaldana Calles has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Ensuring test case deletes file in case of exception
>
> test/hotspot/jtre
ses.
>
> Thanks,
> Sonia
Sonia Zaldana Calles has updated the pull request incrementally with one
additional commit since the last revision:
Ensuring test case deletes file in case of exception
-
Changes:
- all: https://git.openjdk.org/jdk/pull/20257/files
- new: ht
Hi all,
This is a small patch to address
[8327054](https://bugs.openjdk.org/browse/JDK-8327054) making
`CodeCache::write_perf_map` aware of which output stream errors and warning
message should be going to.
Testing:
- [x] Added test case passes.
Thanks,
Sonia
-
Commit messag
his PR can’t
> address that.
>
> Testing:
>
> - [x] Added test case passes.
> - [x] Modified existing VM.cds tests to also check for `%p` filenames.
>
> Looking forward to your comments and addressing any diagnostic commands I
> might have missed (if a
On Fri, 19 Jul 2024 13:51:17 GMT, Sonia Zaldana Calles
wrote:
>> Hi all,
>>
>> This PR addresses [8334492](https://bugs.openjdk.org/browse/JDK-8334492)
>> enabling jcmd diagnostic commands that issue an output file to accept the
>> `%p` pattern in the file name
his PR can’t
> address that.
>
> Testing:
>
> - [x] Added test case passes.
> - [x] Modified existing VM.cds tests to also check for `%p` filenames.
>
> Looking forward to your comments and addressing any diagnostic commands I
> might have missed (if any).
&g
his PR can’t
> address that.
>
> Testing:
>
> - [x] Added test case passes.
> - [x] Modified existing VM.cds tests to also check for `%p` filenames.
>
> Looking forward to your comments and addressing any diagnostic commands I
> might have missed
his PR can’t
> address that.
>
> Testing:
>
> - [x] Added test case passes.
> - [x] Modified existing VM.cds tests to also check for `%p` filenames.
>
> Looking forward to your comments and addressing any diagnostic commands I
> might have missed
Hi all,
This PR addresses [8334492](https://bugs.openjdk.org/browse/JDK-8334492)
enabling jcmd diagnostic commands that issue an output file to accept the `%p`
pattern in the file name and substitute it for the PID.
This PR addresses the following diagnostic commands:
- [x] Compiler.perfmap
On Tue, 18 Jun 2024 19:48:20 GMT, Sonia Zaldana Calles
wrote:
> Hi all,
>
> This PR addresses [8332124](https://bugs.openjdk.org/browse/JDK-8332124)
> enabling jcmd to recognize options that look like help.
>
> Testing:
> - [x] Added test case passes.
>
>
On Thu, 4 Jul 2024 06:36:41 GMT, Thomas Stuefe wrote:
>> Sonia Zaldana Calles has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Updating comments
>> - Enabling -help to work as well. Updating test cases
> Hi all,
>
> This PR addresses [8332124](https://bugs.openjdk.org/browse/JDK-8332124)
> enabling jcmd to recognize options that look like help.
>
> Testing:
> - [x] Added test case passes.
>
> Thanks,
> Sonia
Sonia Zaldana Calles has updated the pull requ
On Wed, 3 Jul 2024 12:13:34 GMT, Kevin Walls wrote:
>> Sonia Zaldana Calles has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Making enabling help more restrictive. Will not accept -help
>
> Additional test p
s.
> - [x] Added test case passes.
>
> Thanks,
> Sonia
Sonia Zaldana Calles has updated the pull request incrementally with two
additional commits since the last revision:
- Updating comments
- Enabling -help to work as well. Updating test cases
-
Changes:
- all
s.
> - [x] Added test case passes.
>
> Thanks,
> Sonia
Sonia Zaldana Calles has updated the pull request incrementally with one
additional commit since the last revision:
Making enabling help more restrictive. Will not accept -help
-
Changes:
- all: https://git.o
s.
> - [x] Added test case passes.
>
> Thanks,
> Sonia
Sonia Zaldana Calles has updated the pull request incrementally with one
additional commit since the last revision:
Enabling only -h or --help. Also modifying test case
-
Changes:
- all: https://git.o
On Thu, 27 Jun 2024 18:38:14 GMT, Sonia Zaldana Calles
wrote:
>> Hi all,
>>
>> This PR addresses [8332124](https://bugs.openjdk.org/browse/JDK-8332124)
>> enabling jcmd to accept "help" as an argument to subcommands.
>>
>> Testing:
>>
s.
> - [x] Added test case passes.
>
> Thanks,
> Sonia
Sonia Zaldana Calles has updated the pull request incrementally with three
additional commits since the last revision:
- Updating copyright header
- Modifying usage to --help and -help. Updated ensuing test c
On Tue, 25 Jun 2024 13:55:32 GMT, Sonia Zaldana Calles
wrote:
>> Hi all,
>>
>> This PR addresses [8332124](https://bugs.openjdk.org/browse/JDK-8332124)
>> enabling jcmd to accept "help" as an argument to subcommands.
>>
>> Testing:
>>
s.
> - [x] Added test case passes.
>
> Thanks,
> Sonia
Sonia Zaldana Calles has updated the pull request with a new target base due to
a merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by the merge/rebase. The pull request contains three addition
Hi all,
This PR addresses [8332124](https://bugs.openjdk.org/browse/JDK-8332124)
enabling jcmd to accept "help" as an argument to subcommands.
Testing:
- [x] Verified running `jcmd 4711 VM.metaspace help` works along with other
subcommands.
- [x] Added test case passes.
Thanks,
Sonia
--
On Thu, 13 Jun 2024 16:55:15 GMT, Sonia Zaldana Calles
wrote:
> Hi all,
>
> This PR addresses [8334164](https://bugs.openjdk.org/browse/JDK-8334164).
>
> Testing:
> - [x] Verified specifying the literal `vm_memory_map_.txt` as the map
> name does not replace ``.
&
Hi all,
This PR addresses [8334164](https://bugs.openjdk.org/browse/JDK-8334164).
Testing:
- [x] Verified specifying the literal `vm_memory_map_.txt` as the map name
does not replace ``.
- [x] Verified `` is still appropriately replaced if a file path is not
specified.
Thanks,
Sonia
---
On Wed, 29 May 2024 18:12:25 GMT, Sonia Zaldana Calles
wrote:
> Hi folks,
>
> This PR addresses [8332785](https://bugs.openjdk.org/browse/JDK-8332785)
> replacing all naked uses for ```UseSharedSpaces``` with
> ```CDSConfig::is_using_archive```.
>
> Testing:
&g
> Hi folks,
>
> This PR addresses [8332785](https://bugs.openjdk.org/browse/JDK-8332785)
> replacing all naked uses for ```UseSharedSpaces``` with
> ```CDSConfig::is_using_archive```.
>
> Testing:
> - [x] Tier 1 with GHA.
>
> Thanks,
> Sonia
Sonia Za
Hi folks,
This PR addresses [8332785](https://bugs.openjdk.org/browse/JDK-8332785)
replacing all naked uses for ```UseSharedSpaces``` with
```CDSConfig::is_using_archive```.
Testing:
- [x] Tier 1 with GHA.
Thanks,
Sonia
-
Commit messages:
- Missed include statement in vmErr
76 matches
Mail list logo
