Re: RFR: 8338139: {ClassLoading, Memory}MXBean::isVerbose methods are inconsistent with their setVerbose methods [v2]

2024-08-19 Thread Mark Reinhold
On Mon, 19 Aug 2024 19:43:33 GMT, Stefan Karlsson wrote: >> test/jdk/java/lang/management/MemoryMXBean/TestVerboseMemory.java line 50: >> >>> 48: */ >>> 49: >>> 50: import java.lang.management.*; >> >> I thought we tried to avoid wild-card imports. > > Updated. > I thought we tried to avoid

Re: RFR: 8314738: Remove all occurrences of and support for @revised

2023-08-22 Thread Mark Reinhold
On Tue, 22 Aug 2023 08:42:32 GMT, Pavel Rappo wrote: > Please review this simple PR. You can leave the copyright years as-is. - PR Comment: https://git.openjdk.org/jdk/pull/15382#issuecomment-1688104170

Re: RFR: 8314738: Remove all occurrences of and support for @revised

2023-08-22 Thread Mark Reinhold
On Tue, 22 Aug 2023 08:42:32 GMT, Pavel Rappo wrote: > Please review this simple PR. Removing `@revised` tags is not a substantive change, so I wouldn’t update the copyright year as you have in some of these files. Otherwise, this looks fine. - Marked as reviewed by mr (Lead). P

Re: RFR: JDK-8307314: Implementation: Generational Shenandoah (Experimental) [v5]

2023-06-06 Thread Mark Reinhold
On Tue, 6 Jun 2023 20:01:02 GMT, Christine Flood wrote: > We'd like to propose to push now, and tackle/fix the single-gen issue you > identified during RDP1, as well as any other significant single-gen > regressions that may come up. We have four Shen experts on board, Roman, > Aleksey, Kelvin

New candidate JEP: 451: Prepare to Disallow the Dynamic Loading of Agents

2023-05-08 Thread Mark Reinhold
https://openjdk.org/jeps/451 Summary: Issue warnings when agents are loaded dynamically into a running JVM. These warnings aim to prepare users for a future release which disallows the dynamic loading of agents by default in order to improve integrity by default. Serviceability tools that

New candidate JEP: 435: Asynchronous Stack Trace VM API

2022-11-02 Thread Mark Reinhold
https://openjdk.org/jeps/435 Summary: Define an efficient and reliable API to collect stack traces asynchronously and include information on both Java and native stack frames. - Mark

Re: Submitted JEP: Asynchronous Stack Trace VM API

2022-11-02 Thread Mark Reinhold
Johannes -- I just now noticed that you’re not yet a Committer, so per the JEP process [1] you can author but not submit or own a JEP. Christoph, Jaroslav -- as active JDK Project Reviewers, would one of you be willing to be the owner of record for this JEP? - Mark [1] https://cr.openjdk.java.n

Re: Submitted JEP: Asynchronous Stack Trace VM API

2022-11-02 Thread Mark Reinhold
2022/11/1 1:15:13 -0700, johannes.bechber...@sap.com: > Thanks for your corrections. I only corrected one minor thing: I > removed “; in a JDK image it should be copied into the `include` > directory”, as I forgot to remove after moving the header to a > location which is auto copied. What’s impor

Re: Submitted JEP: Asynchronous Stack Trace VM API

2022-10-31 Thread Mark Reinhold
I’ve edited the text of this JEP in JBS to tighten the prose, correct terminology, and fix a few formatting issues. HTML and diffs attached for reference. Please review and make any necessary corrections, then I’ll move it to Candidate. - Mark Title: JEP TBD: Asynchronous Stack Trace VM API JEP

Re: Submitted JEP: Asynchronous Stack Trace VM API

2022-10-27 Thread Mark Reinhold
2022/10/27 13:49:52 -0700, johannes.bechber...@sap.com: >> For IP clarity, could you please also move the demo into the same > sandbox branch? You can place it under src/demo/share for now. > > What do you mean with the demo? My demo repository with the modified > async-profiler? Yes. >

Re: Submitted JEP: Asynchronous Stack Trace VM API

2022-10-27 Thread Mark Reinhold
2022/10/11 1:18:19 -0700, johannes.bechber...@sap.com: > Thanks for your comments. I incorporated them in the updated version > of the JEP and updated all related repositories that now are > implemented based on current JDK20 head and async-profiler head. The > implementation of the JEP now resides

Submitted JEP: Asynchronous Stack Trace VM API

2022-10-04 Thread Mark Reinhold
https://openjdk.org/jeps/8284289 Thanks for this submission. To start, I’ve shortened the title of the JEP to something that’s hopefully more recognizable. I won’t comment here on the technical merits of the draft, though I may do so elsewhere. For now, some editorial and procedural questions a