On Wed, 30 Oct 2024 18:12:30 GMT, Matthew Donovan wrote:
>> In this PR, I removed hard-coded security providers and replaced them with a
>> system property, test.provider.name. If the property is not specified, the
>> provider originally used in the test is used:
>>
>> Cipher c = Cipher.getIns
On Fri, 15 Nov 2024 12:04:08 GMT, Matthias Baesken wrote:
> E.g. on AIx we run into this test failure :
> error: module not found: jdk.hotspot.agent
> Unable to retrieve `@since` for Module: module: jdk.hotspot.agent
> java.lang.Exception: The `@since` checker found 1 problems
> at SinceChecker.c
On Thu, 10 Oct 2024 08:57:44 GMT, Matthias Baesken wrote:
> In symtab.c there is some coding where hcreate_r is used. We should check the
> return value of the call (previously there was some guarantee checking the
> return value but uncommented).
>
> This has been discussed in the PR of
> [J
On Wed, 9 Oct 2024 11:44:35 GMT, Matthias Baesken wrote:
>> There are a few warnings as errors occurring when building on Linux with
>> clang (clang15). Mostly these are some kind of 'unused' warnings.
>> Might be related to https://bugs.openjdk.org/browse/JDK-8339156 .
>
> Matthias Baesken has
On Mon, 8 Jul 2024 11:06:45 GMT, Matthias Baesken wrote:
> Unfortunately those 2 tests fail now on Linux Alpine (x86_64) :
> serviceability/dcmd/vm/SystemDumpMapTest.java
>
> Missing patterns in dump:
> 0x\\p{XDigit}+-0x\\p{XDigit}+ +\\d+ +[rwsxp-]+ +\\d+ +\\d+
> +(4K|8K|16K|64K|2M|16M|64M) +co
On Thu, 20 Jun 2024 11:58:23 GMT, Matthias Baesken wrote:
> The following issue has been observed when running
> serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorThreadTest (and some
> other :tier1 tests)
> on Linux with ubsan enabled binaries :
>
> test/hotspot/jtreg/serviceability/jvmti
On Tue, 4 Jun 2024 20:51:52 GMT, Cesar Soares Lucas wrote:
> Please, consider this patch to remove unused methods from the code base. To
> the best of my knowledge, these methods are only defined but never used.
>
> Here is a list with names of delete methods:
> https://gist.github.com/JohnTor
On Tue, 26 Mar 2024 14:18:34 GMT, Matthias Baesken wrote:
>> We still have quite a lot of OS400 / pase related coding in the hotspot AIX
>> codebase. But this does not work and was never supported in OpenJDK. So we
>> can remove this.
>
> Matthias Baesken has updated the pull request incrementa
On Wed, 8 Nov 2023 08:29:52 GMT, Matthias Baesken wrote:
> On AIX the test
> test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/RedefineLeakThrowable.java
> runs into this error:
>
> java.lang.RuntimeException: java.lang.OutOfMemoryError: Metaspace
> at
> jdk.compiler/com.sun.tools.javac
On Tue, 20 Jun 2023 13:23:16 GMT, Matthias Baesken wrote:
> Currently, a number of tests fail on macOS because they miss the core file
> (e.g. serviceability/sa/TestJmapCore.java).
> The reason is that configure detects on some setups that codesign does not
> work ("checking if debug mode codes
On Wed, 21 Jun 2023 07:29:03 GMT, Matthias Baesken wrote:
> 8309549: com/sun/tools/attach/warnings/DynamicLoadWarningTest.java fails on
> AIX
LGTM.
Thanks for fixing.
-
Marked as reviewed by lucy (Reviewer).
PR Review: https://git.openjdk.org/jdk21/pull/44#pullrequestreview-14899
On Wed, 12 Apr 2023 03:44:45 GMT, Amit Kumar wrote:
> Another remark: Old JDK on s390 used "os.arch = zArch_64", current one
> "os.arch = s390x". @offamitkumar: You probably want to take a look.
zArch_64 is not relevant/not used in the OpenJDK port to IBM System z. As noted
elsewhere in the PR
On Fri, 7 Apr 2023 11:21:33 GMT, Thomas Stuefe wrote:
>> Hello Thomas, that change was based on the review comment here
>> https://github.com/openjdk/jdk/pull/13357#discussion_r1159810942
>
> Okay, Lutz is the expert here. Sorry for the noise.
Just to let my voice be heard directly after being
On Tue, 28 Mar 2023 15:00:14 GMT, Matias Saavedra Silva
wrote:
>> The current structure used to store the resolution information for
>> invokedynamic, ConstantPoolCacheEntry, is difficult to interpret due to its
>> ambigious fields f1 and f2. This structure can hold information for fields,
>>
On Thu, 10 Nov 2022 09:02:02 GMT, Lutz Schmidt wrote:
> This small change fixes a warning that may pop up during runtime. May I
> please request reviews? Thank you!
This pull request has now been integrated.
Changeset: eac26f4e
Author: Lutz Schmidt
URL:
https://git.openjdk.o
On Wed, 16 Nov 2022 12:00:56 GMT, Lutz Schmidt wrote:
>> This small change fixes a warning that may pop up during runtime. May I
>> please request reviews? Thank you!
>
> Lutz Schmidt has updated the pull request incrementally with two additional
> commits si
> This small change fixes a warning that may pop up during runtime. May I
> please request reviews? Thank you!
Lutz Schmidt has updated the pull request incrementally with two additional
commits since the last revision:
- 8296709: Copyright, descriptive text, @compile directive r
On Tue, 15 Nov 2022 13:38:51 GMT, Christoph Langer wrote:
>> Lutz Schmidt has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8296709: use multiple test ids
>
> test/jdk/tools/launcher/TestXcheckJNIWarnings.ja
> This small change fixes a warning that may pop up during runtime. May I
> please request reviews? Thank you!
Lutz Schmidt has updated the pull request incrementally with one additional
commit since the last revision:
8296709: use multiple test ids
-
Changes:
- all:
On Mon, 14 Nov 2022 11:36:21 GMT, Christoph Langer wrote:
> Hm, I also don't like the code duplication...
Code duplication is gone. Just one test file with two @run tags.
-
PR: https://git.openjdk.org/jdk/pull/11083
> This small change fixes a warning that may pop up during runtime. May I
> please request reviews? Thank you!
Lutz Schmidt has updated the pull request incrementally with one additional
commit since the last revision:
8296709: use multiple @run tags instead of multiple
> This small change fixes a warning that may pop up during runtime. May I
> please request reviews? Thank you!
Lutz Schmidt has updated the pull request incrementally with two additional
commits since the last revision:
- 8296709: typo
- 8296709: Copyright year and more specific summar
On Sun, 13 Nov 2022 23:51:28 GMT, David Holmes wrote:
> Couldn't you simply add a second `doExec` statement in the existing test
> rather than copy the entire test file?
Actually, I first did it that way. And I did not like it. It's not just the
doExec, you need to duplicate the checks as well
On Fri, 11 Nov 2022 23:01:12 GMT, Christoph Langer wrote:
>> Lutz Schmidt has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8296709: fix testcase naming
>
> test/jdk/tools/launcher/TestXcheckJdwpJNIWarnings
> This small change fixes a warning that may pop up during runtime. May I
> please request reviews? Thank you!
Lutz Schmidt has updated the pull request incrementally with one additional
commit since the last revision:
8296709: fix testcase naming
-
Changes:
- all:
On Fri, 11 Nov 2022 15:33:20 GMT, Lutz Schmidt wrote:
>> This small change fixes a warning that may pop up during runtime. May I
>> please request reviews? Thank you!
>
> Lutz Schmidt has updated the pull request incrementally with one additional
> commit si
> This small change fixes a warning that may pop up during runtime. May I
> please request reviews? Thank you!
Lutz Schmidt has updated the pull request incrementally with one additional
commit since the last revision:
8296709: add testcase with active jdwp agent
-
C
On Fri, 11 Nov 2022 06:26:19 GMT, Christoph Langer wrote:
>> This small change fixes a warning that may pop up during runtime. May I
>> please request reviews? Thank you!
>
> Maybe you could also call "bin/java -Xcheck:jni
> -agentlib:jdwp=transport=dt_socket,server=y,suspend=n -version" which
On Thu, 10 Nov 2022 12:20:58 GMT, David Holmes wrote:
> Can the test be augmented to catch this case too?
David,
the test already catches both warnings. The warnings are only issued under
special circumstances. That's why everything looks fine in most cases. SAP's
commercial vm has a feature c
On Thu, 10 Nov 2022 09:02:02 GMT, Lutz Schmidt wrote:
> This small change fixes a warning that may pop up during runtime. May I
> please request reviews? Thank you!
Thanks for the review, Kevin!
I'm looking into the "exceeds capacity" warning separately. Need to find o
This small change fixes a warning that may pop up during runtime. May I please
request reviews? Thank you!
-
Commit messages:
- 8296709: WARNING: JNI call made without checking exceptions
Changes: https://git.openjdk.org/jdk/pull/11083/files
Webrev: https://webrevs.openjdk.org/?re
On Fri, 26 Aug 2022 12:04:57 GMT, Matthias Baesken wrote:
>> There seems to be a case where utf_util.c getWideString might leak memory in
>> an early return.
>
> Matthias Baesken has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Introduce UT
32 matches
Mail list logo
