On Thu, 6 Feb 2025 01:32:51 GMT, David Holmes wrote:
> This reverts commit 61465883b465a184e31e7a03e2603d29ab4815a4.
>
> JDK-8348190: Framework for tracing makefile inclusion and parsing
>
> The above issue caused problems in the Oracle closed builds and so needs to
> be backed out until that
On Mon, 25 Nov 2024 09:51:10 GMT, Kevin Walls wrote:
> > This is a change to the spec of a JDK specific API so I think should be
> > tracked by a CSR.
>
> OK yes, I was looking for opinions on whether this needed a CSR.
>
> To be clear, the interface jdk.management /
> com.sun.management.Diag
On Thu, 24 Oct 2024 12:17:41 GMT, Hannes Wallnöfer wrote:
>> Please review a doc-only change to fix the order of javadoc @param tags in
>> in various OpenJDK modules. This is the third and last PR to fix the order
>> of @param tags in OpenJDK libraries.
>>
>> We are working on a javadoc featur
On Fri, 31 May 2024 12:01:14 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this test-only change which addresses
>> https://bugs.openjdk.org/browse/JDK-8333130?
>>
>> There are a couple of tests `NativeMethodPrefixApp` and `RetransformApp`
>> under `test/jdk/java/lang/instrument/` w
On Tue, 7 May 2024 11:53:19 GMT, Pavel Rappo wrote:
> Please review this mechanical change to man pages. This PR should be
> integrated after https://github.com/openjdk/jdk/pull/18787.
Marked as reviewed by darcy (Reviewer).
> This PR is standalone as opposed to dependent because the #18787 de
On Sun, 4 Feb 2024 22:43:28 GMT, David Holmes wrote:
> This update drops the "ea" from the version string.
>
> We also propagate the following fixes from the markdown sources to the troff
> manpage file:
>
> JDK-8322478: Update java manpage for multi-file source-code launcher
> JDK-8302233: HS
On Thu, 1 Feb 2024 11:57:04 GMT, Magnus Ihse Bursie wrote:
> This is a follow-up on
> [JDK-8324053](https://bugs.openjdk.org/browse/JDK-8324053). I have run the
> bin/blessed-modifier-order.sh on the entire code base, and manually checked
> the result. I have reverted all but these trivial and
On Wed, 31 May 2023 16:40:54 GMT, Daniel D. Daugherty
wrote:
> A couple of trivial ProblemListings:
> [JDK-8309230](https://bugs.openjdk.org/browse/JDK-8309230) ProblemList
> jdk/incubator/vector/Float64VectorTests.java on aarch64
> [JDK-8309231](https://bugs.openjdk.org/browse/JDK-8309231) Pro
On Mon, 23 Jan 2023 22:59:22 GMT, David Holmes wrote:
> Please review this simple update to the manpage to set the version to 21-ea.
>
> This change also corrects a typo in javac.1 that was manually introduced by
> JDK-8300591
>
> Thanks.
Marked as reviewed by darcy (Reviewer).
-
On Wed, 18 Jan 2023 00:37:05 GMT, Joe Darcy wrote:
> Use new javadoc capabilities courtesy JDK-8200337 to have
> more-readable-in-javadoc-source links to anchors in several management types.
> Analogous change is out for review in core libs, JDK-8300133.
This pull request has
On Wed, 18 Jan 2023 12:22:01 GMT, Daniel Fuchs wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Improve link target per code review comments.
>
> src/java.management/share/c
> Use new javadoc capabilities courtesy JDK-8200337 to have
> more-readable-in-javadoc-source links to anchors in several management types.
> Analogous change is out for review in core libs, JDK-8300133.
Joe Darcy has updated the pull request incrementally with one additional commit
> Use new javadoc capabilities courtesy JDK-8200337 to have
> more-readable-in-javadoc-source links to anchors in several management types.
> Analogous change is out for review in core libs, JDK-8300133.
Joe Darcy has updated the pull request incrementally with one additional commit
On Wed, 18 Jan 2023 07:32:15 GMT, Alan Bateman wrote:
>> Use new javadoc capabilities courtesy JDK-8200337 to have
>> more-readable-in-javadoc-source links to anchors in several management
>> types. Analogous change is out for review in core libs, JDK-8300133.
>
> src/java.management/share/clas
Use new javadoc capabilities courtesy JDK-8200337 to have
more-readable-in-javadoc-source links to anchors in several management types.
Analogous change is out for review in core libs, JDK-8300133.
-
Commit messages:
- JDK-8300357: Use generalized see and link tags in java.manageme
On Wed, 11 Jan 2023 03:30:03 GMT, Archie L. Cobbs wrote:
>> This PR adds a new lint warning category `this-escape`.
>>
>> It also adds `@SuppressWarnings` annotations as needed to the JDK itself to
>> allow the JDK to continue to compile with `-Xlint:all`.
>>
>> A 'this' escape warning is gene
On Thu, 17 Nov 2022 21:48:11 GMT, Joe Darcy wrote:
> Similar to an update recently done for langtools tests, update the libraries
> regression tests to take advantage of the @enablePreview jtreg feature.
This pull request has now been integrated.
Changeset: 770ff5a8
Author: Joe Darc
> Similar to an update recently done for langtools tests, update the libraries
> regression tests to take advantage of the @enablePreview jtreg feature.
Joe Darcy has updated the pull request with a new target base due to a merge or
a rebase. The incremental webrev excludes the unr
On Thu, 1 Dec 2022 19:19:01 GMT, Erik Gahlin wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Respond to review feedback.
>
> test/jdk/jdk/jfr/threading/TestDeepVirtualStackTrace.java
> Similar to an update recently done for langtools tests, update the libraries
> regression tests to take advantage of the @enablePreview jtreg feature.
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
Respond to review fe
> Similar to an update recently done for langtools tests, update the libraries
> regression tests to take advantage of the @enablePreview jtreg feature.
Joe Darcy has updated the pull request with a new target base due to a merge or
a rebase. The incremental webrev excludes the unr
On Mon, 28 Nov 2022 19:29:08 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-434 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] - https://openjd
On Fri, 18 Nov 2022 19:06:02 GMT, Alan Bateman wrote:
>> Right; ideally when the feature becomes non-preview the test update would
>> just be removing the "@enablePreview" line. I didn't author these tests so I
>> initially left any "othervm" directives in place since they aren't
>> incorrect,
On Fri, 18 Nov 2022 08:28:22 GMT, Alan Bateman wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Respond to review feedback.
>
> test/jdk/java/lang/Thread/BuilderTest.java line 29:
>
> Similar to an update recently done for langtools tests, update the libraries
> regression tests to take advantage of the @enablePreview jtreg feature.
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
Respond to review fe
Similar to an update recently done for langtools tests, update the libraries
regression tests to take advantage of the @enablePreview jtreg feature.
-
Commit messages:
- JDK-8297215: Update libs tests to use @enablePreview
Changes: https://git.openjdk.org/jdk/pull/11222/files
Webr
On Mon, 14 Nov 2022 18:49:14 GMT, Joe Darcy wrote:
> Update the compile command in JdbLastErrorTest.java so that it doesn't need
> to be modified with each new JDK release to keep using preview features.
This pull request has now been integrated.
Changeset: 87530e66
Author: Joe
> Update the compile command in JdbLastErrorTest.java so that it doesn't need
> to be modified with each new JDK release to keep using preview features.
Joe Darcy has updated the pull request with a new target base due to a merge or
a rebase. The incremental webrev excludes th
> Update the compile command in JdbLastErrorTest.java so that it doesn't need
> to be modified with each new JDK release to keep using preview features.
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
Update.
---
On Mon, 14 Nov 2022 19:13:22 GMT, Alan Bateman wrote:
>> Is that a new jtreg feature? I've used the idiom in the updated version of
>> this file elsewhere in the JDK.
>
> https://bugs.openjdk.org/browse/CODETOOLS-7902654
> I only became aware of it a few months ago.
Thanks @AlanBateman; I wasn'
> Update the compile command in JdbLastErrorTest.java so that it doesn't need
> to be modified with each new JDK release to keep using preview features.
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
Respond to revi
On Mon, 14 Nov 2022 19:07:42 GMT, Alan Bateman wrote:
>> Update the compile command in JdbLastErrorTest.java so that it doesn't need
>> to be modified with each new JDK release to keep using preview features.
>
> test/jdk/com/sun/jdi/JdbLastErrorTest.java line 31:
>
>> 29: * @library /test/lib
Update the compile command in JdbLastErrorTest.java so that it doesn't need to
be modified with each new JDK release to keep using preview features.
-
Commit messages:
- JDK-8296913: Correct enable preview idiom in JdbLastErrorTest.java
Changes: https://git.openjdk.org/jdk/pull/111
On Fri, 30 Sep 2022 00:33:57 GMT, Joe Darcy wrote:
> With the domain change from openjdk.java.net to openjdk.org, references to
> URLs in the sources should be updated.
>
> Updates were made using a shell script. I"ll run a copyright updater before
> any push.
This pull
> With the domain change from openjdk.java.net to openjdk.org, references to
> URLs in the sources should be updated.
>
> Updates were made using a shell script. I"ll run a copyright updater before
> any push.
Joe Darcy has updated the pull request with a new target base
On Mon, 3 Oct 2022 20:04:38 GMT, Phil Race wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update make directory.
>
> src/jdk.accessibility/windows/native/include/bridge/AccessBrid
> With the domain change from openjdk.java.net to openjdk.org, references to
> URLs in the sources should be updated.
>
> Updates were made using a shell script. I"ll run a copyright updater before
> any push.
Joe Darcy has updated the pull request with a new target base
On Mon, 3 Oct 2022 17:17:39 GMT, Joe Darcy wrote:
> > Also, FWIW, there are 100+ hits in `test` as well. But that is so many it
> > might warrant a separate PR..?
>
> Filed a few follow-up bugs:
>
> JDK-8294724: Update openjdk.java.net => openjdk.org in tests (umbre
> With the domain change from openjdk.java.net to openjdk.org, references to
> URLs in the sources should be updated.
>
> Updates were made using a shell script. I"ll run a copyright updater before
> any push.
Joe Darcy has updated the pull request incrementally with o
> With the domain change from openjdk.java.net to openjdk.org, references to
> URLs in the sources should be updated.
>
> Updates were made using a shell script. I"ll run a copyright updater before
> any push.
Joe Darcy has updated the pull request incrementally with o
On Fri, 30 Sep 2022 20:25:28 GMT, Joe Darcy wrote:
> Also, FWIW, there are 100+ hits in `test` as well. But that is so many it
> might warrant a separate PR..?
Filed a few follow-up bugs:
JDK-8294724: Update openjdk.java.net => openjdk.org in tests (umbrella)
JDK-829472
On Fri, 30 Sep 2022 17:38:54 GMT, Phil Race wrote:
> This is correct. AccessBridge.h is published with the include/header files of
> the JDK and anyone reading it there can't exactly make use of "../"
Update to persistent git links.
-
PR: https://git.openjdk.org/jdk/pull/10501
On Fri, 30 Sep 2022 13:59:12 GMT, Magnus Ihse Bursie wrote:
> Also, FWIW, there are 100+ hits in `test` as well. But that is so many it
> might warrant a separate PR..?
Yes; I think it is sufficient to update src and doc with this PR.
-
PR: https://git.openjdk.org/jdk/pull/10501
> With the domain change from openjdk.java.net to openjdk.org, references to
> URLs in the sources should be updated.
>
> Updates were made using a shell script. I"ll run a copyright updater before
> any push.
Joe Darcy has updated the pull request with a new target base
On Fri, 30 Sep 2022 00:48:02 GMT, Mikael Vidstedt wrote:
> Switch to https where needed/applicable while at it?
Good idea; might as well do the update in a single changeset.
-
PR: https://git.openjdk.org/jdk/pull/10501
> With the domain change from openjdk.java.net to openjdk.org, references to
> URLs in the sources should be updated.
>
> Updates were made using a shell script. I"ll run a copyright updater before
> any push.
Joe Darcy has updated the pull request incrementally with o
> With the domain change from openjdk.java.net to openjdk.org, references to
> URLs in the sources should be updated.
>
> Updates were made using a shell script. I"ll run a copyright updater before
> any push.
Joe Darcy has updated the pull request incrementally with o
> With the domain change from openjdk.java.net to openjdk.org, references to
> URLs in the sources should be updated.
>
> Updates were made using a shell script. I"ll run a copyright updater before
> any push.
Joe Darcy has updated the pull request incrementally with two
With the domain change from openjdk.java.net to openjdk.org, references to URLs
in the sources should be updated.
Updates were made using a shell script. I"ll run a copyright updater before any
push.
-
Commit messages:
- JDK-8294618: Update openjdk.java.net => openjdk.org
Changes
On Sat, 17 Sep 2022 08:41:19 GMT, Alan Bateman wrote:
>> Degrade Thread.stop to throw UOE unconditionally, deprecate ThreadDeath for
>> removal, and remove the remaining special handling of ThreadDeath from the
>> JDK.
>>
>> Thread.stop is inherently unsafe and has been deprecated since JDK 1.
On Wed, 6 Jul 2022 20:45:22 GMT, Daniel D. Daugherty wrote:
> A trivial fix to ProblemList
> jdk/jfr/event/runtime/TestActiveSettingEvent.java.
Marked as reviewed by darcy (Reviewer).
-
PR: https://git.openjdk.org/jdk19/pull/117
51 matches
Mail list logo
