On Thu, 31 Oct 2024 20:05:18 GMT, Patricio Chilano Mateo
wrote:
>> src/hotspot/share/runtime/continuation.hpp line 66:
>>
>>> 64:
>>> 65: enum preempt_kind {
>>> 66: freeze_on_monitorenter = 1,
>>
>> Is there a reason why the first enumerator doesn't start at zero?
>
> There was one val
On Sat, 2 Nov 2024 02:41:44 GMT, Fei Yang wrote:
>> Changed.
>
> Note that `frame::sender_sp_offset` is 0 instead of 2 on linux-riscv64, which
> is different from aarch64 or x86-64. So I think we should revert this change:
> https://github.com/openjdk/jdk/pull/21565/commits/12213a70c1cf0639555f
On Fri, 25 Oct 2024 13:11:38 GMT, Patricio Chilano Mateo
wrote:
>> src/hotspot/cpu/aarch64/sharedRuntime_aarch64.cpp line 2032:
>>
>>> 2030: // Force freeze slow path in case we try to preempt. We will pin
>>> the
>>> 2031: // vthread to the carrier (see
>>> FreezeBase::recurse_freeze
On Thu, 17 Oct 2024 14:28:30 GMT, Patricio Chilano Mateo
wrote:
> This is the implementation of JEP 491: Synchronize Virtual Threads without
> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
> further details.
>
> In order to make the code review easier the changes hav
On Sat, 2 Nov 2024 02:41:44 GMT, Fei Yang wrote:
>> Changed.
>
> Note that `frame::sender_sp_offset` is 0 instead of 2 on linux-riscv64, which
> is different from aarch64 or x86-64. So I think we should revert this change:
> https://github.com/openjdk/jdk/pull/21565/commits/12213a70c1cf0639555f
On Fri, 1 Nov 2024 19:37:14 GMT, Patricio Chilano Mateo
wrote:
>> This is the implementation of JEP 491: Synchronize Virtual Threads without
>> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
>> further details.
>>
>> In order to make the code review easier the changes
On Thu, 31 Oct 2024 20:05:18 GMT, Patricio Chilano Mateo
wrote:
>> src/hotspot/share/runtime/continuation.hpp line 66:
>>
>>> 64:
>>> 65: enum preempt_kind {
>>> 66: freeze_on_monitorenter = 1,
>>
>> Is there a reason why the first enumerator doesn't start at zero?
>
> There was one val
On Wed, 30 Oct 2024 00:44:14 GMT, Patricio Chilano Mateo
wrote:
>> This is the implementation of JEP 491: Synchronize Virtual Threads without
>> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
>> further details.
>>
>> In order to make the code review easier the change
On Thu, 24 Oct 2024 21:08:26 GMT, Patricio Chilano Mateo
wrote:
>> This is the implementation of JEP 491: Synchronize Virtual Threads without
>> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
>> further details.
>>
>> In order to make the code review easier the change
On Fri, 25 Oct 2024 13:11:38 GMT, Patricio Chilano Mateo
wrote:
>> src/hotspot/cpu/aarch64/sharedRuntime_aarch64.cpp line 2032:
>>
>>> 2030: // Force freeze slow path in case we try to preempt. We will pin
>>> the
>>> 2031: // vthread to the carrier (see
>>> FreezeBase::recurse_freeze
On Tue, 19 Sep 2023 09:00:01 GMT, Fredrik Bredberg
wrote:
> Relativize initial_sp in interpreter frames.
>
> By changing the "initial_sp" (AKA "monitor_block_top" or "monitors" on
> PowerPC) member in interpreter frames from being an absolute address
On Wed, 27 Sep 2023 09:07:23 GMT, Fredrik Bredberg
wrote:
>> Relativize initial_sp in interpreter frames.
>>
>> By changing the "initial_sp" (AKA "monitor_block_top" or "monitors" on
>> PowerPC) member in interpreter frames from being an a
other subtasks to JDK-8289296.
>
> Tested tier1-tier7 on supported platforms. The rest was sanity tested using
> Qemu.
Fredrik Bredberg has updated the pull request incrementally with one additional
commit since the last revision:
Removed whitespace (RISC-V only).
-
Chan
On Thu, 21 Sep 2023 12:45:07 GMT, Fei Yang wrote:
>> Hi, I have arranged tier1-3 test on linux-riscv64 platform. Thanks for
>> adding handling for riscv.
>
>> Hi, I have arranged tier1-3 test on linux-riscv64 platform. Thanks for
>> adding handling for riscv.
>
> Tier1-3 test is clean. The ris
On Wed, 20 Sep 2023 08:46:39 GMT, Fei Yang wrote:
>> Fredrik Bredberg has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Updated after review.
>
> src/hotspot/cpu/riscv/interp_masm_riscv.cpp line 704:
other subtasks to JDK-8289296.
>
> Tested tier1-tier7 on supported platforms. The rest was sanity tested using
> Qemu.
Fredrik Bredberg has updated the pull request incrementally with one additional
commit since the last revision:
Updated after review.
-
Changes:
- a
On Tue, 19 Sep 2023 09:00:01 GMT, Fredrik Bredberg
wrote:
> Relativize initial_sp in interpreter frames.
>
> By changing the "initial_sp" (AKA "monitor_block_top" or "monitors" on
> PowerPC) member in interpreter frames from being an absolute address
Relativize initial_sp in interpreter frames.
By changing the "initial_sp" (AKA "monitor_block_top" or "monitors" on PowerPC)
member in interpreter frames from being an absolute address into an offset that
is relative to the frame pointer, we don't need to change the value as we
freeze and thaw
On Fri, 14 Apr 2023 13:27:37 GMT, Fredrik Bredberg wrote:
> Added the missing java.lang.Thread.beforeSleep and java.lang.afterSleep to
> expectedSystemTrace.
> Tested on my local machine.
This pull request has now been integrated.
Changeset: a31a11f4
Author: Fredrik Bredberg
On Wed, 19 Apr 2023 11:30:42 GMT, Fredrik Bredberg wrote:
>> Added the missing java.lang.Thread.beforeSleep and java.lang.afterSleep to
>> expectedSystemTrace.
>> Tested on my local machine.
>
> Fredrik Bredberg has updated the pull request incrementally with two
> a
> Added the missing java.lang.Thread.beforeSleep and java.lang.afterSleep to
> expectedSystemTrace.
> Tested on my local machine.
Fredrik Bredberg has updated the pull request incrementally with two additional
commits since the last revision:
- Updated after review
On Tue, 18 Apr 2023 20:20:09 GMT, Daniel D. Daugherty
wrote:
>> Added the missing java.lang.Thread.beforeSleep and java.lang.afterSleep to
>> expectedSystemTrace.
>> Tested on my local machine.
>
> We currently have a total of 20 sightings of this failure in both CI and Adhoc
> jobs and it's ha
Added the missing java.lang.Thread.beforeSleep and java.lang.afterSleep to
expectedSystemTrace.
Tested on my local machine.
-
Commit messages:
- 8306006: strace001.java fails due to unknown methods on stack
Changes: https://git.openjdk.org/jdk/pull/13476/files
Webrev: https://webr
On Mon, 9 Jan 2023 10:30:06 GMT, Fredrik Bredberg wrote:
> Implementation of relativized locals in interpreter frames for x86. x64, arm,
> aarch64, ppc64le and riscv.
> Not relativized locals on zero and s390 but done some changes to cope with
> the changed generic code.
> Tes
On Tue, 17 Jan 2023 13:33:34 GMT, Martin Doerr wrote:
>>> Works on PPC64. Thanks! Tests have passed on other platforms as well.
>>
>> Does "other platforms" include S390?
>
>> > Works on PPC64. Thanks! Tests have passed on other platforms as well.
>>
>> Does "other platforms" include S390?
>
>
ty tested using
> Qemu, except s390, which was only tested by GitHub Actions.
Fredrik Bredberg has updated the pull request incrementally with one additional
commit since the last revision:
Updated after review.
-
Changes:
- all: https://git.openjdk.org/jdk/pull/11902/fi
On Wed, 18 Jan 2023 05:07:38 GMT, Martin Doerr wrote:
>> My intention was to show how the contents of R18_locals (the absolute
>> address to locals) can be recreated by using R12_scratch2 as an index from
>> the frame pointer. Before we stored R18_locals in the stackframe, now we
>> store R12_
On Tue, 17 Jan 2023 17:34:53 GMT, Andrew Haley wrote:
> > Implementation of relativized locals in interpreter frames for x86. x64,
> > arm, aarch64, ppc64le and riscv. Not relativized locals on zero and s390
> > but done some changes to cope with the changed generic code. Tested
> > tier1-tier
On Tue, 17 Jan 2023 13:32:47 GMT, Martin Doerr wrote:
>> Fredrik Bredberg has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contai
On Tue, 17 Jan 2023 08:35:45 GMT, Fredrik Bredberg wrote:
>> Implementation of relativized locals in interpreter frames for x86. x64,
>> arm, aarch64, ppc64le and riscv.
>> Not relativized locals on zero and s390 but done some changes to cope with
>> the changed gener
On Tue, 10 Jan 2023 15:14:34 GMT, Martin Doerr wrote:
> Works on PPC64. Thanks! Tests have passed on other platforms as well.
Does "other platforms" include S390?
-
PR: https://git.openjdk.org/jdk/pull/11902
ty tested using
> Qemu, except s390, which was only tested by GitHub Actions.
Fredrik Bredberg has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by the merge/rebase. The pull request contains five a
On Fri, 13 Jan 2023 16:47:59 GMT, Coleen Phillimore wrote:
>> Fredrik Bredberg has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Updated some copyright dates.
>
> src/hotspot/cpu/aarch64/continuationFreezeTh
ty tested using
> Qemu, except s390, which was only tested by GitHub Actions.
Fredrik Bredberg has updated the pull request incrementally with one additional
commit since the last revision:
Added references to JDK-8300197
-
Changes:
- all: https://git.openjdk.org/jdk/pull/1
ty tested using
> Qemu, except s390, which was only tested by GitHub Actions.
Fredrik Bredberg has updated the pull request incrementally with one additional
commit since the last revision:
Updated some copyright dates.
-
Changes:
- all: https://git.openjdk.org/jdk/pull/11902/fi
On Tue, 10 Jan 2023 14:38:32 GMT, Axel Boldt-Christmas
wrote:
>> Implementation of relativized locals in interpreter frames for x86. x64,
>> arm, aarch64, ppc64le and riscv.
>> Not relativized locals on zero and s390 but done some changes to cope with
>> the changed generic code.
>> Tested tie
Implementation of relativized locals in interpreter frames for x86. x64,
aarch64, ppc64le, riscv.
Not relativized zero and s390 but done some changes to cope with the changed
generic code.
Tested tier1-tier8 on supported platforms. The rest was sanity tested using
Qemu.
-
Commit me
37 matches
Mail list logo
