On Thu, 13 Mar 2025 22:46:54 GMT, Jiangli Zhou wrote:
>> Please review the fix in following tests to not check for shared libraries
>> when running on static JDK:
>>
>> test/hotspot/jtreg/serviceability/dcmd/vm/DynLibsTest.java
>> test/hotspot/jtreg/serviceability/dcmd/vm/SystemDumpMapTest.java
On Thu, 13 Mar 2025 19:35:27 GMT, Thomas Stuefe wrote:
>> Jiangli Zhou has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Address @tstuefe review:
>> - Renamed shouldMatchUnconditionally__libjvm to
>> shouldMatch__libjvm in SystemMapTest
> Please review the fix in following tests to not check for shared libraries
> when running on static JDK:
>
> test/hotspot/jtreg/serviceability/dcmd/vm/DynLibsTest.java
> test/hotspot/jtreg/serviceability/dcmd/vm/SystemDumpMapTest.java
> test/hotspot/jtreg/serviceability/dcmd/vm/SystemMapTest.ja
On Sat, 22 Feb 2025 03:31:53 GMT, Jiangli Zhou wrote:
> Please review the fix in following tests to not check for shared libraries
> when running on static JDK:
>
> test/hotspot/jtreg/serviceability/dcmd/vm/DynLibsTest.java
> test/hotspot/jtreg/serviceability/dcmd/vm/SystemDumpMapTest.java
> te
On Tue, 11 Mar 2025 01:39:55 GMT, Alex Menkov wrote:
>> The fix implements streaming output support for attach protocol.
>> See JBS issue for evaluation, summary of the changes in the 1st comment.
>> Testing: tier1..4,hs-tier5-svc
>
> Alex Menkov has updated the pull request incrementally with on
The nsk_jvmti_setFailStatus() sometimes is called after test check results. In
these cases the warning logs are generated and hide the real failure reasons.
Also, I think it is a error-prone way to set and check error, since check might
be just forgotten. Also, the test execution after failure m
On Wed, 12 Mar 2025 12:45:48 GMT, Matthias Baesken wrote:
>> On Linux there are some special settings for LIBMANAGEMENT_OPTIMIZATION that
>> are most likely not needed any more and could be removed.
>
> Matthias Baesken has updated the pull request incrementally with one
> additional commit sin
On Tue, 11 Mar 2025 19:22:34 GMT, snake66 wrote:
> Allows for future support for platforms that require different flags for
> libiconv support.
>
> Sponsored-by: The FreeBSD Foundation
This pull request has now been integrated.
Changeset: 771e160d
Author:Harald Eilertsen
URL:
http
On Tue, 4 Mar 2025 19:05:57 GMT, Alan Bateman wrote:
> I'm not familiar with details of the output from the System.map command but
> the change looks reasonable, hopefully @tstuefe or someone familar with this
> command and these tests can review.
Thanks, @AlanBateman!
Could anyone help revie
On Wed, 12 Mar 2025 12:45:48 GMT, Matthias Baesken wrote:
>> On Linux there are some special settings for LIBMANAGEMENT_OPTIMIZATION that
>> are most likely not needed any more and could be removed.
>
> Matthias Baesken has updated the pull request incrementally with one
> additional commit sin
On Mon, 11 Nov 2024 09:51:35 GMT, Julian Waters wrote:
>> After 8339120, gcc began catching many different instances of unused code in
>> the Windows specific codebase. Some of these seem to be bugs. I've taken the
>> effort to mark out all the relevant globals and locals that trigger the
>> u
On Thu, 13 Mar 2025 11:39:14 GMT, snake66 wrote:
>> Allows for future support for platforms that require different flags for
>> libiconv support.
>>
>> Sponsored-by: The FreeBSD Foundation
>
> snake66 has updated the pull request incrementally with one additional commit
> since the last revisi
On Thu, 13 Mar 2025 13:28:32 GMT, Magnus Ihse Bursie wrote:
>> snake66 has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Unbreak libjdwp build
>
> Then I think the current solution is fine. Even if OpenBSD is not the primary
> goal of you
On Thu, 13 Mar 2025 11:39:14 GMT, snake66 wrote:
>> Allows for future support for platforms that require different flags for
>> libiconv support.
>>
>> Sponsored-by: The FreeBSD Foundation
>
> snake66 has updated the pull request incrementally with one additional commit
> since the last revisi
On Mon, 10 Mar 2025 15:38:45 GMT, Matthias Baesken wrote:
> On Linux there are some special settings for LIBMANAGEMENT_OPTIMIZATION that
> are most likely not needed any more and could be removed.
This pull request has now been integrated.
Changeset: c3db6671
Author:Matthias Baesken
URL:
On Wed, 12 Mar 2025 12:45:48 GMT, Matthias Baesken wrote:
>> On Linux there are some special settings for LIBMANAGEMENT_OPTIMIZATION that
>> are most likely not needed any more and could be removed.
>
> Matthias Baesken has updated the pull request incrementally with one
> additional commit sin
> Allows for future support for platforms that require different flags for
> libiconv support.
>
> Sponsored-by: The FreeBSD Foundation
snake66 has updated the pull request incrementally with one additional commit
since the last revision:
Unbreak libjdwp build
-
Changes:
- al
On Wed, 12 Mar 2025 16:56:32 GMT, Magnus Ihse Bursie wrote:
> Also, to double check, are the new variables `ICONV_CFLAGS` and
> `ICONV_LDFLAGS` going to be non-empty on BSD?
Yes, the current BSD port has the following in `libraries.m4`:
if test "x$OPENJDK_TARGET_OS" = "xbsd"; then
if te
On Wed, 12 Mar 2025 12:45:48 GMT, Matthias Baesken wrote:
>> On Linux there are some special settings for LIBMANAGEMENT_OPTIMIZATION that
>> are most likely not needed any more and could be removed.
>
> Matthias Baesken has updated the pull request incrementally with one
> additional commit sin
On Wed, 12 Mar 2025 12:45:48 GMT, Matthias Baesken wrote:
>> On Linux there are some special settings for LIBMANAGEMENT_OPTIMIZATION that
>> are most likely not needed any more and could be removed.
>
> Matthias Baesken has updated the pull request incrementally with one
> additional commit sin
20 matches
Mail list logo
