Re: RFR: 8346717: serviceability/dcmd/vm/SystemDumpMapTest.java failing on Windows with "Stack base not yet set for thread id" [v5]

2025-01-09 Thread David Holmes
On Thu, 9 Jan 2025 20:48:21 GMT, Simon Tooke wrote: >> This test fixes an issue with incomplete Windows threads not yet having a >> stack. A test for a null stack_base is added to guard against the potential >> null dereference. An additional test using ZGC is added to the jtreg >> SystemMap

Re: RFR: 8346123: [REDO] NMT should not use ThreadCritical [v12]

2025-01-09 Thread David Holmes
On Thu, 9 Jan 2025 16:34:08 GMT, Robert Toyonaga wrote: > Say **thread_A** is the only thread started. It does not acquire the lock > (since single threaded) and enters the critical section. While **thread_A** > is in the critical section, **thread_B** is started, Hold on there - who is starti

Re: RFR: 8346727: JvmtiVTMSTransitionDisabler deadlock [v3]

2025-01-09 Thread Serguei Spitsyn
> This is a fix of one more deadlock issue related to `interruptLock` critical > sections. When the `interruptLock` is hold by the target virtual thread it is > unsafe to suspend or post JVMTI events. This update is to ignore the JVMTI > events when the `interruptLock` is hold. It is additionall

Re: RFR: 8346727: JvmtiVTMSTransitionDisabler deadlock [v2]

2025-01-09 Thread Serguei Spitsyn
> This is a fix of one more deadlock issue related to `interruptLock` critical > sections. When the `interruptLock` is hold by the target virtual thread it is > unsafe to suspend or post JVMTI events. This update is to ignore the JVMTI > events when the `interruptLock` is hold. It is additionall

Re: RFR: 8346727: JvmtiVTMSTransitionDisabler deadlock

2025-01-09 Thread Serguei Spitsyn
On Thu, 9 Jan 2025 21:01:19 GMT, Leonid Mesnik wrote: >> This is a fix of one more deadlock issue related to `interruptLock` critical >> sections. When the `interruptLock` is hold by the target virtual thread it >> is unsafe to suspend or post JVMTI events. This update is to ignore the >> JVMT

Re: RFR: 8346727: JvmtiVTMSTransitionDisabler deadlock

2025-01-09 Thread Serguei Spitsyn
On Thu, 9 Jan 2025 16:28:00 GMT, Chris Plummer wrote: >> This is a fix of one more deadlock issue related to `interruptLock` critical >> sections. When the `interruptLock` is hold by the target virtual thread it >> is unsafe to suspend or post JVMTI events. This update is to ignore the >> JVMT

Re: RFR: 8347345: Remove redundant test policy file from ModelMBeanInfoSupport directory

2025-01-09 Thread Serguei Spitsyn
On Thu, 9 Jan 2025 12:24:59 GMT, Kevin Walls wrote: > A redundant policy file exists, it is unused and must have been missed during: > 8338411: Implement JEP 486: Permanently Disable the Security Manager > > Test in test/jdk/javax/management/modelmbean/ModelMBeanInfoSupport still > passes after

Re: RFR: 8346990: Remove INTX_FORMAT and UINTX_FORMAT macros [v5]

2025-01-09 Thread Kim Barrett
On Thu, 9 Jan 2025 21:47:47 GMT, Matias Saavedra Silva wrote: >> Coleen Phillimore has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Restore copyright and macro. > > src/hotspot/share/runtime/objectMonitor.cpp line 2500: > >> 2498: //

Re: RFR: 8346990: Remove INTX_FORMAT and UINTX_FORMAT macros [v5]

2025-01-09 Thread Matias Saavedra Silva
On Tue, 7 Jan 2025 12:51:33 GMT, Coleen Phillimore wrote: >> There are a lot of format modifiers that are noisy and unnecessary in the >> code. This change removes the INTX variants. It's not that disruptive even >> for backporting because %z modifier has been available for a long time so >>

Re: RFR: 8346717: serviceability/dcmd/vm/SystemDumpMapTest.java failing on Windows with "Stack base not yet set for thread id" [v5]

2025-01-09 Thread Leonid Mesnik
On Thu, 9 Jan 2025 20:48:21 GMT, Simon Tooke wrote: >> This test fixes an issue with incomplete Windows threads not yet having a >> stack. A test for a null stack_base is added to guard against the potential >> null dereference. An additional test using ZGC is added to the jtreg >> SystemMap

Re: RFR: 8347267: [macOS]: UnixOperatingSystem.c:67:40: runtime error: division by zero

2025-01-09 Thread Chris Plummer
On Thu, 9 Jan 2025 15:13:01 GMT, Matthias Baesken wrote: > When running ubsan-enabled binaries on macOS aarch64, in test > javax/management/MBeanServer/OldMBeanServerTest.java > the following division by zero is shown : > src/jdk.management/macosx/native/libmanagement_ext/UnixOperatingSystem.c:67

Re: RFR: 8346717: serviceability/dcmd/vm/SystemDumpMapTest.java failing on Windows with "Stack base not yet set for thread id" [v4]

2025-01-09 Thread Simon Tooke
On Thu, 9 Jan 2025 03:05:47 GMT, David Holmes wrote: >> Simon Tooke has updated the pull request incrementally with one additional >> commit since the last revision: >> >> test SystemMap with and without ZGC > > test/hotspot/jtreg/serviceability/dcmd/vm/SystemMapTest.java line 39: > >> 37:

Re: RFR: 8346727: JvmtiVTMSTransitionDisabler deadlock

2025-01-09 Thread Leonid Mesnik
On Thu, 9 Jan 2025 05:03:33 GMT, Serguei Spitsyn wrote: > This is a fix of one more deadlock issue related to `interruptLock` critical > sections. When the `interruptLock` is hold by the target virtual thread it is > unsafe to suspend or post JVMTI events. This update is to ignore the JVMTI >

Re: RFR: 8346717: serviceability/dcmd/vm/SystemDumpMapTest.java failing on Windows with "Stack base not yet set for thread id" [v5]

2025-01-09 Thread Simon Tooke
> This test fixes an issue with incomplete Windows threads not yet having a > stack. A test for a null stack_base is added to guard against the potential > null dereference. An additional test using ZGC is added to the jtreg > SystemMapTest. Simon Tooke has updated the pull request incrementa

Re: RFR: 8346990: Remove INTX_FORMAT and UINTX_FORMAT macros [v5]

2025-01-09 Thread Coleen Phillimore
On Tue, 7 Jan 2025 12:51:33 GMT, Coleen Phillimore wrote: >> There are a lot of format modifiers that are noisy and unnecessary in the >> code. This change removes the INTX variants. It's not that disruptive even >> for backporting because %z modifier has been available for a long time so >>

Re: RFR: 8347267: [macOS]: UnixOperatingSystem.c:67:40: runtime error: division by zero

2025-01-09 Thread Kevin Walls
On Thu, 9 Jan 2025 15:13:01 GMT, Matthias Baesken wrote: > When running ubsan-enabled binaries on macOS aarch64, in test > javax/management/MBeanServer/OldMBeanServerTest.java > the following division by zero is shown : > src/jdk.management/macosx/native/libmanagement_ext/UnixOperatingSystem.c:67

Re: RFR: 8346990: Remove INTX_FORMAT and UINTX_FORMAT macros [v5]

2025-01-09 Thread Matias Saavedra Silva
On Tue, 7 Jan 2025 12:51:33 GMT, Coleen Phillimore wrote: >> There are a lot of format modifiers that are noisy and unnecessary in the >> code. This change removes the INTX variants. It's not that disruptive even >> for backporting because %z modifier has been available for a long time so >>

Re: RFR: 8347345: Remove redundant test policy file from ModelMBeanInfoSupport directory

2025-01-09 Thread Roger Riggs
On Thu, 9 Jan 2025 12:24:59 GMT, Kevin Walls wrote: > A redundant policy file exists, it is unused and must have been missed during: > 8338411: Implement JEP 486: Permanently Disable the Security Manager > > Test in test/jdk/javax/management/modelmbean/ModelMBeanInfoSupport still > passes after

Re: RFR: 8346123: [REDO] NMT should not use ThreadCritical [v12]

2025-01-09 Thread Robert Toyonaga
On Tue, 7 Jan 2025 04:40:36 GMT, David Holmes wrote: >>> In case my comment within the existing conversations gets missed I will >>> re-state that I don't think you need any new "is bootstrapping" logic >>> because you can just use `Threads::number_of_threads() > 0` to tell you if >>> you need

Re: [jdk24] RFR: 8310340: assert(_thread->is_interp_only_mode() || stub_caller) failed: expected a stub-caller

2025-01-09 Thread Serguei Spitsyn
On Thu, 9 Jan 2025 14:18:52 GMT, Patricio Chilano Mateo wrote: > Hi all, > > This pull request contains a backport of commit > [ea495377](https://github.com/openjdk/jdk/commit/ea49537726db6530f0ddcc04d9938df3d6d18250) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The

Re: RFR: 8346727: JvmtiVTMSTransitionDisabler deadlock

2025-01-09 Thread Chris Plummer
On Thu, 9 Jan 2025 05:03:33 GMT, Serguei Spitsyn wrote: > This is a fix of one more deadlock issue related to `interruptLock` critical > sections. When the `interruptLock` is hold by the target virtual thread it is > unsafe to suspend or post JVMTI events. This update is to ignore the JVMTI >

RFR: 8347267: [macOS]: UnixOperatingSystem.c:67:40: runtime error: division by zero

2025-01-09 Thread Matthias Baesken
When running ubsan-enabled binaries on macOS aarch64, in test javax/management/MBeanServer/OldMBeanServerTest.java the following division by zero is shown : src/jdk.management/macosx/native/libmanagement_ext/UnixOperatingSystem.c:67:40: runtime error: division by zero UndefinedBehaviorSanitizer:DE

[jdk24] RFR: 8310340: assert(_thread->is_interp_only_mode() || stub_caller) failed: expected a stub-caller

2025-01-09 Thread Patricio Chilano Mateo
Hi all, This pull request contains a backport of commit [ea495377](https://github.com/openjdk/jdk/commit/ea49537726db6530f0ddcc04d9938df3d6d18250) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Patricio Chilano Mateo on 8 Jan 2025 an

Re: RFR: 8346123: [REDO] NMT should not use ThreadCritical [v15]

2025-01-09 Thread Robert Toyonaga
> This is a redo of [JDK-8304824](https://bugs.openjdk.org/browse/JDK-8304824) > which was backed out by > [JDK-8343726](https://bugs.openjdk.org/browse/JDK-8343726) due to problems > documented in [JDK-8343244](https://bugs.openjdk.org/browse/JDK-8343244). > > The problem was that `NmtVirtualM

Re: RFR: 8346123: [REDO] NMT should not use ThreadCritical [v14]

2025-01-09 Thread Robert Toyonaga
> This is a redo of [JDK-8304824](https://bugs.openjdk.org/browse/JDK-8304824) > which was backed out by > [JDK-8343726](https://bugs.openjdk.org/browse/JDK-8343726) due to problems > documented in [JDK-8343244](https://bugs.openjdk.org/browse/JDK-8343244). > > The problem was that `NmtVirtualM

Re: RFR: 8346990: Remove INTX_FORMAT and UINTX_FORMAT macros [v2]

2025-01-09 Thread Coleen Phillimore
On Tue, 7 Jan 2025 08:32:27 GMT, Kim Barrett wrote: >> This is a relic and not the legal copyright that got updated since nobody >> noticed. Until you did. Removed. > > Not sure we're allowed to remove a copyright statement, even if not in the > usual place. put copyright back.

RFR: 8347345: Remove redundant test policy file from ModelMBeanInfoSupport directory

2025-01-09 Thread Kevin Walls
A redundant policy file exists, it is unused and must have been missed during: 8338411: Implement JEP 486: Permanently Disable the Security Manager Test in test/jdk/javax/management/modelmbean/ModelMBeanInfoSupport still passes after this change. - Commit messages: - remove old pol

Integrated: 8346460: NotifyFramePop should return JVMTI_ERROR_DUPLICATE

2025-01-09 Thread Serguei Spitsyn
On Tue, 17 Dec 2024 21:01:51 GMT, Serguei Spitsyn wrote: > The JVMTI NotifyFramePop should return JVMTI_ERROR_DUPLICATE in a case the > specified FramePop event was already requested. This makes it consistent with > the SetBreakpoint which returns the JVMTI_ERROR_DUPLICATE on an attempt to > a

Integrated: 8347083: Incomplete logging in nsk/jvmti/ResourceExhausted/resexhausted00* tests

2025-01-09 Thread Ramkumar Sunderbabu
On Tue, 7 Jan 2025 07:58:18 GMT, Ramkumar Sunderbabu wrote: > Trivial logging message change. This pull request has now been integrated. Changeset: 33f9be8d Author:Ramkumar Sunderbabu Committer: David Holmes URL: https://git.openjdk.org/jdk/commit/33f9be8de730e664e335e368487323973