On Mon, 23 Dec 2024 22:16:01 GMT, Phil Race wrote:
>> I was also wondering how this was tested.
>
> FYI, the way to test this is ..
> cd test/jdk
> jtreg sanity/client/SwingSet/src/TableDemoTest.java
>
> I tried converting all ^M to \n in this file another repo and comparing with
> your patch b
On Mon, 23 Dec 2024 17:11:14 GMT, Justin Lu wrote:
>> Qizheng Xing has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - Update `hotspot-unit-tests.md` and HTML (using Pandoc 2.19.2).
>> - Do not touch files in test.
>> - Do not touch up
On Mon, 23 Dec 2024 19:13:09 GMT, Kim Barrett wrote:
>> Qizheng Xing has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - Update `hotspot-unit-tests.md` and HTML (using Pandoc 2.19.2).
>> - Do not touch files in test.
>> - Do not touch
On Mon, 23 Dec 2024 14:00:54 GMT, Erik Joelsson wrote:
>> Qizheng Xing has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - Update `hotspot-unit-tests.md` and HTML (using Pandoc 2.19.2).
>> - Do not touch files in test.
>> - Do not touc
> This patch fixes unmatched brackets in some source files.
Qizheng Xing has updated the pull request incrementally with three additional
commits since the last revision:
- Update `hotspot-unit-tests.md` and HTML (using Pandoc 2.19.2).
- Do not touch files in test.
- Do not touch upstream dat
On Mon, 23 Dec 2024 18:57:39 GMT, Kim Barrett wrote:
>> Qizheng Xing has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - Update `hotspot-unit-tests.md` and HTML (using Pandoc 2.19.2).
>> - Do not touch files in test.
>> - Do not touch
On Mon, 23 Dec 2024 20:29:09 GMT, Phil Race wrote:
>> test/jdk/sanity/client/lib/SwingSet3/src/com/sun/swingset3/demos/table/resources/oscars.xml
>> line 2:
>>
>>> 1:
>>> 2: http://www.fatdog.com/oscar-results";
>>
>> Does this change affect the behavior of the associated test(s)?
>
> I was a
On Mon, 23 Dec 2024 19:30:56 GMT, Kim Barrett wrote:
>> This patch fixes unmatched brackets in some source files.
>
> test/jdk/sanity/client/lib/SwingSet3/src/com/sun/swingset3/demos/table/resources/oscars.xml
> line 2:
>
>> 1:
>> 2: http://www.fatdog.com/oscar-results";
>
> Does this change
On Mon, 23 Dec 2024 19:42:34 GMT, Kim Barrett wrote:
> > That makes it harder to review and to manage the review, because it is
> > large and affects a wide range of areas, so may need many reviewers.
>
> And many of the appropriate reviewers might be unavailable for a while, since
> it's righ
On Mon, 23 Dec 2024 19:33:36 GMT, Kim Barrett wrote:
> That makes it harder to review and to manage the review, because it is large
> and affects a wide range of areas, so may need many reviewers.
And many of the appropriate reviewers might be unavailable for a while, since
it's right before C
On Mon, 23 Dec 2024 09:45:00 GMT, Qizheng Xing wrote:
> This patch fixes unmatched brackets in some source files.
I strongly suggest avoiding omnibus changes like this when possible (which it
is here). Just because it's all about one "kind" of change doesn't make it a
cohesive change. This is to
On Mon, 23 Dec 2024 09:45:00 GMT, Qizheng Xing wrote:
> This patch fixes unmatched brackets in some source files.
make/data/cldr/common/main/kn.xml line 1085:
> 1083: ಇಸ್ಲಾಮಿಕ್
> ಕ್ಯಾಲೆಂಡರ್
> 1084: type="islamic-civil">ಇಸ್ಲಾಮಿಕ್-ಸಿವಿಲ್ ಕ್ಯಾಲೆಂಡರ
> This is a redo of [JDK-8304824](https://bugs.openjdk.org/browse/JDK-8304824)
> which was backed out by
> [JDK-8343726](https://bugs.openjdk.org/browse/JDK-8343726) due to problems
> documented in [JDK-8343244](https://bugs.openjdk.org/browse/JDK-8343244).
>
> The problem was that `NmtVirtualM
On Mon, 23 Dec 2024 07:58:32 GMT, Thomas Stuefe wrote:
>> I don't think this should ever get called during bootstrapping because
>> thread stacks are only accounted lazily when a snapshot is created. I don't
>> think an NMT snapshot would ever get created during bootstrapping, but just
>> in c
On Sat, 21 Dec 2024 07:16:22 GMT, Kim Barrett wrote:
>> Robert Toyonaga has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> move boostrapping_done flag into Mutex from MutexLocker
>
> src/hotspot/share/nmt/threadStackTracker.cpp line 55:
>
On Mon, 23 Dec 2024 09:45:00 GMT, Qizheng Xing wrote:
> This patch fixes unmatched brackets in some source files.
I can really only review the doc files and the Makefile.
doc/hotspot-unit-tests.md line 175:
> 173: there is no need to have them in error messages. Asserts print only
> 174: compa
This patch fixes unmatched brackets in some source files.
-
Commit messages:
- Fix unmatched brackets in source files.
Changes: https://git.openjdk.org/jdk/pull/22861/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=22861&range=00
Issue: https://bugs.openjdk.org/browse/JDK
On Sat, 21 Dec 2024 16:57:08 GMT, Kim Barrett wrote:
>> Robert Toyonaga has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> move boostrapping_done flag into Mutex from MutexLocker
>
> src/hotspot/share/runtime/mutexLocker.cpp line 291:
>
>>
On Fri, 20 Dec 2024 17:43:29 GMT, Robert Toyonaga wrote:
> I don't think this should ever get called during bootstrapping because thread
> stacks are only accounted lazily when a snapshot is created. I don't think an
> NMT snapshot would ever get created during bootstrapping, but just in case,
On Fri, 20 Dec 2024 20:21:39 GMT, Robert Toyonaga wrote:
>> src/hotspot/os/windows/os_windows.cpp line 3626:
>>
>>> 3624: os::print_memory_mappings((char*)start, bytes, &fs);
>>> 3625: assert(false, "bad release: [" PTR_FORMAT "-" PTR_FORMAT "):
>>> %s", p2i(start), p2i(end), err);
On Fri, 20 Dec 2024 20:19:50 GMT, Robert Toyonaga wrote:
>> This is a redo of [JDK-8304824](https://bugs.openjdk.org/browse/JDK-8304824)
>> which was backed out by
>> [JDK-8343726](https://bugs.openjdk.org/browse/JDK-8343726) due to problems
>> documented in [JDK-8343244](https://bugs.openjdk.
21 matches
Mail list logo
