On Thu, 19 Dec 2024 05:24:20 GMT, Serguei Spitsyn wrote:
>> New JVMTI function `ClearAllFramePops` will help to speedup debugger single
>> stepping in some cases.
>> Additionally, the JVMTI `NotifyFramePop` implementation was fixed to return
>> `JVMTI_ERROR_DUPLICATE` to make it consistent with
> New JVMTI function `ClearAllFramePops` will help to speedup debugger single
> stepping in some cases.
> Additionally, the JVMTI `NotifyFramePop` implementation was fixed to return
> `JVMTI_ERROR_DUPLICATE` to make it consistent with the `SetBreakpoint` which
> also returns this error.
>
> The
On Thu, 19 Dec 2024 04:46:12 GMT, Serguei Spitsyn wrote:
>> The JVMTI NotifyFramePop should return JVMTI_ERROR_DUPLICATE in a case the
>> specified FramePop event was already requested. This makes it consistent
>> with the SetBreakpoint which returns the JVMTI_ERROR_DUPLICATE on an attempt
>>
On Wed, 18 Dec 2024 03:28:30 GMT, Serguei Spitsyn wrote:
>> New JVMTI function `ClearAllFramePops` will help to speedup debugger single
>> stepping in some cases.
>> Additionally, the JVMTI `NotifyFramePop` implementation was fixed to return
>> `JVMTI_ERROR_DUPLICATE` to make it consistent with
On Thu, 19 Dec 2024 00:12:52 GMT, Alex Menkov wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review: removed unneeded check for JvmtiExport::can_post_frame_pop()
>
> src/hotspot/share/prims/jvmtiEnvThreadState.
On Thu, 19 Dec 2024 00:09:38 GMT, Alex Menkov wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review: removed unneeded check for JvmtiExport::can_post_frame_pop()
>
> src/hotspot/share/prims/jvmtiEnvThreadState.
On Wed, 18 Dec 2024 23:51:23 GMT, Alex Menkov wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review: removed unneeded check for JvmtiExport::can_post_frame_pop()
>
> src/hotspot/share/prims/jvmti.xml line 3096:
On Wed, 18 Dec 2024 03:12:14 GMT, Serguei Spitsyn wrote:
>> The JVMTI NotifyFramePop should return JVMTI_ERROR_DUPLICATE in a case the
>> specified FramePop event was already requested. This makes it consistent
>> with the SetBreakpoint which returns the JVMTI_ERROR_DUPLICATE on an attempt
>>
> The JVMTI NotifyFramePop should return JVMTI_ERROR_DUPLICATE in a case the
> specified FramePop event was already requested. This makes it consistent with
> the SetBreakpoint which returns the JVMTI_ERROR_DUPLICATE on an attempt to
> add a breakpoint request that was already requested.
>
> CS
On Wed, 18 Dec 2024 19:33:05 GMT, Alex Menkov wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review: minor tweak in jvmti.xml update
>
> test/hotspot/jtreg/serviceability/jvmti/vthread/MethodExitTest/libMethodE
On Wed, 18 Dec 2024 07:04:57 GMT, SendaoYan wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [414eb6bb](https://github.com/openjdk/jdk/commit/414eb6bb83d092fbcd87d5ab72519b6eb109837f)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> The commit being
On Wed, 18 Dec 2024 07:04:57 GMT, SendaoYan wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [414eb6bb](https://github.com/openjdk/jdk/commit/414eb6bb83d092fbcd87d5ab72519b6eb109837f)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> The commit being
On Wed, 18 Dec 2024 19:58:58 GMT, Kim Barrett wrote:
> You don't change ConditionalMutexLocker at all. Just change how it's used:
Doh! @kimbarrett don't know what I was thinking. Thanks
-
PR Comment: https://git.openjdk.org/jdk/pull/22745#issuecomment-2552637884
On Wed, 18 Dec 2024 14:36:41 GMT, Robert Toyonaga wrote:
>> src/hotspot/os/windows/os_windows.cpp line 3624:
>>
>>> 3622: #ifdef ASSERT
>>> 3623: fileStream fs(stdout);
>>> 3624: os::print_memory_mappings((char*)start, bytes, &fs);
>>
>> Why was this change made? tty could be stdout
On Wed, 18 Dec 2024 03:28:30 GMT, Serguei Spitsyn wrote:
>> New JVMTI function `ClearAllFramePops` will help to speedup debugger single
>> stepping in some cases.
>> Additionally, the JVMTI `NotifyFramePop` implementation was fixed to return
>> `JVMTI_ERROR_DUPLICATE` to make it consistent with
On Wed, 18 Dec 2024 15:09:56 GMT, Robert Toyonaga wrote:
>> This is a redo of [JDK-8304824](https://bugs.openjdk.org/browse/JDK-8304824)
>> which was backed out by
>> [JDK-8343726](https://bugs.openjdk.org/browse/JDK-8343726) due to problems
>> documented in [JDK-8343244](https://bugs.openjdk.
On Wed, 18 Dec 2024 07:04:57 GMT, SendaoYan wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [414eb6bb](https://github.com/openjdk/jdk/commit/414eb6bb83d092fbcd87d5ab72519b6eb109837f)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> The commit being
On Tue, 17 Dec 2024 13:45:38 GMT, Robert Toyonaga wrote:
>> `MutexLockerImpl` was not intended for external subclassing, but as the
>> internal base class for `MutexLocker`, and `ConditionalMutexLocker`. CML
>> was provided for exactly this kind of situation: conditionally locking the
>> mute
On Wed, 18 Dec 2024 04:37:22 GMT, David Holmes wrote:
> The direct use of CML is functionally correct but requires leaking knowledge
> to all the use-sites that should not need to know about the actual condition
> for locking. This really needs to be encapsulated which means we need to be
> ab
On Wed, 18 Dec 2024 03:12:14 GMT, Serguei Spitsyn wrote:
>> The JVMTI NotifyFramePop should return JVMTI_ERROR_DUPLICATE in a case the
>> specified FramePop event was already requested. This makes it consistent
>> with the SetBreakpoint which returns the JVMTI_ERROR_DUPLICATE on an attempt
>>
On Wed, 18 Dec 2024 03:12:14 GMT, Serguei Spitsyn wrote:
>> The JVMTI NotifyFramePop should return JVMTI_ERROR_DUPLICATE in a case the
>> specified FramePop event was already requested. This makes it consistent
>> with the SetBreakpoint which returns the JVMTI_ERROR_DUPLICATE on an attempt
>>
On Tue, 19 Nov 2024 16:18:48 GMT, Coleen Phillimore wrote:
> Please review this change that makes AccessFlags and modifier_flags u2 types
> and removes the last remnants of Hotspot adding internal access flags. This
> change moves AccessFlags and modifier_flags in Klass to alignment gaps savin
On Wed, 18 Dec 2024 17:06:02 GMT, Magnus Ihse Bursie wrote:
>> In several (most? all?) of the build system files, the copyright header
>> includes the classpath exception. This makes no sense, and should be
>> removed.
>>
>> I have removed the classpath exception from makefiles, autoconf, she
On Wed, 18 Dec 2024 03:12:14 GMT, Serguei Spitsyn wrote:
>> The JVMTI NotifyFramePop should return JVMTI_ERROR_DUPLICATE in a case the
>> specified FramePop event was already requested. This makes it consistent
>> with the SetBreakpoint which returns the JVMTI_ERROR_DUPLICATE on an attempt
>>
> In several (most? all?) of the build system files, the copyright header
> includes the classpath exception. This makes no sense, and should be removed.
>
> I have removed the classpath exception from makefiles, autoconf, shell
> scripts, properties files, configuration files, IDE support file
On Wed, 18 Dec 2024 04:31:45 GMT, David Holmes wrote:
>> Robert Toyonaga has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> updates tests and remove old class
>
> src/hotspot/share/runtime/threads.cpp line 530:
>
>> 528:
>> 529: // Once
> This is a redo of [JDK-8304824](https://bugs.openjdk.org/browse/JDK-8304824)
> which was backed out by
> [JDK-8343726](https://bugs.openjdk.org/browse/JDK-8343726) due to problems
> documented in [JDK-8343244](https://bugs.openjdk.org/browse/JDK-8343244).
>
> The problem was that `NmtVirtualM
On Wed, 18 Dec 2024 04:24:51 GMT, David Holmes wrote:
>> Robert Toyonaga has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> updates tests and remove old class
>
> src/hotspot/os/windows/os_windows.cpp line 3624:
>
>> 3622: #ifdef ASSERT
>>
> This is a redo of [JDK-8304824](https://bugs.openjdk.org/browse/JDK-8304824)
> which was backed out by
> [JDK-8343726](https://bugs.openjdk.org/browse/JDK-8343726) due to problems
> documented in [JDK-8343244](https://bugs.openjdk.org/browse/JDK-8343244).
>
> The problem was that `NmtVirtualM
29 matches
Mail list logo
