On Wed, 11 Sep 2024 18:22:00 GMT, Simon Tooke wrote:
> This is a port of #16301 to macOS.
>
> System.map and System.dump_map are implemented using the macOS API and
> provide roughly the same information in the same format. Most of the heavy
> lifting was implemented by @tstuefe in
> https:/
On Fri, 13 Dec 2024 23:07:53 GMT, Alex Menkov wrote:
>> In some circumstances ClassFileTransformer.transform can get
>> ClassCircularityError or LinkageError concatenating strings (see
>> JDK-8264667, JDK-8262002).
>> VerifyLocalVariableTableOnRetransformTest fails sometimes on Oracle CI.
>> Th
> In some circumstances ClassFileTransformer.transform can get
> ClassCircularityError or LinkageError concatenating strings (see JDK-8264667,
> JDK-8262002).
> VerifyLocalVariableTableOnRetransformTest fails sometimes on Oracle CI.
> The fix adds handling of the errors to get information for ana
On Fri, 13 Dec 2024 21:51:10 GMT, Alex Menkov wrote:
>> In some circumstances ClassFileTransformer.transform can get
>> ClassCircularityError or LinkageError concatenating strings (see
>> JDK-8264667, JDK-8262002).
>> VerifyLocalVariableTableOnRetransformTest fails sometimes on Oracle CI.
>> Th
On Fri, 13 Dec 2024 20:40:03 GMT, Chris Plummer wrote:
>> This test has been noisy lately, and all the failures have been on "Mac OS X
>> 15.0.1 (aarch64)".
>>
>> Forcing it to require any other OS version looks good in my testing.
>
> test/jdk/sun/management/jdp/JdpDefaultsTest.java line 33:
>
This increases MaxMetaspaceSize for this test so that it can be run with CDS
turned off. This change is upstreamed from the valhalla repo from when it
didn't have CDS on. The test still finds a metaspace leak with this larger
MaxMetaspaceSize.
-
Commit messages:
- 8337016: servi
On Fri, 13 Dec 2024 20:49:22 GMT, Chris Plummer wrote:
>> Alex Menkov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> feedback
>
> test/jdk/java/lang/instrument/VerifyLocalVariableTableOnRetransformTest.java
> line 259:
>
>> 257:
> In some circumstances ClassFileTransformer.transform can get
> ClassCircularityError or LinkageError concatenating strings (see JDK-8264667,
> JDK-8262002).
> VerifyLocalVariableTableOnRetransformTest fails sometimes on Oracle CI.
> The fix adds handling of the errors to get information for ana
> This moves the modifier_flag computation to when InstanceKlass, ObjArrayKlass
> and TypeArrayKlass are created.
>
> Tested with jck:vm and tier1-4.
Coleen Phillimore has updated the pull request incrementally with one
additional commit since the last revision:
Removed comment about compute
> The fix updates Linux (and server-side of macosx) implementation to support
> Attach API v2 (shared code and Windows implementation were introduced by
> #20782)
>
> Testing: tier1,tier2,tier3,tier4,hs-tier5-svc
> manually tested backward compatibility (old tools can attach to current VMs,
> c
On Fri, 13 Dec 2024 11:50:52 GMT, Serguei Spitsyn wrote:
>> Alex Menkov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> updated comment
>
> src/hotspot/share/services/attachListener.cpp line 670:
>
>> 668: // for v1 also name/argume
On Fri, 13 Dec 2024 15:57:31 GMT, Matthias Baesken wrote:
> > if no agents are loaded, I would print "JVMTI agents: none"
> > unconditionally. Makes it more obvious than just a missing entry; >that
> > could be also an error.
>
> Maybe after the while loop something like this ?
>
> ```
> bo
New JVMTI function `ClearAllFramePops` will help to speedup debugger single
stepping in some cases.
Additionally, the JVMTI `NotifyFramePop` implementation was fixed to return
`JVMTI_ERROR_DUPLICATE` to make it consistent with the `SetBreakpoint` which
also returns this error.
The JDWP agent fi
On Fri, 13 Dec 2024 02:21:42 GMT, Alex Menkov wrote:
> In some circumstances ClassFileTransformer.transform can get
> ClassCircularityError or LinkageError concatenating strings (see JDK-8264667,
> JDK-8262002).
> VerifyLocalVariableTableOnRetransformTest fails sometimes on Oracle CI.
> The fix
On Fri, 13 Dec 2024 18:58:12 GMT, Kevin Walls wrote:
> This test has been noisy lately, and all the failures have been on "Mac OS X
> 15.0.1 (aarch64)".
>
> Forcing it to require any other OS version looks good in my testing.
test/jdk/sun/management/jdp/JdpDefaultsTest.java line 33:
> 31: *
On Wed, 11 Dec 2024 13:55:24 GMT, Kevin Walls wrote:
> Unnecessary duplication of small utility method. There should be only one
> Util.newObjectName().
This pull request has now been integrated.
Changeset: e7fc0eb5
Author:Kevin Walls
URL:
https://git.openjdk.org/jdk/commit/e7fc0e
On Thu, 12 Dec 2024 14:51:02 GMT, Coleen Phillimore wrote:
>> This moves the modifier_flag computation to when InstanceKlass,
>> ObjArrayKlass and TypeArrayKlass are created.
>>
>> Tested with jck:vm and tier1-4.
>
> Coleen Phillimore has updated the pull request with a new target base due to
On Thu, 12 Dec 2024 09:54:03 GMT, Kevin Walls wrote:
>> Unnecessary duplication of small utility method. There should be only one
>> Util.newObjectName().
>
> Kevin Walls has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrel
On Fri, 13 Dec 2024 19:57:14 GMT, Leonid Mesnik wrote:
> Thanks for describing.
Thanks for confirming. The fewer of these methods the better!
> src/java.management/share/classes/javax/management/ObjectName.java line 1225:
>
>> 1223: if (name.getClass().equals(ObjectName.class))
>> 1224
On Thu, 12 Dec 2024 09:54:03 GMT, Kevin Walls wrote:
>> Unnecessary duplication of small utility method. There should be only one
>> Util.newObjectName().
>
> Kevin Walls has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrel
On Thu, 12 Dec 2024 09:54:03 GMT, Kevin Walls wrote:
>> Unnecessary duplication of small utility method. There should be only one
>> Util.newObjectName().
>
> Kevin Walls has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrel
On Fri, 13 Dec 2024 18:58:12 GMT, Kevin Walls wrote:
> This test has been noisy lately, and all the failures have been on "Mac OS X
> 15.0.1 (aarch64)".
>
> Forcing it to require any other OS version looks good in my testing.
There was a Linux x64 failure a few years back, but since un-problem
This test has been noisy lately, and all the failures have been on "Mac OS X
15.0.1 (aarch64)".
Forcing it to require any other OS version looks good in my testing.
-
Commit messages:
- remove uncalled misspelled method
- (C)
- update
- update
- 8241865: sun/management/jdp test
On Thu, 12 Dec 2024 00:01:41 GMT, William Kemper wrote:
> This test makes assertions about the number of gc manager beans and the
> number of memory pools. The generational mode for Shenandoah adds another
> memory pool.
This pull request has now been integrated.
Changeset: cfa04d31
Author:
On Fri, 13 Dec 2024 17:50:01 GMT, William Kemper wrote:
>> This test makes assertions about the number of gc manager beans and the
>> number of memory pools. The generational mode for Shenandoah adds another
>> memory pool.
>
> William Kemper has updated the pull request incrementally with one
> This test makes assertions about the number of gc manager beans and the
> number of memory pools. The generational mode for Shenandoah adds another
> memory pool.
William Kemper has updated the pull request incrementally with one additional
commit since the last revision:
Update copyright
On Thu, 12 Dec 2024 19:46:37 GMT, Sonia Zaldana Calles
wrote:
>> Simon Tooke has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 35 commits:
>>
>> - Merge branch 'openjdk:master' into pr_macos_system_dump
>> - fix crash due to unin
On Tue, 10 Dec 2024 12:41:00 GMT, Simon Tooke wrote:
>> This is a port of #16301 to macOS.
>>
>> System.map and System.dump_map are implemented using the macOS API and
>> provide roughly the same information in the same format. Most of the heavy
>> lifting was implemented by @tstuefe in
>> h
On Fri, 13 Dec 2024 12:18:13 GMT, Matthias Baesken wrote:
>> We should output more information about the JVMTI agents in the hserr file.
>
> Matthias Baesken has updated the pull request incrementally with one
> additional commit since the last revision:
>
> simplify coding
>if no agents are
On Fri, 13 Dec 2024 14:54:37 GMT, Martin Doerr wrote:
> Nice enhancement! Could you add an example output to the description, please?
Currently it looks like this
JVMTI agents:
asyncProfiler path:none, loaded, initialized
options:start,flat=1,interval=50us,traces=1,event=wall,loglevel=n
On Fri, 13 Dec 2024 12:18:13 GMT, Matthias Baesken wrote:
>> We should output more information about the JVMTI agents in the hserr file.
>
> Matthias Baesken has updated the pull request incrementally with one
> additional commit since the last revision:
>
> simplify coding
Looks fine, two b
On Tue, 10 Dec 2024 12:41:00 GMT, Simon Tooke wrote:
>> This is a port of #16301 to macOS.
>>
>> System.map and System.dump_map are implemented using the macOS API and
>> provide roughly the same information in the same format. Most of the heavy
>> lifting was implemented by @tstuefe in
>> h
On Fri, 13 Dec 2024 12:18:13 GMT, Matthias Baesken wrote:
>> We should output more information about the JVMTI agents in the hserr file.
>
> Matthias Baesken has updated the pull request incrementally with one
> additional commit since the last revision:
>
> simplify coding
Nice enhancement!
> We should output more information about the JVMTI agents in the hserr file.
Matthias Baesken has updated the pull request incrementally with one additional
commit since the last revision:
simplify coding
-
Changes:
- all: https://git.openjdk.org/jdk/pull/22706/files
- new:
On Wed, 11 Dec 2024 21:56:20 GMT, Alex Menkov wrote:
>> The fix updates Linux (and server-side of macosx) implementation to support
>> Attach API v2 (shared code and Windows implementation were introduced by
>> #20782)
>>
>> Testing: tier1,tier2,tier3,tier4,hs-tier5-svc
>> manually tested back
On Thu, 12 Dec 2024 21:43:12 GMT, Larry Cable wrote:
> I do not understand the use case that this additional information solves for,
> nor does the bug provide any further enlightenment, I think this ER requires
> more rationale to motivate its inclusion.
Currently the info about the JVMTI age
36 matches
Mail list logo