Integrated: 8319875: Add macOS implementation for jcmd System.map

2024-12-13 Thread Simon Tooke
On Wed, 11 Sep 2024 18:22:00 GMT, Simon Tooke wrote: > This is a port of #16301 to macOS. > > System.map and System.dump_map are implemented using the macOS API and > provide roughly the same information in the same format. Most of the heavy > lifting was implemented by @tstuefe in > https:/

Re: RFR: 8346151: Add transformer error logging to VerifyLocalVariableTableOnRetransformTest [v3]

2024-12-13 Thread Chris Plummer
On Fri, 13 Dec 2024 23:07:53 GMT, Alex Menkov wrote: >> In some circumstances ClassFileTransformer.transform can get >> ClassCircularityError or LinkageError concatenating strings (see >> JDK-8264667, JDK-8262002). >> VerifyLocalVariableTableOnRetransformTest fails sometimes on Oracle CI. >> Th

Re: RFR: 8346151: Add transformer error logging to VerifyLocalVariableTableOnRetransformTest [v3]

2024-12-13 Thread Alex Menkov
> In some circumstances ClassFileTransformer.transform can get > ClassCircularityError or LinkageError concatenating strings (see JDK-8264667, > JDK-8262002). > VerifyLocalVariableTableOnRetransformTest fails sometimes on Oracle CI. > The fix adds handling of the errors to get information for ana

Re: RFR: 8346151: Add transformer error logging to VerifyLocalVariableTableOnRetransformTest [v2]

2024-12-13 Thread Chris Plummer
On Fri, 13 Dec 2024 21:51:10 GMT, Alex Menkov wrote: >> In some circumstances ClassFileTransformer.transform can get >> ClassCircularityError or LinkageError concatenating strings (see >> JDK-8264667, JDK-8262002). >> VerifyLocalVariableTableOnRetransformTest fails sometimes on Oracle CI. >> Th

Re: RFR: 8241865: sun/management/jdp tests fail (Timed out waiting for JDP packet)

2024-12-13 Thread Kevin Walls
On Fri, 13 Dec 2024 20:40:03 GMT, Chris Plummer wrote: >> This test has been noisy lately, and all the failures have been on "Mac OS X >> 15.0.1 (aarch64)". >> >> Forcing it to require any other OS version looks good in my testing. > > test/jdk/sun/management/jdp/JdpDefaultsTest.java line 33: >

RFR: 8337016: serviceability/jvmti/RedefineClasses/RedefineLeakThrowable.java gets Metaspace OOM

2024-12-13 Thread Coleen Phillimore
This increases MaxMetaspaceSize for this test so that it can be run with CDS turned off. This change is upstreamed from the valhalla repo from when it didn't have CDS on. The test still finds a metaspace leak with this larger MaxMetaspaceSize. - Commit messages: - 8337016: servi

Re: RFR: 8346151: Add transformer error logging to VerifyLocalVariableTableOnRetransformTest [v2]

2024-12-13 Thread Alex Menkov
On Fri, 13 Dec 2024 20:49:22 GMT, Chris Plummer wrote: >> Alex Menkov has updated the pull request incrementally with one additional >> commit since the last revision: >> >> feedback > > test/jdk/java/lang/instrument/VerifyLocalVariableTableOnRetransformTest.java > line 259: > >> 257:

Re: RFR: 8346151: Add transformer error logging to VerifyLocalVariableTableOnRetransformTest [v2]

2024-12-13 Thread Alex Menkov
> In some circumstances ClassFileTransformer.transform can get > ClassCircularityError or LinkageError concatenating strings (see JDK-8264667, > JDK-8262002). > VerifyLocalVariableTableOnRetransformTest fails sometimes on Oracle CI. > The fix adds handling of the errors to get information for ana

Re: RFR: 8345678: compute_modifiers should not be in create_mirror [v4]

2024-12-13 Thread Coleen Phillimore
> This moves the modifier_flag computation to when InstanceKlass, ObjArrayKlass > and TypeArrayKlass are created. > > Tested with jck:vm and tier1-4. Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision: Removed comment about compute

Re: RFR: 8342995: Enhance Attach API to support arbitrary length arguments - Linux [v4]

2024-12-13 Thread Alex Menkov
> The fix updates Linux (and server-side of macosx) implementation to support > Attach API v2 (shared code and Windows implementation were introduced by > #20782) > > Testing: tier1,tier2,tier3,tier4,hs-tier5-svc > manually tested backward compatibility (old tools can attach to current VMs, > c

Re: RFR: 8342995: Enhance Attach API to support arbitrary length arguments - Linux [v3]

2024-12-13 Thread Alex Menkov
On Fri, 13 Dec 2024 11:50:52 GMT, Serguei Spitsyn wrote: >> Alex Menkov has updated the pull request incrementally with one additional >> commit since the last revision: >> >> updated comment > > src/hotspot/share/services/attachListener.cpp line 670: > >> 668: // for v1 also name/argume

Re: RFR: 8346082: Output JVMTI agent information in hserr files [v4]

2024-12-13 Thread Alex Menkov
On Fri, 13 Dec 2024 15:57:31 GMT, Matthias Baesken wrote: > > if no agents are loaded, I would print "JVMTI agents: none" > > unconditionally. Makes it more obvious than just a missing entry; >that > > could be also an error. > > Maybe after the while loop something like this ? > > ``` > bo

RFR: 8346143: add ClearAllFramePops function to speedup debugger single stepping in some cases

2024-12-13 Thread Serguei Spitsyn
New JVMTI function `ClearAllFramePops` will help to speedup debugger single stepping in some cases. Additionally, the JVMTI `NotifyFramePop` implementation was fixed to return `JVMTI_ERROR_DUPLICATE` to make it consistent with the `SetBreakpoint` which also returns this error. The JDWP agent fi

Re: RFR: 8346151: Add transformer error logging to VerifyLocalVariableTableOnRetransformTest

2024-12-13 Thread Chris Plummer
On Fri, 13 Dec 2024 02:21:42 GMT, Alex Menkov wrote: > In some circumstances ClassFileTransformer.transform can get > ClassCircularityError or LinkageError concatenating strings (see JDK-8264667, > JDK-8262002). > VerifyLocalVariableTableOnRetransformTest fails sometimes on Oracle CI. > The fix

Re: RFR: 8241865: sun/management/jdp tests fail (Timed out waiting for JDP packet)

2024-12-13 Thread Chris Plummer
On Fri, 13 Dec 2024 18:58:12 GMT, Kevin Walls wrote: > This test has been noisy lately, and all the failures have been on "Mac OS X > 15.0.1 (aarch64)". > > Forcing it to require any other OS version looks good in my testing. test/jdk/sun/management/jdp/JdpDefaultsTest.java line 33: > 31: *

Integrated: 8345987: java.management has two Util.newObjectName methods (remove one)

2024-12-13 Thread Kevin Walls
On Wed, 11 Dec 2024 13:55:24 GMT, Kevin Walls wrote: > Unnecessary duplication of small utility method. There should be only one > Util.newObjectName(). This pull request has now been integrated. Changeset: e7fc0eb5 Author:Kevin Walls URL: https://git.openjdk.org/jdk/commit/e7fc0e

Re: RFR: 8345678: compute_modifiers should not be in create_mirror [v3]

2024-12-13 Thread Frederic Parain
On Thu, 12 Dec 2024 14:51:02 GMT, Coleen Phillimore wrote: >> This moves the modifier_flag computation to when InstanceKlass, >> ObjArrayKlass and TypeArrayKlass are created. >> >> Tested with jck:vm and tier1-4. > > Coleen Phillimore has updated the pull request with a new target base due to

Re: RFR: 8345987: java.management has two Util.newObjectName methods (remove one) [v2]

2024-12-13 Thread Leonid Mesnik
On Thu, 12 Dec 2024 09:54:03 GMT, Kevin Walls wrote: >> Unnecessary duplication of small utility method. There should be only one >> Util.newObjectName(). > > Kevin Walls has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrel

Re: RFR: 8345987: java.management has two Util.newObjectName methods (remove one) [v2]

2024-12-13 Thread Kevin Walls
On Fri, 13 Dec 2024 19:57:14 GMT, Leonid Mesnik wrote: > Thanks for describing. Thanks for confirming. The fewer of these methods the better! > src/java.management/share/classes/javax/management/ObjectName.java line 1225: > >> 1223: if (name.getClass().equals(ObjectName.class)) >> 1224

Re: RFR: 8345987: java.management has two Util.newObjectName methods (remove one) [v2]

2024-12-13 Thread Leonid Mesnik
On Thu, 12 Dec 2024 09:54:03 GMT, Kevin Walls wrote: >> Unnecessary duplication of small utility method. There should be only one >> Util.newObjectName(). > > Kevin Walls has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrel

Re: RFR: 8345987: java.management has two Util.newObjectName methods (remove one) [v2]

2024-12-13 Thread Kevin Walls
On Thu, 12 Dec 2024 09:54:03 GMT, Kevin Walls wrote: >> Unnecessary duplication of small utility method. There should be only one >> Util.newObjectName(). > > Kevin Walls has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrel

Re: RFR: 8241865: sun/management/jdp tests fail (Timed out waiting for JDP packet)

2024-12-13 Thread Kevin Walls
On Fri, 13 Dec 2024 18:58:12 GMT, Kevin Walls wrote: > This test has been noisy lately, and all the failures have been on "Mac OS X > 15.0.1 (aarch64)". > > Forcing it to require any other OS version looks good in my testing. There was a Linux x64 failure a few years back, but since un-problem

RFR: 8241865: sun/management/jdp tests fail (Timed out waiting for JDP packet)

2024-12-13 Thread Kevin Walls
This test has been noisy lately, and all the failures have been on "Mac OS X 15.0.1 (aarch64)". Forcing it to require any other OS version looks good in my testing. - Commit messages: - remove uncalled misspelled method - (C) - update - update - 8241865: sun/management/jdp test

Integrated: 8346051: MemoryTest fails when Shenandoah's generational mode is enabled

2024-12-13 Thread William Kemper
On Thu, 12 Dec 2024 00:01:41 GMT, William Kemper wrote: > This test makes assertions about the number of gc manager beans and the > number of memory pools. The generational mode for Shenandoah adds another > memory pool. This pull request has now been integrated. Changeset: cfa04d31 Author:

Re: RFR: 8346051: MemoryTest fails when Shenandoah's generational mode is enabled [v2]

2024-12-13 Thread Leonid Mesnik
On Fri, 13 Dec 2024 17:50:01 GMT, William Kemper wrote: >> This test makes assertions about the number of gc manager beans and the >> number of memory pools. The generational mode for Shenandoah adds another >> memory pool. > > William Kemper has updated the pull request incrementally with one

Re: RFR: 8346051: MemoryTest fails when Shenandoah's generational mode is enabled [v2]

2024-12-13 Thread William Kemper
> This test makes assertions about the number of gc manager beans and the > number of memory pools. The generational mode for Shenandoah adds another > memory pool. William Kemper has updated the pull request incrementally with one additional commit since the last revision: Update copyright

Re: RFR: 8319875: Add macOS implementation for jcmd System.map [v17]

2024-12-13 Thread Simon Tooke
On Thu, 12 Dec 2024 19:46:37 GMT, Sonia Zaldana Calles wrote: >> Simon Tooke has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 35 commits: >> >> - Merge branch 'openjdk:master' into pr_macos_system_dump >> - fix crash due to unin

Re: RFR: 8319875: Add macOS implementation for jcmd System.map [v17]

2024-12-13 Thread duke
On Tue, 10 Dec 2024 12:41:00 GMT, Simon Tooke wrote: >> This is a port of #16301 to macOS. >> >> System.map and System.dump_map are implemented using the macOS API and >> provide roughly the same information in the same format. Most of the heavy >> lifting was implemented by @tstuefe in >> h

Re: RFR: 8346082: Output JVMTI agent information in hserr files [v4]

2024-12-13 Thread Matthias Baesken
On Fri, 13 Dec 2024 12:18:13 GMT, Matthias Baesken wrote: >> We should output more information about the JVMTI agents in the hserr file. > > Matthias Baesken has updated the pull request incrementally with one > additional commit since the last revision: > > simplify coding >if no agents are

Re: RFR: 8346082: Output JVMTI agent information in hserr files [v4]

2024-12-13 Thread Matthias Baesken
On Fri, 13 Dec 2024 14:54:37 GMT, Martin Doerr wrote: > Nice enhancement! Could you add an example output to the description, please? Currently it looks like this JVMTI agents: asyncProfiler path:none, loaded, initialized options:start,flat=1,interval=50us,traces=1,event=wall,loglevel=n

Re: RFR: 8346082: Output JVMTI agent information in hserr files [v4]

2024-12-13 Thread Thomas Stuefe
On Fri, 13 Dec 2024 12:18:13 GMT, Matthias Baesken wrote: >> We should output more information about the JVMTI agents in the hserr file. > > Matthias Baesken has updated the pull request incrementally with one > additional commit since the last revision: > > simplify coding Looks fine, two b

Re: RFR: 8319875: Add macOS implementation for jcmd System.map [v17]

2024-12-13 Thread Thomas Stuefe
On Tue, 10 Dec 2024 12:41:00 GMT, Simon Tooke wrote: >> This is a port of #16301 to macOS. >> >> System.map and System.dump_map are implemented using the macOS API and >> provide roughly the same information in the same format. Most of the heavy >> lifting was implemented by @tstuefe in >> h

Re: RFR: 8346082: Output JVMTI agent information in hserr files [v4]

2024-12-13 Thread Martin Doerr
On Fri, 13 Dec 2024 12:18:13 GMT, Matthias Baesken wrote: >> We should output more information about the JVMTI agents in the hserr file. > > Matthias Baesken has updated the pull request incrementally with one > additional commit since the last revision: > > simplify coding Nice enhancement!

Re: RFR: 8346082: Output JVMTI agent information in hserr files [v4]

2024-12-13 Thread Matthias Baesken
> We should output more information about the JVMTI agents in the hserr file. Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision: simplify coding - Changes: - all: https://git.openjdk.org/jdk/pull/22706/files - new:

Re: RFR: 8342995: Enhance Attach API to support arbitrary length arguments - Linux [v3]

2024-12-13 Thread Serguei Spitsyn
On Wed, 11 Dec 2024 21:56:20 GMT, Alex Menkov wrote: >> The fix updates Linux (and server-side of macosx) implementation to support >> Attach API v2 (shared code and Windows implementation were introduced by >> #20782) >> >> Testing: tier1,tier2,tier3,tier4,hs-tier5-svc >> manually tested back

Re: RFR: 8346082: Output JVMTI agent information in hserr files [v3]

2024-12-13 Thread Matthias Baesken
On Thu, 12 Dec 2024 21:43:12 GMT, Larry Cable wrote: > I do not understand the use case that this additional information solves for, > nor does the bug provide any further enlightenment, I think this ER requires > more rationale to motivate its inclusion. Currently the info about the JVMTI age