RFR: 8346151: Add transformer error logging to VerifyLocalVariableTableOnRetransformTest

2024-12-12 Thread Alex Menkov
In some circumstances ClassFileTransformer.transform can get ClassCircularityError or LinkageError concatenating strings (see JDK-8264667, JDK-8262002). VerifyLocalVariableTableOnRetransformTest fails sometimes on Oracle CI. The fix adds handling of the errors to get information for analysis. --

Re: RFR: 8341481: [perf] vframeStreamCommon constructor may be optimized [v2]

2024-12-12 Thread Vladimir Ivanov
> Optimize constructor to skip extra copy for registers. The tier1 tests are > OK. The Specjvm2008 benchmark reports ~1% improvement. Vladimir Ivanov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in

Re: RFR: 8345987: java.management has two Util.newObjectName methods (remove one) [v2]

2024-12-12 Thread Leonid Mesnik
On Thu, 12 Dec 2024 09:54:03 GMT, Kevin Walls wrote: >> Unnecessary duplication of small utility method. There should be only one >> Util.newObjectName(). > > Kevin Walls has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrel

Re: RFR: 8346051: MemoryTest fails when Shenandoah's generational mode is enabled

2024-12-12 Thread Leonid Mesnik
On Thu, 12 Dec 2024 00:01:41 GMT, William Kemper wrote: > This test makes assertions about the number of gc manager beans and the > number of memory pools. The generational mode for Shenandoah adds another > memory pool. Please update copyrights. - PR Review: https://git.openjdk.

Re: RFR: 8346051: MemoryTest fails when Shenandoah's generational mode is enabled

2024-12-12 Thread Y . Srinivas Ramakrishna
On Thu, 12 Dec 2024 00:01:41 GMT, William Kemper wrote: > This test makes assertions about the number of gc manager beans and the > number of memory pools. The generational mode for Shenandoah adds another > memory pool. test/jdk/java/lang/management/MemoryMXBean/MemoryTest.java line 62: > 60

Re: RFR: 8346051: MemoryTest fails when Shenandoah's generational mode is enabled

2024-12-12 Thread Y . Srinivas Ramakrishna
On Thu, 12 Dec 2024 00:01:41 GMT, William Kemper wrote: > This test makes assertions about the number of gc manager beans and the > number of memory pools. The generational mode for Shenandoah adds another > memory pool. Marked as reviewed by ysr (Reviewer). - PR Review: https://

Re: RFR: 8346082: Output JVMTI agent information is hserr files [v3]

2024-12-12 Thread Alex Menkov
On Thu, 12 Dec 2024 12:41:28 GMT, Matthias Baesken wrote: >> We should output more information about the JVMTI agents in the hserr file. > > Matthias Baesken has updated the pull request incrementally with one > additional commit since the last revision: > > infos -> info src/hotspot/share/r

Re: RFR: 8345987: java.management has two Util.newObjectName methods (remove one) [v2]

2024-12-12 Thread Kevin Walls
On Thu, 12 Dec 2024 09:54:03 GMT, Kevin Walls wrote: >> Unnecessary duplication of small utility method. There should be only one >> Util.newObjectName(). > > Kevin Walls has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrel

Re: RFR: 8346082: Output JVMTI agent information is hserr files [v3]

2024-12-12 Thread Larry Cable
On Thu, 12 Dec 2024 12:41:28 GMT, Matthias Baesken wrote: >> We should output more information about the JVMTI agents in the hserr file. > > Matthias Baesken has updated the pull request incrementally with one > additional commit since the last revision: > > infos -> info I do not understand

Re: RFR: 8346082: Output JVMTI agent information is hserr files [v3]

2024-12-12 Thread David Holmes
On Thu, 12 Dec 2024 12:41:28 GMT, Matthias Baesken wrote: >> We should output more information about the JVMTI agents in the hserr file. > > Matthias Baesken has updated the pull request incrementally with one > additional commit since the last revision: > > infos -> info Seems okay. Someone

Re: RFR: 8319875: Add macOS implementation for jcmd System.map [v17]

2024-12-12 Thread Sonia Zaldana Calles
On Tue, 10 Dec 2024 12:41:00 GMT, Simon Tooke wrote: >> This is a port of #16301 to macOS. >> >> System.map and System.dump_map are implemented using the macOS API and >> provide roughly the same information in the same format. Most of the heavy >> lifting was implemented by @tstuefe in >> h

Integrated: 8339313: 32-bit build broken

2024-12-12 Thread Thomas Stuefe
On Thu, 12 Dec 2024 11:39:33 GMT, Thomas Stuefe wrote: > Two fixes to fix the 32-bit build. > > See JBS issue and code comment for details. > > I ran nNoClassDefFoundErrorTest x64 and x86 fastdebug and release. On > fastdebug, the giant string test now gets silently skipped as expected. This

Re: RFR: 8339313: 32-bit build broken

2024-12-12 Thread Thomas Stuefe
On Thu, 12 Dec 2024 11:39:33 GMT, Thomas Stuefe wrote: > Two fixes to fix the 32-bit build. > > See JBS issue and code comment for details. > > I ran nNoClassDefFoundErrorTest x64 and x86 fastdebug and release. On > fastdebug, the giant string test now gets silently skipped as expected. Thank

Re: RFR: 8345987: java.management has two Util.newObjectName methods (remove one) [v2]

2024-12-12 Thread Alex Menkov
On Thu, 12 Dec 2024 09:54:03 GMT, Kevin Walls wrote: >> Unnecessary duplication of small utility method. There should be only one >> Util.newObjectName(). > > Kevin Walls has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrel

Re: RFR: 8345987: java.management has two Util.newObjectName methods (remove one) [v2]

2024-12-12 Thread Chris Plummer
On Thu, 12 Dec 2024 09:54:03 GMT, Kevin Walls wrote: >> Unnecessary duplication of small utility method. There should be only one >> Util.newObjectName(). > > Kevin Walls has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrel

Re: RFR: 8345987: java.management has two Util.newObjectName methods (remove one) [v2]

2024-12-12 Thread Kevin Walls
On Thu, 12 Dec 2024 09:54:03 GMT, Kevin Walls wrote: >> Unnecessary duplication of small utility method. There should be only one >> Util.newObjectName(). > > Kevin Walls has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrel

Re: RFR: 8345678: compute_modifiers should not be in create_mirror [v3]

2024-12-12 Thread Coleen Phillimore
> This moves the modifier_flag computation to when InstanceKlass, ObjArrayKlass > and TypeArrayKlass are created. > > Tested with jck:vm and tier1-4. Coleen Phillimore has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated c

Re: RFR: 8339313: 32-bit build broken

2024-12-12 Thread Sonia Zaldana Calles
On Thu, 12 Dec 2024 11:39:33 GMT, Thomas Stuefe wrote: > Two fixes to fix the 32-bit build. > > See JBS issue and code comment for details. > > I ran nNoClassDefFoundErrorTest x64 and x86 fastdebug and release. On > fastdebug, the giant string test now gets silently skipped as expected. I am

Re: RFR: 8339313: 32-bit build broken

2024-12-12 Thread Matthias Baesken
On Thu, 12 Dec 2024 11:39:33 GMT, Thomas Stuefe wrote: > Two fixes to fix the 32-bit build. > > See JBS issue and code comment for details. > > I ran nNoClassDefFoundErrorTest x64 and x86 fastdebug and release. On > fastdebug, the giant string test now gets silently skipped as expected. Marke

Re: RFR: 8339313: 32-bit build broken

2024-12-12 Thread Thomas Stuefe
On Thu, 12 Dec 2024 11:39:33 GMT, Thomas Stuefe wrote: > Two fixes to fix the 32-bit build. > > See JBS issue and code comment for details. > > I ran nNoClassDefFoundErrorTest x64 and x86 fastdebug and release. On > fastdebug, the giant string test now gets silently skipped as expected. @MBae

Re: RFR: 8339313: 32-bit build broken

2024-12-12 Thread Coleen Phillimore
On Thu, 12 Dec 2024 11:39:33 GMT, Thomas Stuefe wrote: > Two fixes to fix the 32-bit build. > > See JBS issue and code comment for details. > > I ran nNoClassDefFoundErrorTest x64 and x86 fastdebug and release. On > fastdebug, the giant string test now gets silently skipped as expected. Seems

RFR: 8339313: 32-bit build broken

2024-12-12 Thread Thomas Stuefe
Two fixes to fix the 32-bit build. See JBS issue and code comment for details. I ran nNoClassDefFoundErrorTest x64 and x86 fastdebug and release. On fastdebug, the giant string test now gets silently skipped as expected. - Commit messages: - fix Changes: https://git.openjdk.org/j

Re: RFR: 8345987: java.management has two Util.newObjectName methods (remove one) [v2]

2024-12-12 Thread Kevin Walls
On Wed, 11 Dec 2024 22:46:14 GMT, Chris Plummer wrote: >> Right, there are two Util classes, and some classes use both... >> e.g. ObjectName.java uses com.sun.jmx.mbeanserver.Util (for >> Util.wildmatch()), >> and I want to use newObjectName from sun.management.Util. > >> Right, there are two U

Re: RFR: 8345987: java.management has two Util.newObjectName methods (remove one) [v2]

2024-12-12 Thread Kevin Walls
> Unnecessary duplication of small utility method. There should be only one > Util.newObjectName(). Kevin Walls has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request

Re: RFR: 8345984: Remove redundant checkXXX methods from java.management Util class [v2]

2024-12-12 Thread Kevin Walls
On Wed, 11 Dec 2024 13:04:51 GMT, Kevin Walls wrote: >> A post-SecurityManager removal cleanup task, to remove checkAccess(), >> checkMonitorAccess() and checkControlAccess() from >> src/java.management/share/classes/sun/management/Util.java (methods are >> already no-ops). >> >> While here,

Integrated: 8345984: Remove redundant checkXXX methods from java.management Util class

2024-12-12 Thread Kevin Walls
On Wed, 11 Dec 2024 12:17:55 GMT, Kevin Walls wrote: > A post-SecurityManager removal cleanup task, to remove checkAccess(), > checkMonitorAccess() and checkControlAccess() from > src/java.management/share/classes/sun/management/Util.java (methods are > already no-ops). > > While here, there