On Wed, 7 Aug 2024 17:13:06 GMT, Gerard Ziemski wrote:
> Please review this cleanup, where we rename `MEMFLAGS` to `MemType`.
>
> `MEMFLAGS` implies that we can use more than one at the same time, but those
> are exclusive values, so `MemType` is much more suitable name.
>
> There is a bunch o
On Wed, 7 Aug 2024 17:13:06 GMT, Gerard Ziemski wrote:
> Please review this cleanup, where we rename `MEMFLAGS` to `MemType`.
>
> `MEMFLAGS` implies that we can use more than one at the same time, but those
> are exclusive values, so `MemType` is much more suitable name.
>
> There is a bunch o
On Fri, 9 Aug 2024 18:53:28 GMT, Kevin Walls wrote:
>> Ok. I see now that
>> [JDK-8334492](https://bugs.openjdk.org/browse/JDK-8334492) made the STRING
>> -> FILE change, so yes the docs should be consistent, but I think we need a
>> new CR filed to cleanup JFR dcmds, which continue to use STR
On Fri, 9 Aug 2024 17:50:26 GMT, Chris Plummer wrote:
>> OK yes - my thinking is:
>>
>> They are strings of course, but they are also names of an output FILE, and
>> those are distinct because they do %p substitution.
>>
>> They need to have a "type" of FILE internally in the tool, so they get
On Thu, 8 Aug 2024 18:45:00 GMT, Kevin Walls wrote:
>> src/jdk.jcmd/share/man/jcmd.1 line 258:
>>
>>> 256: \f[I]filename\f[R]: (Optional) The name of the map file.
>>> 257: If %p is specified in the filename, it is expanded to the JVM\[aq]s
>>> PID.
>>> 258: (FILE, \[dq]/tmp/perf-%p.map\[dq])
>
On Fri, 9 Aug 2024 16:50:45 GMT, Leonid Mesnik wrote:
>> The nsk/jdb tests updated to use driver instead of othervm. The
>> nsk/share/jdb code updated to set correct classpath and throw Exceptions
>> instead of exit.
>>
>> Testing by running tests with different flags and in different CI mode
> The nsk/jdb tests updated to use driver instead of othervm. The nsk/share/jdb
> code updated to set correct classpath and throw Exceptions instead of exit.
>
> Testing by running tests with different flags and in different CI modes.
>
> The 'shouldPass()' might be changed to throw SkippedExce
On Fri, 9 Aug 2024 02:25:33 GMT, Leonid Mesnik wrote:
> The nsk/jdb tests updated to use driver instead of othervm. The nsk/share/jdb
> code updated to set correct classpath and throw Exceptions instead of exit.
>
> Testing by running tests with different flags and in different CI modes.
>
>
The nsk/jdb tests updated to use driver instead of othervm. The nsk/share/jdb
code updated to set correct classpath and throw Exceptions instead of exit.
Testing by running tests with different flags and in different CI modes.
The 'shouldPass()' might be changed to throw SkippedException but I
