Re: RFR: 8072701: resume001 failed due to ERROR: timeout for waiting for a BreakpintEvent

2024-07-09 Thread Chris Plummer
On Tue, 9 Jul 2024 19:17:26 GMT, Alex Menkov wrote: > This does not look correct to me. > This is the last test scenario - thread2.resume should resumes the thread > while vm is suspended. > thread2 should not be blocked on main thread. > Looking at the debuggee I suppose the blocking is possibl

Re: RFR: 8335743: jhsdb jstack cannot print some information on the waiting thread [v2]

2024-07-09 Thread David Holmes
On Mon, 8 Jul 2024 12:16:51 GMT, KIRIYAMA Takuya wrote: >> This bug was introduced by JDK-8284161. "Object.wait (long timeoutMillis)" >> was changed to call "Object.wait0 (long timeoutMillis)" in JDK-8284161. >> >> When "jhdsb jstack" is executed, the stack and lock information are printed >>

Integrated: 8335966: Remove incorrect problem listing of java/lang/instrument/NativeMethodPrefixAgent.java in ProblemList-Virtual.txt

2024-07-09 Thread Jaikiran Pai
On Tue, 9 Jul 2024 08:39:39 GMT, Jaikiran Pai wrote: > Can I please get a review of this change which removes an incorrect entry > from `ProblemList-Virtual.txt`? > > As noted in https://bugs.openjdk.org/browse/JDK-8335966 this entry is a left > over which went unnoticed when we did the change

Re: RFR: 8335966: Remove incorrect problem listing of java/lang/instrument/NativeMethodPrefixAgent.java in ProblemList-Virtual.txt

2024-07-09 Thread Jaikiran Pai
On Tue, 9 Jul 2024 08:39:39 GMT, Jaikiran Pai wrote: > Can I please get a review of this change which removes an incorrect entry > from `ProblemList-Virtual.txt`? > > As noted in https://bugs.openjdk.org/browse/JDK-8335966 this entry is a left > over which went unnoticed when we did the change

Re: RFR: 8315884: New Object to ObjectMonitor mapping [v3]

2024-07-09 Thread Coleen Phillimore
On Mon, 8 Jul 2024 16:21:16 GMT, Axel Boldt-Christmas wrote: >> When inflating a monitor the `ObjectMonitor*` is written directly over the >> `markWord` and any overwritten data is displaced into a displaced >> `markWord`. This is problematic for concurrent GCs which needs extra care or >> lo

Re: RFR: 8335966: Remove incorrect problem listing of java/lang/instrument/NativeMethodPrefixAgent.java in ProblemList-Virtual.txt

2024-07-09 Thread Alex Menkov
On Tue, 9 Jul 2024 08:39:39 GMT, Jaikiran Pai wrote: > Can I please get a review of this change which removes an incorrect entry > from `ProblemList-Virtual.txt`? > > As noted in https://bugs.openjdk.org/browse/JDK-8335966 this entry is a left > over which went unnoticed when we did the change

[jdk23] Integrated: 8335124: com/sun/management/ThreadMXBean/ThreadCpuTimeArray.java failed with CPU time out of expected range

2024-07-09 Thread Kevin Walls
On Wed, 3 Jul 2024 08:24:43 GMT, Kevin Walls wrote: > Clean backport to jdk23 of a simple test update, to try and avoid spurious > failures. This pull request has now been integrated. Changeset: 70ad622b Author:Kevin Walls URL: https://git.openjdk.org/jdk/commit/70ad622bc23fc5a1808

Re: RFR: 8072701: resume001 failed due to ERROR: timeout for waiting for a BreakpintEvent

2024-07-09 Thread Alex Menkov
On Tue, 9 Jul 2024 04:43:59 GMT, Chris Plummer wrote: > The test hits a breakpoint on thread2 with SUSPEND_EVENT_THREAD policy, so > only thread2 is suspended. It then does a vm.suspend(), which suspends all > threads and bumps the suspendCount of thread2 up to 2. It then does an > eventSet.re

Re: RFR: 8335743: jhsdb jstack cannot print some information on the waiting thread [v2]

2024-07-09 Thread Kevin Walls
On Mon, 8 Jul 2024 12:16:51 GMT, KIRIYAMA Takuya wrote: >> This bug was introduced by JDK-8284161. "Object.wait (long timeoutMillis)" >> was changed to call "Object.wait0 (long timeoutMillis)" in JDK-8284161. >> >> When "jhdsb jstack" is executed, the stack and lock information are printed >>

Re: RFR: 8335619: Add an @apiNote to j.l.i.ClassFileTransformer to warn about recursive class loading and ClassCircularityErrors [v2]

2024-07-09 Thread Volker Simonis
On Tue, 9 Jul 2024 12:17:25 GMT, Alan Bateman wrote: >> @AlanBateman would you mind having a quick look at this trivial, >> documentation-only PR and let me know if you're OK with it? >> >> Thank you and best regards, >> Volker > >> @AlanBateman would you mind having a quick look at this trivia

Re: RFR: 8335619: Add an @apiNote to j.l.i.ClassFileTransformer to warn about recursive class loading and ClassCircularityErrors [v3]

2024-07-09 Thread Volker Simonis
> Since Java 5 the `java.lang.instrument` package provides services that allow > Java programming language agents to instrument (i.e. modify the bytecode) of > programs running on the Java Virtual Machine. The `java.lang.instrument` > functionality is based and implemented on top of the native J

Integrated: 8335688: Fix -Wzero-as-null-pointer-constant warnings from fflush calls in jvmti tests

2024-07-09 Thread Kim Barrett
On Thu, 4 Jul 2024 12:15:09 GMT, Kim Barrett wrote: > Please review this change to some jvmti tests, which were calling fflush with > an argument of 0. Most of these are in C++ code, where we change them to use > nullptr as the argument. A couple are in C, where we change them to use NULL. > Thi

Re: RFR: 8335688: Fix -Wzero-as-null-pointer-constant warnings from fflush calls in jvmti tests

2024-07-09 Thread Kim Barrett
On Fri, 5 Jul 2024 07:51:08 GMT, Julian Waters wrote: >> Please review this change to some jvmti tests, which were calling fflush with >> an argument of 0. Most of these are in C++ code, where we change them to use >> nullptr as the argument. A couple are in C, where we change them to use >> NU

Re: RFR: 8335688: Fix -Wzero-as-null-pointer-constant warnings from fflush calls in jvmti tests

2024-07-09 Thread Coleen Phillimore
On Thu, 4 Jul 2024 12:15:09 GMT, Kim Barrett wrote: > Please review this change to some jvmti tests, which were calling fflush with > an argument of 0. Most of these are in C++ code, where we change them to use > nullptr as the argument. A couple are in C, where we change them to use NULL. > Thi

Re: RFR: 8335710: serviceability/dcmd/vm/SystemDumpMapTest.java and SystemMapTest.java fail on Linux Alpine after 8322475

2024-07-09 Thread Thomas Stuefe
On Tue, 9 Jul 2024 12:32:06 GMT, Thomas Stuefe wrote: > I dislike having no test that checks that standard OS-side segments are shown. > > Does Alpine have a [heap] segment at least? Could scan for that. Checked and Alpine processes have a `[heap]` segment. Could you try that? - P

Re: RFR: 8335710: serviceability/dcmd/vm/SystemDumpMapTest.java and SystemMapTest.java fail on Linux Alpine after 8322475

2024-07-09 Thread Thomas Stuefe
On Tue, 9 Jul 2024 12:26:01 GMT, Thomas Stuefe wrote: > Wait, didn't I fix this already? Weird, I could have sworn I fixed that. Ah well. - PR Comment: https://git.openjdk.org/jdk/pull/20072#issuecomment-2217557748

Re: RFR: 8335710: serviceability/dcmd/vm/SystemDumpMapTest.java and SystemMapTest.java fail on Linux Alpine after 8322475

2024-07-09 Thread Thomas Stuefe
On Mon, 8 Jul 2024 11:06:45 GMT, Matthias Baesken wrote: > Unfortunately those 2 tests fail now on Linux Alpine (x86_64) : > serviceability/dcmd/vm/SystemDumpMapTest.java > > Missing patterns in dump: > 0x\\p{XDigit}+-0x\\p{XDigit}+ +\\d+ +[rwsxp-]+ +\\d+ +\\d+ > +(4K|8K|16K|64K|2M|16M|64M) +co

Re: RFR: 8335710: serviceability/dcmd/vm/SystemDumpMapTest.java and SystemMapTest.java fail on Linux Alpine after 8322475

2024-07-09 Thread Thomas Stuefe
On Mon, 8 Jul 2024 11:06:45 GMT, Matthias Baesken wrote: > Unfortunately those 2 tests fail now on Linux Alpine (x86_64) : > serviceability/dcmd/vm/SystemDumpMapTest.java > > Missing patterns in dump: > 0x\\p{XDigit}+-0x\\p{XDigit}+ +\\d+ +[rwsxp-]+ +\\d+ +\\d+ > +(4K|8K|16K|64K|2M|16M|64M) +co

Re: RFR: 8335619: Add an @apiNote to j.l.i.ClassFileTransformer to warn about recursive class loading and ClassCircularityErrors [v2]

2024-07-09 Thread Alan Bateman
On Fri, 5 Jul 2024 07:28:13 GMT, Volker Simonis wrote: > @AlanBateman would you mind having a quick look at this trivial, > documentation-only PR and let me know if you're OK with it? (Catching up as I was away for a few days). I agree it would be useful to have an API note on this topic. The

Re: RFR: 8335710: serviceability/dcmd/vm/SystemDumpMapTest.java and SystemMapTest.java fail on Linux Alpine after 8322475

2024-07-09 Thread Lutz Schmidt
On Mon, 8 Jul 2024 11:06:45 GMT, Matthias Baesken wrote: > Unfortunately those 2 tests fail now on Linux Alpine (x86_64) : > serviceability/dcmd/vm/SystemDumpMapTest.java > > Missing patterns in dump: > 0x\\p{XDigit}+-0x\\p{XDigit}+ +\\d+ +[rwsxp-]+ +\\d+ +\\d+ > +(4K|8K|16K|64K|2M|16M|64M) +co

Re: RFR: 8335882: platform/cgroup/TestSystemSettings.java fails on Alpine Linux

2024-07-09 Thread Severin Gehwolf
On Mon, 8 Jul 2024 14:19:21 GMT, Severin Gehwolf wrote: > Please review this simple test fix to exclude the test from being run on an > Alpine Linux system. Apparently default Alpine Linux systems don't have > cgroups set up by default the way other distros do. More info on the bug. I > propos

Integrated: 8335882: platform/cgroup/TestSystemSettings.java fails on Alpine Linux

2024-07-09 Thread Severin Gehwolf
On Mon, 8 Jul 2024 14:19:21 GMT, Severin Gehwolf wrote: > Please review this simple test fix to exclude the test from being run on an > Alpine Linux system. Apparently default Alpine Linux systems don't have > cgroups set up by default the way other distros do. More info on the bug. I > propos

Re: RFR: 8335966: Remove incorrect problem listing of java/lang/instrument/NativeMethodPrefixAgent.java in ProblemList-Virtual.txt

2024-07-09 Thread Kevin Walls
On Tue, 9 Jul 2024 08:39:39 GMT, Jaikiran Pai wrote: > Can I please get a review of this change which removes an incorrect entry > from `ProblemList-Virtual.txt`? > > As noted in https://bugs.openjdk.org/browse/JDK-8335966 this entry is a left > over which went unnoticed when we did the change

Re: RFR: 8072701: resume001 failed due to ERROR: timeout for waiting for a BreakpintEvent

2024-07-09 Thread Kevin Walls
On Tue, 9 Jul 2024 04:43:59 GMT, Chris Plummer wrote: > The test hits a breakpoint on thread2 with SUSPEND_EVENT_THREAD policy, so > only thread2 is suspended. It then does a vm.suspend(), which suspends all > threads and bumps the suspendCount of thread2 up to 2. It then does an > eventSet.re

Re: RFR: 8335882: platform/cgroup/TestSystemSettings.java fails on Alpine Linux

2024-07-09 Thread Matthias Baesken
On Mon, 8 Jul 2024 14:19:21 GMT, Severin Gehwolf wrote: > Please review this simple test fix to exclude the test from being run on an > Alpine Linux system. Apparently default Alpine Linux systems don't have > cgroups set up by default the way other distros do. More info on the bug. I > propos

RFR: 8335966: Remove incorrect problem listing of java/lang/instrument/NativeMethodPrefixAgent.java in ProblemList-Virtual.txt

2024-07-09 Thread Jaikiran Pai
Can I please get a review of this change which removes an incorrect entry from `ProblemList-Virtual.txt`? As noted in https://bugs.openjdk.org/browse/JDK-8335966 this entry is a left over which went unnoticed when we did the changes in https://bugs.openjdk.org/browse/JDK-8333130. The refactore

Integrated: 8334777: Test javax/management/remote/mandatory/notif/NotifReconnectDeadlockTest.java failed with NullPointerException

2024-07-09 Thread Kevin Walls
On Thu, 27 Jun 2024 15:53:09 GMT, Kevin Walls wrote: > Disable running this test with -Xcomp. > > The NPE seen in this test is due to a timeout establishing the connection. > ServerCommunicatorAdmin hits its timeout, during an addNotificationListener > call on a new connection. > > -Xcomp ca

Re: RFR: 8334777: Test javax/management/remote/mandatory/notif/NotifReconnectDeadlockTest.java failed with NullPointerException [v2]

2024-07-09 Thread Kevin Walls
On Fri, 28 Jun 2024 18:14:59 GMT, Kevin Walls wrote: >> Disable running this test with -Xcomp. >> >> The NPE seen in this test is due to a timeout establishing the connection. >> ServerCommunicatorAdmin hits its timeout, during an addNotificationListener >> call on a new connection. >> >> -X

Re: RFR: 8334777: Test javax/management/remote/mandatory/notif/NotifReconnectDeadlockTest.java failed with NullPointerException [v2]

2024-07-09 Thread David Holmes
On Fri, 28 Jun 2024 18:14:59 GMT, Kevin Walls wrote: >> Disable running this test with -Xcomp. >> >> The NPE seen in this test is due to a timeout establishing the connection. >> ServerCommunicatorAdmin hits its timeout, during an addNotificationListener >> call on a new connection. >> >> -X