Re: RFR: 8200559: Java agents doing instrumentation need a means to define auxiliary classes [v2]

2024-01-24 Thread Alexander Kriegisch
On Thu, 22 Apr 2021 21:50:45 GMT, Rafael Winterhalter wrote: >> Rafael Winterhalter has refreshed the contents of this pull request, and >> previous commits have been removed. Incremental views are not available. The >> pull request now contains one commit: >> >> 8200559: Java agents doing

Re: RFR: 8324582: Replace -Djava.util.concurrent.ForkJoinPool.common.parallelism to -Djdk.virtualThreadScheduler.maxPoolSize/parallelism in jvmti vthread tests [v3]

2024-01-24 Thread Alan Bateman
On Wed, 24 Jan 2024 21:01:37 GMT, Leonid Mesnik wrote: >> Some jvmti tests use >> -Djava.util.concurrent.ForkJoinPool.common.parallelism >> to control the pool of virtual threads. However, it is controlled by >> jdk.virtualThreadScheduler.parallelism property. >> >> The non-continuations impleme

Re: RFR: 8311846: Resolve duplicate 'Thread' related symbols with JDK static linking

2024-01-24 Thread Jiangli Zhou
On Wed, 24 Jan 2024 09:29:16 GMT, Andrew Haley wrote: > > > I think you should be able to use ld and objcopy to merge the .o files > > > and hide all of the symbols you don't want to export. > > > > > > We also discussed about `objcopy` in [#14808 > > (comment)](https://github.com/openjdk/jdk

Re: hprof 1.1

2024-01-24 Thread Chris Plummer
I filed a CR for this 3 years ago: https://bugs.openjdk.org/browse/JDK-8260478 Chris On 1/24/24 1:19 PM, Kirk Pepperdine wrote: Hi all, I was looking for a more recent version of the hprof documentation and it looks like the last version of that doc is with JDK 8. This doc acts as a spec fo

hprof 1.1

2024-01-24 Thread Kirk Pepperdine
Hi all, I was looking for a more recent version of the hprof documentation and it looks like the last version of that doc is with JDK 8. This doc acts as a spec for the file format for heap dumps (as well as the format for for execution and heap profiler output). Question, is this document an

Re: RFR: 8324582: Replace -Djava.util.concurrent.ForkJoinPool.common.parallelism to -Djdk.virtualThreadScheduler.maxPoolSize/parallelism in jvmti vthread tests [v3]

2024-01-24 Thread Leonid Mesnik
> Some jvmti tests use > -Djava.util.concurrent.ForkJoinPool.common.parallelism > to control the pool of virtual threads. However, it is controlled by > jdk.virtualThreadScheduler.parallelism property. > > The non-continuations implementation doesn't use any of these properties and > it was just

Re: RFR: 8324582: Replace -Djava.util.concurrent.ForkJoinPool.common.parallelism to -Djdk.virtualThreadScheduler.maxPoolSize/parallelism in jvmti vthread tests [v2]

2024-01-24 Thread Chris Plummer
On Wed, 24 Jan 2024 20:21:39 GMT, Leonid Mesnik wrote: >> Some jvmti tests use >> -Djava.util.concurrent.ForkJoinPool.common.parallelism >> to control the pool of virtual threads. However, it is controlled by >> jdk.virtualThreadScheduler.parallelism property. >> >> The non-continuations impleme

Re: RFR: 8324582: Replace -Djava.util.concurrent.ForkJoinPool.common.parallelism to -Djdk.virtualThreadScheduler.maxPoolSize/parallelism in jvmti vthread tests [v2]

2024-01-24 Thread Leonid Mesnik
> Some jvmti tests use > -Djava.util.concurrent.ForkJoinPool.common.parallelism > to control the pool of virtual threads. However, it is controlled by > jdk.virtualThreadScheduler.parallelism property. > > The non-continuations implementation doesn't use any of these properties and > it was just

Re: RFR: 8324582: Replace -Djava.util.concurrent.ForkJoinPool.common.parallelism to -Djdk.virtualThreadScheduler.parallelism in jvmti vthread tests

2024-01-24 Thread Chris Plummer
On Wed, 24 Jan 2024 02:42:29 GMT, Leonid Mesnik wrote: > Some jvmti tests use > -Djava.util.concurrent.ForkJoinPool.common.parallelism > to control the pool of virtual threads. However, it is controlled by > jdk.virtualThreadScheduler.parallelism property. > > The non-continuations implementatio

Re: RFR: 8324066: "clhsdb jstack" should not by default scan for j.u.c locks because it can be very slow [v2]

2024-01-24 Thread Chris Plummer
On Wed, 24 Jan 2024 10:15:52 GMT, Kevin Walls wrote: >> Chris Plummer has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - update clhsdb docs >> - update clhsdb docs > > test/hotspot/jtreg/serviceability/sa/ClhsdbJstackWithConcurrentLock.j

Re: RFR: 8324241: Always record evol_method deps to avoid excessive method flushing [v4]

2024-01-24 Thread Volker Simonis
> Currently we don't record dependencies on redefined methods (i.e. > `evol_method` dependencies) in JIT compiled methods if none of the > `can_redefine_classes`, `can_retransform_classes` or > `can_generate_breakpoint_events` JVMTI capabalities is set. This means that > if a JVMTI agent which

Re: RFR: 8324582: Replace -Djava.util.concurrent.ForkJoinPool.common.parallelism to -Djdk.virtualThreadScheduler.parallelism in jvmti vthread tests

2024-01-24 Thread Alan Bateman
On Wed, 24 Jan 2024 02:42:29 GMT, Leonid Mesnik wrote: > Some jvmti tests use > -Djava.util.concurrent.ForkJoinPool.common.parallelism > to control the pool of virtual threads. However, it is controlled by > jdk.virtualThreadScheduler.parallelism property. > > The non-continuations implementatio

Re: RFR: 8324066: "clhsdb jstack" should not by default scan for j.u.c locks because it can be very slow [v2]

2024-01-24 Thread Kevin Walls
On Thu, 18 Jan 2024 16:19:38 GMT, Chris Plummer wrote: >> I noticed that "clhsdb jstack" seemed to hang when I attached to process >> with a somewhat large heap. It had taken over 10 minutes when I finally >> decided to have a look at the SA process (using bin/jstack), which came up >> with th

Re: RFR: 8324066: "clhsdb jstack" should not by default scan for j.u.c locks because it can be very slow [v2]

2024-01-24 Thread Kevin Walls
On Thu, 18 Jan 2024 16:19:38 GMT, Chris Plummer wrote: >> I noticed that "clhsdb jstack" seemed to hang when I attached to process >> with a somewhat large heap. It had taken over 10 minutes when I finally >> decided to have a look at the SA process (using bin/jstack), which came up >> with th

Re: RFR: 8324241: Always record evol_method deps to avoid excessive method flushing [v2]

2024-01-24 Thread Volker Simonis
On Tue, 23 Jan 2024 23:36:37 GMT, Dean Long wrote: >> A good question, but after deep digging (it took me quite some time to >> figure this out myself :) I don't think that >> `can_hotswap_or_post_breakpoint`/`all_dependencies_are_recorded` can ever be >> reset. Here's how it works: >> >> - t

Integrated: 8324512: Serial: Remove Generation::Name

2024-01-24 Thread Albert Mingkun Yang
On Tue, 23 Jan 2024 10:20:46 GMT, Albert Mingkun Yang wrote: > Trivial removing redundant code. This pull request has now been integrated. Changeset: 1c1cb048 Author:Albert Mingkun Yang URL: https://git.openjdk.org/jdk/commit/1c1cb048cd7820042373f5d8a9f41fb30d9cef6e Stats: 72 li

Re: RFR: 8324512: Serial: Remove Generation::Name [v2]

2024-01-24 Thread Albert Mingkun Yang
On Tue, 23 Jan 2024 18:37:45 GMT, Albert Mingkun Yang wrote: >> Trivial removing redundant code. > > Albert Mingkun Yang has updated the pull request incrementally with one > additional commit since the last revision: > > year Thanks for review. - PR Comment: https://git.openjd

Re: RFR: 8311846: Resolve duplicate 'Thread' related symbols with JDK static linking

2024-01-24 Thread Andrew Haley
On Wed, 17 Jan 2024 00:14:58 GMT, Jiangli Zhou wrote: > Please review this PR with a simple solution for resolving duplicate `Thread` > symbol issue. In https://github.com/openjdk/jdk/pull/14808 comments, there > was an alternative suggestion to redefine the symbol at build time, such as > us