On Wed, 24 Jan 2024 10:15:52 GMT, Kevin Walls <kev...@openjdk.org> wrote:
>> Chris Plummer has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - update clhsdb docs >> - update clhsdb docs > > test/hotspot/jtreg/serviceability/sa/ClhsdbJstackWithConcurrentLock.java line > 73: > >> 71: } >> 72: } >> 73: if (addressString != null) > > Did we break already, is this if not needed? There are two nested loops. If we did not break out of the inner loop (which is scanning words in the given line), then addressString might still be null and we need to search the next line. If we don't do this check and break here, then we will always search the next line even if addressString was found. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/17479#discussion_r1465416304
