On Sat, 13 Jan 2024 02:21:37 GMT, Lei Zaakjyu wrote:
> see 'https://github.com/openjdk/jdk/pull/17398#pullrequestreview-1819022919'
This pull request has now been integrated.
Changeset: 922f8e44
Author:Lei Zaakjyu
Committer: David Holmes
URL:
https://git.openjdk.org/jdk/commit/922f
On Mon, 15 Jan 2024 04:28:15 GMT, Ioi Lam wrote:
>> Ugghh! So the help text is an actual stringification of the actual default
>> value of the "field", whereas in this case the real default value comes from
>> passing null to `CodeCache::write_perf_map`. So we need this hack to deal
>> with th
On Mon, 15 Jan 2024 05:37:02 GMT, Tom Rodriguez wrote:
>> The changes for JDK-8287061 didn't update the SA decoding logic and there
>> are other places where the decoding has gotten out of sync with HotSpot.
>> Some of them can't be tested because they are part of JVMCI but I've added a
>> di
> The changes for JDK-8287061 didn't update the SA decoding logic and there are
> other places where the decoding has gotten out of sync with HotSpot. Some of
> them can't be tested because they are part of JVMCI but I've added a directed
> test for the JDK-8287061 code and a more brute force t
On Fri, 12 Jan 2024 21:46:13 GMT, Vladimir Kozlov wrote:
>> Tom Rodriguez has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix problem list and correct jtreg arguments
>
> test/hotspot/jtreg/serviceability/sa/ClhsdbTestAllocationMerge.jav
On Sat, 13 Jan 2024 02:21:37 GMT, Lei Zaakjyu wrote:
> see 'https://github.com/openjdk/jdk/pull/17398#pullrequestreview-1819022919'
thanks for the review.
-
PR Comment: https://git.openjdk.org/jdk/pull/17412#issuecomment-1891307949
> The changes for JDK-8287061 didn't update the SA decoding logic and there are
> other places where the decoding has gotten out of sync with HotSpot. Some of
> them can't be tested because they are part of JVMCI but I've added a directed
> test for the JDK-8287061 code and a more brute force t
On Mon, 15 Jan 2024 01:29:47 GMT, David Holmes wrote:
>> The default value for the argument is what gets displayed in the help text.
>> For example:
>>
>>
>> ThreadDumpToFileDCmd::ThreadDumpToFileDCmd(outputStream* output, bool heap) :
>>DCmdWithPars
On Sat, 13 Jan 2024 02:21:37 GMT, Lei Zaakjyu wrote:
> see 'https://github.com/openjdk/jdk/pull/17398#pullrequestreview-1819022919'
Yes this could be considered trivial, but Reviewed anyway.
Thanks
-
Marked as reviewed by dholmes (Reviewer).
PR Review: https://git.openjdk.org/jdk
On Sun, 14 Jan 2024 01:26:25 GMT, Chris Plummer wrote:
>> I only expected to see a change to the help string, I don't understand why
>> the actual Dcmd is being modified here! ???
>
> The default value for the argument is what gets displayed in the help text.
> For example:
>
>
> ThreadDumpTo
On Sun, 14 Jan 2024 01:28:48 GMT, Chris Plummer wrote:
> > And I still think the VM.CDS change show have its own issue (if not PR).
>
> Yes, and I asked why that is the case. The VM.cds changes are very much
> related to the Compiler.perfmap changes. I think it's actually correct to do
> them
11 matches
Mail list logo
