On Sat, 13 Jan 2024 02:21:37 GMT, Lei Zaakjyu wrote:
> see 'https://github.com/openjdk/jdk/pull/17398#pullrequestreview-1819022919'
This patch seems trivial. I wonder if it needs two reviews.
-
PR Comment: https://git.openjdk.org/jdk/pull/17412#issuecomment-1890866200
On Sun, 14 Jan 2024 01:33:45 GMT, Lei Zaakjyu wrote:
>> follow up 8234502.
>
> Lei Zaakjyu has updated the pull request incrementally with one additional
> commit since the last revision:
>
> fix
Marked as reviewed by kbarrett (Reviewer).
-
PR Review: https://git.openjdk.org/jd
On Sat, 13 Jan 2024 02:21:37 GMT, Lei Zaakjyu wrote:
> see 'https://github.com/openjdk/jdk/pull/17398#pullrequestreview-1819022919'
Looks good.
-
Marked as reviewed by cjplummer (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/17412#pullrequestreview-1820135652
> follow up 8234502.
Lei Zaakjyu has updated the pull request incrementally with one additional
commit since the last revision:
fix
-
Changes:
- all: https://git.openjdk.org/jdk/pull/17398/files
- new: https://git.openjdk.org/jdk/pull/17398/files/ed54e312..c0e47a0c
Webrevs:
On Sun, 14 Jan 2024 01:03:14 GMT, David Holmes wrote:
>> src/hotspot/share/services/diagnosticCommand.cpp line 866:
>>
>>> 864: const char* filename = _filename.value();
>>> 865: if (strncmp(filename, DEFAULT_PERFMAP_FILENAME,
>>> strlen(DEFAULT_PERFMAP_FILENAME)) == 0) {
>>> 866: fil
On Sun, 14 Jan 2024 01:05:52 GMT, David Holmes wrote:
> And I still think the VM.CDS change show have its own issue (if not PR).
Yes, and I asked why that is the case. The VM.cds changes are very much related
to the Compiler.perfmap changes. I think it's actually correct to do them
together, n
On Fri, 12 Jan 2024 10:27:53 GMT, Serguei Spitsyn wrote:
>> Chris Plummer has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix default filename issue
>
> src/hotspot/share/services/diagnosticCommand.cpp line 866:
>
>> 864: const char*
On Fri, 12 Jan 2024 02:07:47 GMT, Chris Plummer wrote:
>> The jcmd docs for Compiler.perfmap currently say:
>>
>> - *filename*: (Optional) The name of the map file (STRING, no default
>> value)
>>
>> However, there is a default, so not only should that be made more clear in
>> the above,
On Fri, 12 Jan 2024 15:26:34 GMT, Lei Zaakjyu wrote:
>> follow up 8234502.
>
> Lei Zaakjyu has updated the pull request incrementally with one additional
> commit since the last revision:
>
> fix
Changes requested by kbarrett (Reviewer).
src/hotspot/share/gc/serial/serialHeap.cpp line 105:
