Reviewed-by: Yi Yang
-
Commit messages:
- 8323640: [TESTBUG]testMemoryFailCount in
jdk/internal/platform/docker/TestDockerMemoryMetrics.java always fail because
OOM killed
Changes: https://git.openjdk.org/jdk/pull/17386/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=17386
On Fri, 12 Jan 2024 00:47:20 GMT, Serguei Spitsyn wrote:
> Hi all,
>
> This pull request contains a clean backport of commit
> [2806adee](https://github.com/openjdk/jdk/commit/2806adee2d8cca6bc215f285888631799bd02eac)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> The c
On Thu, 11 Jan 2024 22:11:00 GMT, Chris Plummer wrote:
>> The jcmd docs for Compiler.perfmap currently say:
>>
>> - *filename*: (Optional) The name of the map file (STRING, no default
>> value)
>>
>> However, there is a default, so not only should that be made more clear in
>> the above,
> The jcmd docs for Compiler.perfmap currently say:
>
> - *filename*: (Optional) The name of the map file (STRING, no default
> value)
>
> However, there is a default, so not only should that be made more clear in
> the above, but also some descriptive text as to how the default is generate
Hi all,
This pull request contains a clean backport of commit
[2806adee](https://github.com/openjdk/jdk/commit/2806adee2d8cca6bc215f285888631799bd02eac)
from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
The commit being backported was authored by Serguei Spitsyn on 10 Jan
On Thu, 11 Jan 2024 22:11:00 GMT, Chris Plummer wrote:
>> The jcmd docs for Compiler.perfmap currently say:
>>
>> - *filename*: (Optional) The name of the map file (STRING, no default
>> value)
>>
>> However, there is a default, so not only should that be made more clear in
>> the above,
> The jcmd docs for Compiler.perfmap currently say:
>
> - *filename*: (Optional) The name of the map file (STRING, no default
> value)
>
> However, there is a default, so not only should that be made more clear in
> the above, but also some descriptive text as to how the default is generate
On Thu, 11 Jan 2024 00:59:08 GMT, Alex Menkov wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [dd8ae616](https://github.com/openjdk/jdk/commit/dd8ae616437398f957f9b4f09cf2c7f1d0bd0938)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> The commit bein
On Wed, 10 Jan 2024 14:02:25 GMT, Daniel Fuchs wrote:
>> Kevin Walls has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove unnecessary MLET_ Properties
>
> test/jdk/javax/management/mxbean/MXBeanLoadingTest1.java line 85:
>
>> 83:
On Thu, 11 Jan 2024 12:23:37 GMT, Daniel Fuchs wrote:
>> Hi Daniel -
>> I am missing see how being a ClassLoader relates to the leak where the
>> Introspector holds on to a reference to the most recent MBean. I didn't
>> locate the jdk5 change, I only read a short synopsis.
>>
>> I can make t
> Remove the MLet feature and its tests.
>
> Some tests use MLet classes but are not testing MLets. These are updated, to
> use another test MBean or an MBean which is a URLClassLoader, e.g.
> test/jdk/javax/management/MBeanServer/PostExceptionTest.java
> test/jdk/javax/management/remote/mandato
On Thu, 11 Jan 2024 16:14:39 GMT, Joachim Kern wrote:
>> In parseAllowedMask in socketTransport.c, prefixLen of mask is compared with
>> a maxValue (32 for IPv4, 128 otherwise). This fails if it is larger than
>> 32, because getaddrinfo seems to detect IPv4 family, if IPv6 address has set
>>
On Mon, 8 Jan 2024 20:16:50 GMT, Chris Plummer wrote:
> Fix some broken links and other minor cleanups:
>
> There are a few broken links in the javadoc for ObjectReference.java. For
> example:
>
>
> * Not all target VMs support this operation. See
> * VirtualMachine#canGetMonitorIn
On Mon, 8 Jan 2024 20:16:50 GMT, Chris Plummer wrote:
> Fix some broken links and other minor cleanups:
>
> There are a few broken links in the javadoc for ObjectReference.java. For
> example:
>
>
> * Not all target VMs support this operation. See
> * VirtualMachine#canGetMonitorIn
> The jcmd docs for Compiler.perfmap currently say:
>
> - *filename*: (Optional) The name of the map file (STRING, no default
> value)
>
> However, there is a default, so not only should that be made more clear in
> the above, but also some descriptive text as to how the default is generate
> In parseAllowedMask in socketTransport.c, prefixLen of mask is compared with
> a maxValue (32 for IPv4, 128 otherwise). This fails if it is larger than 32,
> because getaddrinfo seems to detect IPv4 family, if IPv6 address has set only
> some of the last 32 Bits. So we take the wrong maxValue
On Thu, 11 Jan 2024 16:00:45 GMT, Matthias Baesken wrote:
>> Joachim Kern has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> cosmetic changes
>
> src/jdk.jdwp.agent/share/native/libdt_socket/socketTransport.c line 428:
>
>> 426: co
On Thu, 11 Jan 2024 15:46:59 GMT, Joachim Kern wrote:
> In parseAllowedMask in socketTransport.c, prefixLen of mask is compared with
> a maxValue (32 for IPv4, 128 otherwise). This fails if it is larger than 32,
> because getaddrinfo seems to detect IPv4 family, if IPv6 address has set only
>
In parseAllowedMask in socketTransport.c, prefixLen of mask is compared with a
maxValue (32 for IPv4, 128 otherwise). This fails if it is larger than 32,
because getaddrinfo seems to detect IPv4 family, if IPv6 address has set only
some of the last 32 Bits. So we take the wrong maxValue.
-
> Compiler Control (https://openjdk.org/jeps/165) provides method-context
> dependent control of the JVM compilers (C1 and C2). The active directive
> stack is built from the directive files passed with the
> `-XX:CompilerDirectivesFile` diagnostic command-line option and the
> Compiler.add_dir
On Wed, 10 Jan 2024 22:34:57 GMT, Alex Menkov wrote:
>> FieldStream/FilteredFieldStream classes from reflectionUtils.hpp iterate
>> class fields in the reverse order and use field indexes to access instead of
>> forward iteration. This is performance ineffective (see
>> [JDK-8317692](https://b
On Fri, 1 Dec 2023 11:33:46 GMT, Joachim Kern wrote:
> On AIX, repeated calls to dlopen referring to the same shared library may
> result in different, unique dl handles to be returned from libc. In that it
> differs from typical libc implementations that cache dl handles.
>
> This causes prob
On Wed, 10 Jan 2024 21:40:08 GMT, Chris Plummer wrote:
> The jcmd docs for Compiler.perfmap currently say:
>
> - *filename*: (Optional) The name of the map file (STRING, no default
> value)
>
> However, there is a default, so not only should that be made more clear in
> the above, but als
On Thu, 11 Jan 2024 00:59:08 GMT, Alex Menkov wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [dd8ae616](https://github.com/openjdk/jdk/commit/dd8ae616437398f957f9b4f09cf2c7f1d0bd0938)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> The commit bein
On Thu, 11 Jan 2024 11:31:07 GMT, Kevin Walls wrote:
>> Yes, that's the whole point of the test. Without using an MBean which is a
>> ClassLoader the fix cannot be tested.
>> 1. you need to create an MBean which is an URLClassLoader, and it needs to
>> be a PrivateClassLoader so that it's not a
On Wed, 10 Jan 2024 17:06:01 GMT, Daniel Fuchs wrote:
>> Checking on the original problem noted in the test, looks like it wasn't
>> really about ClassLoaders and MLets:
>> JDK-4909536: Standard MBean introspector keeps reference to last class
>> introspected
>> This is what the test still test
26 matches
Mail list logo
