On Thu, 11 Jan 2024 15:46:59 GMT, Joachim Kern <jk...@openjdk.org> wrote:
> In parseAllowedMask in socketTransport.c, prefixLen of mask is compared with > a maxValue (32 for IPv4, 128 otherwise). This fails if it is larger than 32, > because getaddrinfo seems to detect IPv4 family, if IPv6 address has set only > some of the last 32 Bits. So we take the wrong maxValue. src/jdk.jdwp.agent/share/native/libdt_socket/socketTransport.c line 428: > 426: convertIPv4ToIPv6(&sa, &addr6); > 427: *isIPv4 = 1; > 428: } else Better use braces here too in the `else` part. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/17374#discussion_r1449073666
