Hi,
I wanted to know what I can do to move
https://github.com/openjdk/jdk/pull/13276 along.
There was advice to create a CSR request, in order to do that there needs
to be a jira
but I don't think I have permissions to create one.
Thanks for all the reviews, let me know what I can do, happy to fol
On Fri, 17 Nov 2023 05:37:46 GMT, Serguei Spitsyn wrote:
>> The handshakes support for virtual threads is needed to simplify the JVMTI
>> implementation for virtual threads. There is a significant duplication in
>> the JVMTI code to differentiate code intended to support platform, virtual
>> t
On Fri, 17 Nov 2023 05:37:46 GMT, Serguei Spitsyn wrote:
>> The handshakes support for virtual threads is needed to simplify the JVMTI
>> implementation for virtual threads. There is a significant duplication in
>> the JVMTI code to differentiate code intended to support platform, virtual
>> t
On Fri, 17 Nov 2023 22:53:58 GMT, Coleen Phillimore wrote:
>> Please, review this fix for a corner case handling of `jmethodID` values.
>>
>> The issue is related to the interplay between `jmethodID` values and method
>> redefinitions. Each `jmethodID` value is effectively a pointer to a `Metho
On Tue, 14 Nov 2023 17:56:09 GMT, Jaroslav Bachorik
wrote:
> Please, review this fix for a corner case handling of `jmethodID` values.
>
> The issue is related to the interplay between `jmethodID` values and method
> redefinitions. Each `jmethodID` value is effectively a pointer to a `Method`
On Thu, 21 Sep 2023 20:43:56 GMT, Yi-Fan Tsai wrote:
> `jcmd Compiler.perfmap` uses the hard-coded file name for a perf map:
> `/tmp/perf-%d.map`. This change adds an option for specifying a file name.
>
> The help message of Compiler.perfmap:
>
> Compiler.perfmap
> Write map file for Linux pe
On Fri, 17 Nov 2023 20:29:11 GMT, Serguei Spitsyn wrote:
>> This is a fix of a performance/scalability related issue. The
>> `JvmtiThreadState` objects for virtual thread filtered events enabled
>> globally are created eagerly because it is needed when the
>> `interp_only_mode` is enabled. Oth
On Fri, 17 Nov 2023 18:52:20 GMT, Chris Plummer wrote:
>> The `tlh` is used to protect any existing at this point JavaThread's from
>> being terminated while it is set.
>> My understanding is that there is no need to iterate over all threads in the
>> list to get this protection.
>
> Ok. A comm
> This is a fix of a performance/scalability related issue. The
> `JvmtiThreadState` objects for virtual thread filtered events enabled
> globally are created eagerly because it is needed when the `interp_only_mode`
> is enabled. Otherwise, some events which are generated in `interp_only_mode`
On Fri, 17 Nov 2023 07:23:46 GMT, Serguei Spitsyn wrote:
>> I see the PR comment, but I don't really understand it. Is this to force
>> some sort of early initialization to avoid a race later on? It just seems
>> odd to create the tlh, but never use it.
>
> The `tlh` is used to protect any exis
On Fri, 17 Nov 2023 13:20:22 GMT, Afshin Zafari wrote:
>> @kimbarrett , @dholmes-ora , @merykitty
>> Is there any comment on this PR?
>
>> @afshin-zafari I will leave it to other to (re-) review the latest changes.
>> I don't grok this template stuff enough to pass judgement.
>
> Thank you ver
On Thu, 16 Nov 2023 06:46:48 GMT, Quan Anh Mai wrote:
>> Afshin Zafari has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> function pointer is replaced with template Functor.
>
> src/hotspot/share/utilities/growableArray.hpp line 213:
>
>>
On Wed, 15 Nov 2023 09:38:25 GMT, Afshin Zafari wrote:
>>> I still approve of this patch as it's better than what we had before. There
>>> are a lot of suggested improvements that can be done either in this PR or
>>> in a future RFE. `git blame` shows that this hasn't been touched since
>>> 20
> This is an update for a performance/scalability enhancement.
>
> The `JvmtiVTMSTransitionDisabler`sync protocol is on a performance critical
> path of the virtual threads mount state transitions (VTMS transitions). It
> has a noticeable performance overhead (about 10%) which contributes to the
On Mon, 13 Nov 2023 10:11:26 GMT, Long Yang wrote:
>> I would like to fix this.
>>
>> Create 4096 threads, and the stack depth of each thread is 256.
>> After running jmx.dumpAllThreads(true, true), the RSS reaches 5.3GiB.
>> After optimization, the RSS is 250MiB.
>>
>> I would appreciate it
On Fri, 10 Nov 2023 09:13:06 GMT, Long Yang wrote:
> I would like to fix this.
>
> Create 4096 threads, and the stack depth of each thread is 256.
> After running jmx.dumpAllThreads(true, true), the RSS reaches 5.3GiB.
> After optimization, the RSS is 250MiB.
>
> I would appreciate it if anyo
On Mon, 13 Nov 2023 10:11:26 GMT, Long Yang wrote:
>> I would like to fix this.
>>
>> Create 4096 threads, and the stack depth of each thread is 256.
>> After running jmx.dumpAllThreads(true, true), the RSS reaches 5.3GiB.
>> After optimization, the RSS is 250MiB.
>>
>> I would appreciate it
On Mon, 13 Nov 2023 02:01:09 GMT, David Holmes wrote:
>> Long Yang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> move ResourceMark to before start_vf
>
> src/hotspot/share/services/threadService.cpp line 698:
>
>> 696:
18 matches
Mail list logo
