Re: RFR: 8315149: Add hsperf counters for CPU time of internal GC threads [v41]

2023-11-10 Thread Jonathan Joo
On Sat, 11 Nov 2023 00:23:28 GMT, Jonathan Joo wrote: >> 8315149: Add hsperf counters for CPU time of internal GC threads > > Jonathan Joo has updated the pull request incrementally with two additional > commits since the last revision: > > - Refactor ConcurrentRefine logic > - Make CPUTimeCo

Re: RFR: 8315149: Add hsperf counters for CPU time of internal GC threads [v40]

2023-11-10 Thread Jonathan Joo
On Thu, 9 Nov 2023 10:29:29 GMT, Stefan Johansson wrote: >> Jonathan Joo has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Add missing cpuTimeCounters files > > src/hotspot/share/gc/g1/g1ConcurrentRefineThread.cpp line 189: > >> 187: void

Re: RFR: 8315149: Add hsperf counters for CPU time of internal GC threads [v41]

2023-11-10 Thread Jonathan Joo
> 8315149: Add hsperf counters for CPU time of internal GC threads Jonathan Joo has updated the pull request incrementally with two additional commits since the last revision: - Refactor ConcurrentRefine logic - Make CPUTimeCounters a singleton class - Changes: - all: https://g

Integrated: 8318895: Deoptimization results in incorrect lightweight locking stack

2023-11-10 Thread Roman Kennke
On Wed, 8 Nov 2023 19:00:53 GMT, Roman Kennke wrote: > See JBS issue for details. > > I basically: > - took the test-modification and turned it into its own test-case > - added test runners for lightweight- and legacy-locking, so that we keep > testing both, no matter what is the default > -

Re: RFR: 8318895: Deoptimization results in incorrect lightweight locking stack [v3]

2023-11-10 Thread Roman Kennke
On Fri, 10 Nov 2023 10:41:16 GMT, Roman Kennke wrote: >> See JBS issue for details. >> >> I basically: >> - took the test-modification and turned it into its own test-case >> - added test runners for lightweight- and legacy-locking, so that we keep >> testing both, no matter what is the defau

Re: RFR: JDK-8319375: test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/RedefineLeakThrowable.java runs into OutOfMemoryError: Metaspace on AIX [v2]

2023-11-10 Thread Matthias Baesken
> On AIX the test > test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/RedefineLeakThrowable.java > runs into this error: > > java.lang.RuntimeException: java.lang.OutOfMemoryError: Metaspace > at > jdk.compiler/com.sun.tools.javac.api.JavacTaskImpl.invocationHelper(JavacTaskImpl.java:168)

Re: RFR: 8318706: Implement JEP 423: Region Pinning for G1 [v17]

2023-11-10 Thread Thomas Schatzl
> The JEP covers the idea very well, so I'm only covering some implementation > details here: > > * regions get a "pin count" (reference count). As long as it is non-zero, we > conservatively never reclaim that region even if there is no reference in > there. JNI code might have references to i

Re: RFR: 8318706: Implement JEP 423: Region Pinning for G1 [v16]

2023-11-10 Thread Thomas Schatzl
On Thu, 9 Nov 2023 13:26:06 GMT, Stefan Johansson wrote: >> Thomas Schatzl has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Modify evacuation failure log message as suggested by sjohanss: Use >> "Evacuation Failure" with a cause descript

Re: RFR: 8318706: Implement JEP 423: Region Pinning for G1 [v16]

2023-11-10 Thread Stefan Johansson
On Thu, 9 Nov 2023 10:44:29 GMT, Thomas Schatzl wrote: >> The JEP covers the idea very well, so I'm only covering some implementation >> details here: >> >> * regions get a "pin count" (reference count). As long as it is non-zero, we >> conservatively never reclaim that region even if there is

Re: RFR: JDK-8318636: Add jcmd to print annotated process memory map [v12]

2023-11-10 Thread Thomas Stuefe
On Fri, 10 Nov 2023 09:45:11 GMT, Johan Sjölen wrote: > Hi Thomas, > > Thanks for your hard work on this! LGTM. Thank you for your Review, Johan! - PR Comment: https://git.openjdk.org/jdk/pull/16301#issuecomment-1805489022

Re: RFR: JDK-8319375: test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/RedefineLeakThrowable.java runs into OutOfMemoryError: Metaspace on AIX

2023-11-10 Thread Matthias Baesken
On Fri, 10 Nov 2023 05:44:55 GMT, David Holmes wrote: > I just want it confirmed that the proposed test changes will exhibit a leak > on all platforms on an unpatched VM. If that can't be ascertained then it may > be better to only change for AIX. On my SUSE Linux x86_64 test box, with the lea

Re: RFR: 8318895: Deoptimization results in incorrect lightweight locking stack [v3]

2023-11-10 Thread Roman Kennke
> See JBS issue for details. > > I basically: > - took the test-modification and turned it into its own test-case > - added test runners for lightweight- and legacy-locking, so that we keep > testing both, no matter what is the default > - added Axels fix (mentioned in the JBS issue) with the

Re: RFR: JDK-8318636: Add jcmd to print annotated process memory map [v12]

2023-11-10 Thread Johan Sjölen
On Fri, 10 Nov 2023 07:38:24 GMT, Thomas Stuefe wrote: >> Analysts and supporters often use /proc/xx/maps to make sense of the memory >> footprint of a process. >> >> Interpreting the memory map correctly can help when used as a complement to >> other tools (e.g. NMT). There even exist tools o