Re: RFR: JDK-8318636: Add jcmd to print annotated process memory map [v4]

2023-10-27 Thread Thomas Stuefe
On Fri, 27 Oct 2023 17:29:23 GMT, Gerard Ziemski wrote: > I really like this feature, hope the other platforms can be done as well. (I > am also really looking forward to seeing how you did the "malloc" version) > > I think we should set the user expectations correctly and say somewhere that >

Re: RFR: JDK-8318626: GetClassFields does not filter out ConstantPool.constantPoolOop field

2023-10-27 Thread Serguei Spitsyn
On Tue, 24 Oct 2023 00:46:54 GMT, Alex Menkov wrote: > FilteredFieldStream is intended to filter out some fields which does not > represent valid java objects. > Currently the only filtered field is "constantPoolOop" from > jdk.internal.reflect.ConstantPool class. > The change fixes FilteredFie

Re: RFR: 8318410: [TESTBUG] jdk/java/lang/instrument/BootClassPath/BootClassPathTest.sh fails on Japanese Windows [v2]

2023-10-27 Thread Serguei Spitsyn
On Mon, 23 Oct 2023 00:00:47 GMT, Kimura Yukihiro wrote: > Hi Serguei, > > Thank you for your quick reply. Could you please sponsor the fix? > > Thanks, Kimura Yukihiro I was hoping to have one more reviewer of your fix. But it seems there is nobody else to review it. Sponsored now. -

Re: RFR: JDK-8318636: Add jcmd to print annotated process memory map [v4]

2023-10-27 Thread Gerard Ziemski
On Fri, 27 Oct 2023 12:28:51 GMT, Thomas Stuefe wrote: >> Analysts and supporters often use /proc/xx/maps to make sense of the memory >> footprint of a process. >> >> Interpreting the memory map correctly can help when used as a complement to >> other tools (e.g. NMT). There even exist tools o

Re: RFR: JDK-8318636: Add jcmd to print annotated process memory map [v4]

2023-10-27 Thread Gerard Ziemski
On Fri, 27 Oct 2023 12:28:51 GMT, Thomas Stuefe wrote: >> Analysts and supporters often use /proc/xx/maps to make sense of the memory >> footprint of a process. >> >> Interpreting the memory map correctly can help when used as a complement to >> other tools (e.g. NMT). There even exist tools o

Re: RFR: JDK-8318957: enhance agentlib:jdwp help output by info about allow option

2023-10-27 Thread Chris Plummer
On Fri, 27 Oct 2023 08:19:13 GMT, Matthias Baesken wrote: > The allow option of agentlib:jdwp has been introduced a long time ago (see > JDK-8061228) and is documented here : > https://docs.oracle.com/en/java/javase/17/docs/specs/jpda/conninv.html#oracle-vm-invocation-options > However it is sti

Re: RFR: JDK-8318636: Add jcmd to print annotated process memory map [v4]

2023-10-27 Thread Gerard Ziemski
On Fri, 27 Oct 2023 12:28:51 GMT, Thomas Stuefe wrote: >> Analysts and supporters often use /proc/xx/maps to make sense of the memory >> footprint of a process. >> >> Interpreting the memory map correctly can help when used as a complement to >> other tools (e.g. NMT). There even exist tools o

Re: RFR: 8315149: Add hsperf counters for CPU time of internal GC threads [v33]

2023-10-27 Thread Albert Mingkun Yang
On Thu, 26 Oct 2023 21:01:53 GMT, Jonathan Joo wrote: >> 8315149: Add hsperf counters for CPU time of internal GC threads > > Jonathan Joo has updated the pull request incrementally with one additional > commit since the last revision: > > Remove StringDedup from GC thread list > For tools l

Re: RFR: JDK-8318636: Add jcmd to print annotated process memory map [v3]

2023-10-27 Thread Thomas Stuefe
On Fri, 27 Oct 2023 09:42:19 GMT, Johan Sjölen wrote: >> Thomas Stuefe has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains four commits: >> >> - Merge master and solve merge conflicts >> - small fixes >> - start from VM op; show mo

Re: RFR: JDK-8318636: Add jcmd to print annotated process memory map [v4]

2023-10-27 Thread Thomas Stuefe
> Analysts and supporters often use /proc/xx/maps to make sense of the memory > footprint of a process. > > Interpreting the memory map correctly can help when used as a complement to > other tools (e.g. NMT). There even exist tools out there that attempt to > annotate the process memory map wi

Re: RFR: JDK-8318636: Add jcmd to print annotated process memory map [v3]

2023-10-27 Thread Thomas Stuefe
On Fri, 27 Oct 2023 09:41:28 GMT, Johan Sjölen wrote: >> Thomas Stuefe has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains four commits: >> >> - Merge master and solve merge conflicts >> - small fixes >> - start from VM op; show mo

Re: RFR: JDK-8318636: Add jcmd to print annotated process memory map [v3]

2023-10-27 Thread Thomas Stuefe
On Fri, 27 Oct 2023 09:37:19 GMT, Johan Sjölen wrote: >> Thomas Stuefe has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains four commits: >> >> - Merge master and solve merge conflicts >> - small fixes >> - start from VM op; show mo

Re: RFR: JDK-8318636: Add jcmd to print annotated process memory map [v3]

2023-10-27 Thread Thomas Stuefe
On Fri, 27 Oct 2023 09:32:35 GMT, Johan Sjölen wrote: >> Thomas Stuefe has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains four commits: >> >> - Merge master and solve merge conflicts >> - small fixes >> - start from VM op; show mo

Re: RFR: JDK-8318636: Add jcmd to print annotated process memory map [v3]

2023-10-27 Thread Thomas Stuefe
On Fri, 27 Oct 2023 08:38:02 GMT, Johan Sjölen wrote: >> Thomas Stuefe has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains four commits: >> >> - Merge master and solve merge conflicts >> - small fixes >> - start from VM op; show mo

Integrated: 8318964: Fix build failures caused by 8315097

2023-10-27 Thread Leo Korinth
On Fri, 27 Oct 2023 09:48:00 GMT, Leo Korinth wrote: > Update method name after huge renaming conflict This pull request has now been integrated. Changeset: b9dcd4b7 Author:Leo Korinth URL: https://git.openjdk.org/jdk/commit/b9dcd4b74138dd77faa46525f101b985248fffc5 Stats: 5 line

Re: Integrated: 8318964: Fix build failures caused by 8315097

2023-10-27 Thread Leo Korinth
On Fri, 27 Oct 2023 09:48:00 GMT, Leo Korinth wrote: > Update method name after huge renaming conflict Thanks!!! - PR Comment: https://git.openjdk.org/jdk/pull/16395#issuecomment-1782627439

Re: Integrated: 8318964: Fix build failures caused by 8315097

2023-10-27 Thread Roberto Castañeda Lozano
On Fri, 27 Oct 2023 09:48:00 GMT, Leo Korinth wrote: > Update method name after huge renaming conflict Looks good and trivial. - Marked as reviewed by rcastanedalo (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/16395#pullrequestreview-1701407759

Re: Integrated: 8318964: Fix build failures caused by 8315097

2023-10-27 Thread Axel Boldt-Christmas
On Fri, 27 Oct 2023 09:48:00 GMT, Leo Korinth wrote: > Update method name after huge renaming conflict Marked as reviewed by aboldtch (Reviewer). Trivial fix. - PR Review: https://git.openjdk.org/jdk/pull/16395#pullrequestreview-1701406738 PR Comment: https://git.openjdk.org/jdk/p

Integrated: 8318964: Fix build failures caused by 8315097

2023-10-27 Thread Leo Korinth
Update method name after huge renaming conflict - Commit messages: - 8318964: Fix build failures caused by 8315097 Changes: https://git.openjdk.org/jdk/pull/16395/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=16395&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8318

Re: RFR: JDK-8318636: Add jcmd to print annotated process memory map [v3]

2023-10-27 Thread Johan Sjölen
On Thu, 26 Oct 2023 15:02:53 GMT, Thomas Stuefe wrote: >> Analysts and supporters often use /proc/xx/maps to make sense of the memory >> footprint of a process. >> >> Interpreting the memory map correctly can help when used as a complement to >> other tools (e.g. NMT). There even exist tools o

Re: RFR: 8315097: Rename createJavaProcessBuilder [v7]

2023-10-27 Thread Leo Korinth
On Wed, 25 Oct 2023 08:44:29 GMT, Leo Korinth wrote: >> This pull request renames `createJavaProcessBuilder` to >> `createLimitedTestJavaProcessBuilder` and renames `createTestJvm` to >> `createTestJavaProcessBuilder`. Both are implemented through a private >> `createJavaProcessBuilder`. It al

Integrated: 8315097: Rename createJavaProcessBuilder

2023-10-27 Thread Leo Korinth
On Mon, 28 Aug 2023 15:54:08 GMT, Leo Korinth wrote: > This pull request renames `createJavaProcessBuilder` to > `createLimitedTestJavaProcessBuilder` and renames `createTestJvm` to > `createTestJavaProcessBuilder`. Both are implemented through a private > `createJavaProcessBuilder`. It also u

RFR: JDK-8318957: enhance agentlib:jdwp help output by info about allow option

2023-10-27 Thread Matthias Baesken
The allow option of agentlib:jdwp has been introduced a long time ago (see JDK-8061228) and is documented here : https://docs.oracle.com/en/java/javase/17/docs/specs/jpda/conninv.html#oracle-vm-invocation-options However it is still missing in the agentlib:jdwp help output and should be added the