On Thu, 26 Oct 2023 21:01:53 GMT, Jonathan Joo wrote:
>> 8315149: Add hsperf counters for CPU time of internal GC threads
>
> Jonathan Joo has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Remove StringDedup from GC thread list
> `os::elapse
On Thu, 26 Oct 2023 20:33:31 GMT, Man Cao wrote:
>> @albertnetymk, the hsperf counters are a non-public API and the new counters
>> have been added to the non-standard `sun.threads.cpu_time` name space which
>> is "[unstable and
>> unsupported](https://github.com/openjdk/jdk/blob/9864951dceb0d
On Thu, 26 Oct 2023 21:01:53 GMT, Jonathan Joo wrote:
>> 8315149: Add hsperf counters for CPU time of internal GC threads
>
> Jonathan Joo has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Remove StringDedup from GC thread list
Marked as rev
> 8315149: Add hsperf counters for CPU time of internal GC threads
Jonathan Joo has updated the pull request incrementally with one additional
commit since the last revision:
Remove StringDedup from GC thread list
-
Changes:
- all: https://git.openjdk.org/jdk/pull/15082/files
On Thu, 26 Oct 2023 14:31:23 GMT, Volker Simonis wrote:
>> src/hotspot/share/gc/g1/g1ConcurrentMarkThread.cpp line 138:
>>
>>> 136: _vtime_accum = (os::elapsedVTime() - _vtime_start);
>>> 137:
>>> 138: cm()->update_concurrent_mark_threads_cpu_time();
>>
>> Is there some overlapping btw
On Thu, 26 Oct 2023 07:51:56 GMT, Johannes Bechberger
wrote:
>> Fix race condition in debugger port selection, introduced with
>> [JDK-8317920](https://bugs.openjdk.org/browse/JDK-8317920).
>>
>> Tested on my Mac M1, but it doesn't contain platform-dependent code.
>
> Johannes Bechberger has u
On Thu, 26 Oct 2023 07:51:56 GMT, Johannes Bechberger
wrote:
>> Fix race condition in debugger port selection, introduced with
>> [JDK-8317920](https://bugs.openjdk.org/browse/JDK-8317920).
>>
>> Tested on my Mac M1, but it doesn't contain platform-dependent code.
>
> Johannes Bechberger has u
On Wed, 25 Oct 2023 08:44:29 GMT, Leo Korinth wrote:
>> This pull request renames `createJavaProcessBuilder` to
>> `createLimitedTestJavaProcessBuilder` and renames `createTestJvm` to
>> `createTestJavaProcessBuilder`. Both are implemented through a private
>> `createJavaProcessBuilder`. It al
> When using 'MemStat' CompileCommand, we accidentally register the command if
> an invalid suboption had been specified. Fixed, added regression test
> (verified).
Thomas Stuefe has updated the pull request incrementally with one additional
commit since the last revision:
Fix Windows build
On Wed, 25 Oct 2023 08:44:29 GMT, Leo Korinth wrote:
>> This pull request renames `createJavaProcessBuilder` to
>> `createLimitedTestJavaProcessBuilder` and renames `createTestJvm` to
>> `createTestJavaProcessBuilder`. Both are implemented through a private
>> `createJavaProcessBuilder`. It al
> Analysts and supporters often use /proc/xx/maps to make sense of the memory
> footprint of a process.
>
> Interpreting the memory map correctly can help when used as a complement to
> other tools (e.g. NMT). There even exist tools out there that attempt to
> annotate the process memory map wi
> Analysts and supporters often use /proc/xx/maps to make sense of the memory
> footprint of a process.
>
> Interpreting the memory map correctly can help when used as a complement to
> other tools (e.g. NMT). There even exist tools out there that attempt to
> annotate the process memory map wi
On Thu, 26 Oct 2023 12:49:21 GMT, Albert Mingkun Yang wrote:
>> Jonathan Joo has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Use 64-bit atomic add for incrementing counters
>
> src/hotspot/share/gc/g1/g1ConcurrentMarkThread.cpp line 138:
On Thu, 19 Oct 2023 20:06:50 GMT, Johan Sjölen wrote:
> I think that NMT is deserving of its own subdirectory. Can we do a review of
> the changes before I fix the merge conflicts?
>
> 1. Moved all the nmt source code from services/ to nmt/
> 2. Renamed all the include statements and sorted the
On Thu, 26 Oct 2023 09:51:15 GMT, Johan Sjölen wrote:
>> I think that NMT is deserving of its own subdirectory. Can we do a review of
>> the changes before I fix the merge conflicts?
>>
>> 1. Moved all the nmt source code from services/ to nmt/
>> 2. Renamed all the include statements and sorte
On Wed, 25 Oct 2023 20:37:46 GMT, Jonathan Joo wrote:
>> 8315149: Add hsperf counters for CPU time of internal GC threads
>
> Jonathan Joo has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Use 64-bit atomic add for incrementing counters
src/
On Wed, 25 Oct 2023 20:37:46 GMT, Jonathan Joo wrote:
>> 8315149: Add hsperf counters for CPU time of internal GC threads
>
> Jonathan Joo has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Use 64-bit atomic add for incrementing counters
Than
On Thu, 26 Oct 2023 09:51:15 GMT, Johan Sjölen wrote:
>> I think that NMT is deserving of its own subdirectory. Can we do a review of
>> the changes before I fix the merge conflicts?
>>
>> 1. Moved all the nmt source code from services/ to nmt/
>> 2. Renamed all the include statements and sorte
On Tue, 24 Oct 2023 11:51:45 GMT, Johan Sjölen wrote:
>> I think that NMT is deserving of its own subdirectory. Can we do a review of
>> the changes before I fix the merge conflicts?
>>
>> 1. Moved all the nmt source code from services/ to nmt/
>> 2. Renamed all the include statements and sorte
> I think that NMT is deserving of its own subdirectory. Can we do a review of
> the changes before I fix the merge conflicts?
>
> 1. Moved all the nmt source code from services/ to nmt/
> 2. Renamed all the include statements and sorted them
> 3. Fixed the include guards
Johan Sjölen has update
On Thu, 26 Oct 2023 08:58:13 GMT, Thomas Stuefe wrote:
>> When using 'MemStat' CompileCommand, we accidentally register the command if
>> an invalid suboption had been specified. Fixed, added regression test
>> (verified).
>
> Thomas Stuefe has updated the pull request incrementally with two ad
On Wed, 25 Oct 2023 22:16:03 GMT, David Holmes wrote:
>>> If "omitting value means 'collect'" then why do we not simply set value =
>>> (uintx)MemStatAction::collect ? Otherwise what is that message supposed to
>>> mean?
>>
>> We only enter this function if a value for this command had been gi
> When using 'MemStat' CompileCommand, we accidentally register the command if
> an invalid suboption had been specified. Fixed, added regression test
> (verified).
Thomas Stuefe has updated the pull request incrementally with two additional
commits since the last revision:
- remove tab
- Ma
On Tue, 24 Oct 2023 09:51:20 GMT, Goetz Lindenmaier wrote:
> …tipleRegistries.java
>
> The test fails in our CI with the message listed here. We see both, aarch and
> x86_64. It happens rarely, but a long time back.
This pull request has now been integrated.
Changeset: 37c40a11
Author:Goe
On Tue, 24 Oct 2023 09:51:20 GMT, Goetz Lindenmaier wrote:
> …tipleRegistries.java
>
> The test fails in our CI with the message listed here. We see both, aarch and
> x86_64. It happens rarely, but a long time back.
Thanks for the reviews!
-
PR Comment: https://git.openjdk.org/jd
> Fix race condition in debugger port selection, introduced with
> [JDK-8317920](https://bugs.openjdk.org/browse/JDK-8317920).
>
> Tested on my Mac M1, but it doesn't contain platform-dependent code.
Johannes Bechberger has updated the pull request incrementally with one
additional commit since
> Fix race condition in debugger port selection, introduced with
> [JDK-8317920](https://bugs.openjdk.org/browse/JDK-8317920).
>
> Tested on my Mac M1, but it doesn't contain platform-dependent code.
Johannes Bechberger has updated the pull request incrementally with two
additional commits sinc
27 matches
Mail list logo
