RFR: JDK-8318626: GetClassFields does not filter out ConstantPool.constantPoolOop field

2023-10-23 Thread Alex Menkov
FilteredFieldStream is intended to filter out some fields which does not represent valid java objects. Currently the only filtered field is "constantPoolOop" from jdk.internal.reflect.ConstantPool class. The change fixes FilteredFieldStream implementation to handle cases when filtered fields is

Re: RFR: JDK-8318636: Add jcmd to print annotated process memory map

2023-10-23 Thread Zhengyu Gu
On Mon, 23 Oct 2023 05:25:50 GMT, Thomas Stuefe wrote: > > The hs_err file includes a dump of the maps file. It seems these > > annotations would be useful there also. > > I thought about this too. The problem is the printing may take long since it > is O^2 (iterate through VMAs, for each one

Re: RFR: JDK-8318636: Add jcmd to print annotated process memory map

2023-10-23 Thread Chris Plummer
On Mon, 23 Oct 2023 01:39:16 GMT, Chris Plummer wrote: >> Analysts and supporters often use /proc/xx/maps to make sense of the memory >> footprint of a process. >> >> Interpreting the memory map correctly can help when used as a complement to >> other tools (e.g. NMT). There even exist tools o

Re: RFR: 8314502: Change the comparator taking version of GrowableArray::find to be a template method [v6]

2023-10-23 Thread Afshin Zafari
On Fri, 20 Oct 2023 08:37:11 GMT, Afshin Zafari wrote: >> Afshin Zafari has updated the pull request incrementally with one additional >> commit since the last revision: >> >> first arg of `find` casted to `uint*` > > @dholmes-ora, any more comments? > @afshin-zafari could you merge (not reb

Re: RFR: 8318447: Move NMT source code to own subdirectory

2023-10-23 Thread Stefan Karlsson
On Fri, 20 Oct 2023 11:31:11 GMT, Johan Sjölen wrote: > For the gtest source files I separated the includes in a consistent manner, > they all look like this pattern now: That's not what I see in the latest patch. Could you revert that separation and then we can consider that style change in a

Re: RFR: 8318447: Move NMT source code to own subdirectory [v6]

2023-10-23 Thread Stefan Karlsson
On Mon, 23 Oct 2023 08:34:59 GMT, Johan Sjölen wrote: >> I think that NMT is deserving of its own subdirectory. Can we do a review of >> the changes before I fix the merge conflicts? >> >> 1. Moved all the nmt source code from services/ to nmt/ >> 2. Renamed all the include statements and sorte

Re: RFR: 8318447: Move NMT source code to own subdirectory [v5]

2023-10-23 Thread Stefan Karlsson
On Fri, 20 Oct 2023 12:49:46 GMT, Johan Sjölen wrote: >> I think that NMT is deserving of its own subdirectory. Can we do a review of >> the changes before I fix the merge conflicts? >> >> 1. Moved all the nmt source code from services/ to nmt/ >> 2. Renamed all the include statements and sorte

Re: RFR: 8318447: Move NMT source code to own subdirectory [v6]

2023-10-23 Thread Johan Sjölen
> I think that NMT is deserving of its own subdirectory. Can we do a review of > the changes before I fix the merge conflicts? > > 1. Moved all the nmt source code from services/ to nmt/ > 2. Renamed all the include statements and sorted them > 3. Fixed the include guards Johan Sjölen has update