On Fri, 6 Oct 2023 23:03:14 GMT, Chris Plummer wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review: convert check for is_hidden_from_external_view check() into assert
>
> src/hotspot/share/prims/jvmti.xml lin
On Fri, 6 Oct 2023 19:15:06 GMT, Leonid Mesnik wrote:
> The fix looks good. (I looked at the test changes mostly.) The only question,
> if it makes sense to update the test to verify that heapdump works correctly
> without continuations.
good point.
Added testing with -VMContinuations
Also rea
> This is subtask of JDK-8299426: Heap dump does not contain virtual Thread
> stack references
> The change:
> - reorganize thread-related code/prepare it to use for unmounted vthreads:
> - new ThreadDumper class caches stack frames, thread serial num, frame
> serial number (trace serial number
On Fri, 6 Oct 2023 19:13:26 GMT, Serguei Spitsyn wrote:
>> Alex Menkov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> misspell getRefererId for consistency
>
> src/hotspot/share/services/heapDumper.cpp line 1494:
>
>> 1492: class Threa
On Wed, 4 Oct 2023 01:23:01 GMT, Serguei Spitsyn wrote:
>> Alex Menkov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> misspell getRefererId for consistency
>
> src/hotspot/share/services/heapDumper.cpp line 1579:
>
>> 1577:
>> 1578:
> This is subtask of JDK-8299426: Heap dump does not contain virtual Thread
> stack references
> The change:
> - reorganize thread-related code/prepare it to use for unmounted vthreads:
> - new ThreadDumper class caches stack frames, thread serial num, frame
> serial number (trace serial number
On Fri, 6 Oct 2023 19:55:59 GMT, Leonid Mesnik wrote:
> The launcher class is fixed.
> Tested by tier1 and running test with different VM flags
Marked as reviewed by cjplummer (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/16079#pullrequestreview-1662907976
On Fri, 6 Oct 2023 19:24:03 GMT, Leonid Mesnik wrote:
> I marked tests
> sun/tools/jcmd/TestProcessHelper.java
> sun/tools/jinfo/JInfoTest.java
> as headless. They used different specific VM options and are not worth
> executing with other VM flags.
> And fixed
> sun/tools/jstat/JStatInterval
On Fri, 6 Oct 2023 19:24:03 GMT, Leonid Mesnik wrote:
> I marked tests
> sun/tools/jcmd/TestProcessHelper.java
> sun/tools/jinfo/JInfoTest.java
> as headless. They used different specific VM options and are not worth
> executing with other VM flags.
> And fixed
> sun/tools/jstat/JStatInterval
On Fri, 6 Oct 2023 18:46:42 GMT, Serguei Spitsyn wrote:
>> The JVMTI VirtualThreadStart events have to follow the ThreadStart events
>> pattern and so, should not be thread-filtered.
>> The fix includes:
>> - `jvmti.xml`: remov the attribute `filtered="thread"` in the
>> `VirtuallThreadStart`
On Thu, 5 Oct 2023 18:21:06 GMT, Leonid Mesnik wrote:
>> Updated test to use createTesJvm.
>> Removed internal timeout to not fail when Xcomp is used and also to get more
>> info if the test times out.,
>>
>> Tested by running tier1, hs-tier5 and executing test with various VM flags.
>
> Leonid
On Fri, 6 Oct 2023 22:34:40 GMT, Serguei Spitsyn wrote:
>> Leonid Mesnik has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> simplifed usage, removed classpath adding.
>
> test/jdk/sun/management/jmxremote/bootstrap/CustomLauncherTest.java l
See the bug description for more information.
This implementation brings down the time to take a heap dump on the example
application in the bug report to <2 seconds on my machine.
-
Commit messages:
- whitespaces
- Iterate fields forwards on thread dump
Changes: https://git.open
On Fri, 6 Oct 2023 20:47:22 GMT, Leonid Mesnik wrote:
> Test fixed to accept vm flags.
Hmmm... what kind of testing has been done to make sure that we don't
suddenly get a bunch of new failures by allowing this test to accept VM flags?
-
PR Comment: https://git.openjdk.org/jdk/pul
Hi Frederic, hi Alex,
thank you for your comments.
I think it is better to have a fresh implementation in fieldStreams.hpp.
This way, other functionality can be addressed separately (and
fieldStreams.hpp is a more appropriate place imo).
I agree that the FieldStream implementation should be
Test fixed to accept vm flags.
-
Commit messages:
- 8316462
Changes: https://git.openjdk.org/jdk/pull/16081/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=16081&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8316462
Stats: 3 lines in 1 file changed: 0 ins; 0 del;
The test uses specific classpath, and jar and is intended to test modules. So I
marked is as flagless,
-
Commit messages:
- 8316452
Changes: https://git.openjdk.org/jdk/pull/16080/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=16080&range=00
Issue: https://bugs.openjdk.o
The launcher class is fixed.
Tested by tier1 and running test with different VM flags
-
Commit messages:
- 8316446
Changes: https://git.openjdk.org/jdk/pull/16079/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=16079&range=00
Issue: https://bugs.openjdk.org/browse/JDK-831
I marked tests
sun/tools/jcmd/TestProcessHelper.java
sun/tools/jinfo/JInfoTest.java
as headless. They used different specific VM options and are not worth
executing with other VM flags.
And fixed
sun/tools/jstat/JStatInterval.java
Tested with tier1, local execution of tests, and running
sun/to
On Fri, 29 Sep 2023 02:20:10 GMT, Alex Menkov wrote:
>> This is subtask of JDK-8299426: Heap dump does not contain virtual Thread
>> stack references
>> The change:
>> - reorganize thread-related code/prepare it to use for unmounted vthreads:
>> - new ThreadDumper class caches stack frames, th
On Fri, 29 Sep 2023 02:20:10 GMT, Alex Menkov wrote:
>> This is subtask of JDK-8299426: Heap dump does not contain virtual Thread
>> stack references
>> The change:
>> - reorganize thread-related code/prepare it to use for unmounted vthreads:
>> - new ThreadDumper class caches stack frames, th
On Fri, 6 Oct 2023 18:46:42 GMT, Serguei Spitsyn wrote:
>> The JVMTI VirtualThreadStart events have to follow the ThreadStart events
>> pattern and so, should not be thread-filtered.
>> The fix includes:
>> - `jvmti.xml`: remov the attribute `filtered="thread"` in the
>> `VirtuallThreadStart`
Hi Hannes,
Thank you for the analysis and the proposed solution.
The changes look reasonable to me, and I agree with Alex that we should
either fix or get rid of the old FieldStream implementation. If we keep
it, this kind of performance issue will happen again.
Regards,
Fred
On 10/2/2
> The JVMTI VirtualThreadStart events have to follow the ThreadStart events
> pattern and so, should not be thread-filtered.
> The fix includes:
> - `jvmti.xml`: remov the attribute `filtered="thread"` in the
> `VirtuallThreadStart` event spec
> - `jvmtiEventController.cpp`: remove the `VTHREAD
On Wed, 4 Oct 2023 21:59:54 GMT, Leonid Mesnik wrote:
>> The JVMTI VirtualThreadStart events have to follow the ThreadStart events
>> pattern and so, should not be thread-filtered.
>> The fix includes:
>> - `jvmti.xml`: remov the attribute `filtered="thread"` in the
>> `VirtuallThreadStart` ev
On Wed, 4 Oct 2023 21:55:21 GMT, Leonid Mesnik wrote:
>> The JVMTI VirtualThreadStart events have to follow the ThreadStart events
>> pattern and so, should not be thread-filtered.
>> The fix includes:
>> - `jvmti.xml`: remov the attribute `filtered="thread"` in the
>> `VirtuallThreadStart` ev
26 matches
Mail list logo
