Re: RFR: 8315880: change LockingMode default from LM_LEGACY to LM_LIGHTWEIGHT

2023-09-18 Thread Stefan Karlsson
On Mon, 18 Sep 2023 20:47:13 GMT, Daniel D. Daugherty wrote: > Change the default of LockingMode to LM_LIGHTWEIGHT from LM_LEGACY. > > This fix has been tested with 3 Mach5 Tier[1-8] runs and a 4th is in process. Looks good. Thank you! - Marked as reviewed by stefank (Reviewer).

Re: RFR: 8316417: ObjectMonitorIterator does not return the most recent monitor and is incorrect if no monitors exists [v3]

2023-09-18 Thread Axel Boldt-Christmas
On Mon, 18 Sep 2023 18:46:19 GMT, Chris Plummer wrote: >> Axel Boldt-Christmas has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Copyright changes too > > src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/runtime/ObjectSynchronizer.java

Re: RFR: JDK-8313804: JDWP support for -Djava.net.preferIPv6Addresses=system [v3]

2023-09-18 Thread Liam Miller-Cushon
On Tue, 19 Sep 2023 00:03:27 GMT, Liam Miller-Cushon wrote: >> Please consider this fix for >> [JDK-8313804](https://bugs.openjdk.org/browse/JDK-8313804), which adds >> support to JDWP for `-Djava.net.preferIPv6Addresses=system`. Previously it >> only handled `-Djava.net.preferIPv6Addresses=tr

Re: RFR: JDK-8313804: JDWP support for -Djava.net.preferIPv6Addresses=system [v3]

2023-09-18 Thread David Holmes
On Tue, 19 Sep 2023 00:03:27 GMT, Liam Miller-Cushon wrote: >> Please consider this fix for >> [JDK-8313804](https://bugs.openjdk.org/browse/JDK-8313804), which adds >> support to JDWP for `-Djava.net.preferIPv6Addresses=system`. Previously it >> only handled `-Djava.net.preferIPv6Addresses=tr

Re: RFR: 8315880: change LockingMode default from LM_LEGACY to LM_LIGHTWEIGHT

2023-09-18 Thread Roman Kennke
On Mon, 18 Sep 2023 20:47:13 GMT, Daniel D. Daugherty wrote: > Change the default of LockingMode to LM_LIGHTWEIGHT from LM_LEGACY. > > This fix has been tested with 3 Mach5 Tier[1-8] runs and a 4th is in process. Looks good to me, thank you! - Marked as reviewed by rkennke (Revie

Re: RFR: JDK-8313804: JDWP support for -Djava.net.preferIPv6Addresses=system [v2]

2023-09-18 Thread Liam Miller-Cushon
On Mon, 18 Sep 2023 23:44:22 GMT, Chris Plummer wrote: >> Liam Miller-Cushon has refreshed the contents of this pull request, and >> previous commits have been removed. The incremental views will show >> differences compared to the previous content of the PR. The pull request >> contains one n

Re: RFR: JDK-8313804: JDWP support for -Djava.net.preferIPv6Addresses=system [v2]

2023-09-18 Thread David Holmes
On Mon, 18 Sep 2023 23:44:22 GMT, Chris Plummer wrote: >> Liam Miller-Cushon has refreshed the contents of this pull request, and >> previous commits have been removed. The incremental views will show >> differences compared to the previous content of the PR. The pull request >> contains one n

Integrated: 8314021: HeapDump: Optimize segmented heap file merging phase

2023-09-18 Thread Yi Yang
On Fri, 11 Aug 2023 09:31:56 GMT, Yi Yang wrote: > This patch reduce ~16%(24s->20s) pahse 2 merge time during dumping 32g heap > with 96threads and fixes a memory leak of compressor > > You might argue why this is Linux-only optimization, because sendfile > requires at least socket fd in other

Re: RFR: 8314021: HeapDump: Optimize segmented heap file merging phase [v2]

2023-09-18 Thread Yi Yang
On Mon, 18 Sep 2023 11:09:36 GMT, Kevin Walls wrote: > Apologies for delay, had looked at this previously but not come back for > final review. Never mind:) Thanks @alexmenkov and @kevinjwalls for the reviews. - PR Comment: https://git.openjdk.org/jdk/pull/15245#issuecomment-17247

Re: RFR: 8315149: Add hsperf counters for CPU time of internal GC threads [v22]

2023-09-18 Thread Jonathan Joo
> 8315149: Add hsperf counters for CPU time of internal GC threads Jonathan Joo has updated the pull request incrementally with one additional commit since the last revision: Fix more broken headers for sanity checks - Changes: - all: https://git.openjdk.org/jdk/pull/15082/file

Re: RFR: JDK-8313804: JDWP support for -Djava.net.preferIPv6Addresses=system [v2]

2023-09-18 Thread Liam Miller-Cushon
On Mon, 18 Sep 2023 23:44:22 GMT, Chris Plummer wrote: > Is the code starting at lines 748 and 970 still correct after your changes? I think so, but scrutiny there is very welcome. I expected additional changes to be necessary. * For 748, it's handling a situation where IPv4 isn't specifically

Re: RFR: JDK-8313804: JDWP support for -Djava.net.preferIPv6Addresses=system [v3]

2023-09-18 Thread Liam Miller-Cushon
> Please consider this fix for > [JDK-8313804](https://bugs.openjdk.org/browse/JDK-8313804), which adds > support to JDWP for `-Djava.net.preferIPv6Addresses=system`. Previously it > only handled `-Djava.net.preferIPv6Addresses=true` and > `-Djava.net.preferIPv6Addresses=false`. Liam Miller-Cu

Re: RFR: JDK-8313804: JDWP support for -Djava.net.preferIPv6Addresses=system [v2]

2023-09-18 Thread Chris Plummer
On Mon, 18 Sep 2023 20:47:22 GMT, Liam Miller-Cushon wrote: >> Please consider this fix for >> [JDK-8313804](https://bugs.openjdk.org/browse/JDK-8313804), which adds >> support to JDWP for `-Djava.net.preferIPv6Addresses=system`. Previously it >> only handled `-Djava.net.preferIPv6Addresses=tr

Re: RFR: 8315149: Add hsperf counters for CPU time of internal GC threads [v21]

2023-09-18 Thread Jonathan Joo
> 8315149: Add hsperf counters for CPU time of internal GC threads Jonathan Joo has updated the pull request incrementally with one additional commit since the last revision: Add more header files for broken debug build - Changes: - all: https://git.openjdk.org/jdk/pull/15082/f

Re: RFR: 8315149: Add hsperf counters for CPU time of internal GC threads [v20]

2023-09-18 Thread Jonathan Joo
> 8315149: Add hsperf counters for CPU time of internal GC threads Jonathan Joo has updated the pull request incrementally with one additional commit since the last revision: Add header for failing build check - Changes: - all: https://git.openjdk.org/jdk/pull/15082/files - n

Re: RFR: 8315880: change LockingMode default from LM_LEGACY to LM_LIGHTWEIGHT

2023-09-18 Thread David Holmes
On Mon, 18 Sep 2023 20:47:13 GMT, Daniel D. Daugherty wrote: > Change the default of LockingMode to LM_LIGHTWEIGHT from LM_LEGACY. > > This fix has been tested with 3 Mach5 Tier[1-8] runs and a 4th is in process. Looks good. Thanks. - Marked as reviewed by dholmes (Reviewer). PR

RFR: 8315880: change LockingMode default from LM_LEGACY to LM_LIGHTWEIGHT

2023-09-18 Thread Daniel D . Daugherty
Change the default of LockingMode to LM_LIGHTWEIGHT from LM_LEGACY. This fix has been tested with 3 Mach5 Tier[1-8] runs and a 4th is in process. - Commit messages: - 8315880: change LockingMode default from LM_LEGACY to LM_LIGHTWEIGHT Changes: https://git.openjdk.org/jdk/pull/1579

Re: RFR: JDK-8313804: JDWP support for -Djava.net.preferIPv6Addresses=system [v2]

2023-09-18 Thread Liam Miller-Cushon
> Please consider this fix for > [JDK-8313804](https://bugs.openjdk.org/browse/JDK-8313804), which adds > support to JDWP for `-Djava.net.preferIPv6Addresses=system`. Previously it > only handled `-Djava.net.preferIPv6Addresses=true` and > `-Djava.net.preferIPv6Addresses=false`. Liam Miller-Cu

RFR: JDK-8313804: JDWP support for -Djava.net.preferIPv6Addresses=system

2023-09-18 Thread Liam Miller-Cushon
Please consider this fix for [JDK-8313804](https://bugs.openjdk.org/browse/JDK-8313804), which adds support to JDWP for `-Djava.net.preferIPv6Addresses=system`. Previously it only handled `-Djava.net.preferIPv6Addresses=true` and `-Djava.net.preferIPv6Addresses=false`. - Commit me

Re: RFR: 8301639: JDI and JDWP specs should clarify potential deadlock issues with method invocation [v2]

2023-09-18 Thread Chris Plummer
On Sat, 16 Sep 2023 05:38:01 GMT, Alan Bateman wrote: > > CSR has been created: > > [JDK-8301639](https://bugs.openjdk.org/browse/JDK-8301639) > > I added the "csr" label as it was initially looking like this would involve a > spec update. It's now changed to be non-normative and an API note s

Re: RFR: 8316417: ObjectMonitorIterator does not return the most recent monitor and is incorrect if no monitors exists [v3]

2023-09-18 Thread Chris Plummer
On Mon, 18 Sep 2023 12:11:24 GMT, Axel Boldt-Christmas wrote: >> ObjectMonitorIterator fails to return the most resent monitor added. It >> start with returning the `nextOM()` ObjectMonitor from the `_head` >> ObjectMonitor but fails to ever return the `_head` ObjectMonitor. >> The current imp

Re: RFR: 8316417: ObjectMonitorIterator does not return the most recent monitor and is incorrect if no monitors exists

2023-09-18 Thread Chris Plummer
On Mon, 18 Sep 2023 11:55:24 GMT, Axel Boldt-Christmas wrote: > CDS tests are not happy with changing the class hierarchy of the LingeredApp. > Unless it is easily solved for the CDS test I will revert those changes and > have the 'TestObjectMonitorIterate' just do a less precise check of a lo

Integrated: 8316142: Enable parallelism in vmTestbase/nsk/monitoring/stress/lowmem tests

2023-09-18 Thread Aleksey Shipilev
On Tue, 12 Sep 2023 19:20:16 GMT, Aleksey Shipilev wrote: > Similar to [JDK-8315437](https://bugs.openjdk.org/browse/JDK-8315437), > current vmTestbase/nsk/monitoring/stress/lowmem tests contains 36 tests, each > running exclusively. This drags the tier4 test times up. There seem to be no > re

Re: RFR: 8316142: Enable parallelism in vmTestbase/nsk/monitoring/stress/lowmem tests

2023-09-18 Thread Aleksey Shipilev
On Tue, 12 Sep 2023 19:20:16 GMT, Aleksey Shipilev wrote: > Similar to [JDK-8315437](https://bugs.openjdk.org/browse/JDK-8315437), > current vmTestbase/nsk/monitoring/stress/lowmem tests contains 36 tests, each > running exclusively. This drags the tier4 test times up. There seem to be no > re

Re: RFR: 8316417: ObjectMonitorIterator does not return the most recent monitor and is incorrect if no monitors exists [v3]

2023-09-18 Thread Axel Boldt-Christmas
> ObjectMonitorIterator fails to return the most resent monitor added. It start > with returning the `nextOM()` ObjectMonitor from the `_head` ObjectMonitor > but fails to ever return the `_head` ObjectMonitor. > The current implementation can also not handle that the `_head` is nullptr > (no mo

Re: RFR: 8316417: ObjectMonitorIterator does not return the most recent monitor and is incorrect if no monitors exists [v2]

2023-09-18 Thread Axel Boldt-Christmas
> ObjectMonitorIterator fails to return the most resent monitor added. It start > with returning the `nextOM()` ObjectMonitor from the `_head` ObjectMonitor > but fails to ever return the `_head` ObjectMonitor. > The current implementation can also not handle that the `_head` is nullptr > (no mo

Integrated: JDK-8315706: com/sun/tools/attach/warnings/DynamicLoadWarningTest.java real fix for failure on AIX

2023-09-18 Thread Joachim Kern
On Wed, 6 Sep 2023 08:18:45 GMT, Joachim Kern wrote: > After push of [JDK-8307478](https://bugs.openjdk.org/browse/JDK-8307478) , > the following test started to fail on AIX : > com/sun/tools/attach/warnings/DynamicLoadWarningTest.java; > The problem was described in > [JDK-8309549](https://bug

Re: RFR: 8316417: ObjectMonitorIterator does not return the most recent monitor and is incorrect if no monitors exists

2023-09-18 Thread Axel Boldt-Christmas
On Mon, 18 Sep 2023 09:54:18 GMT, Axel Boldt-Christmas wrote: > ObjectMonitorIterator fails to return the most resent monitor added. It start > with returning the `nextOM()` ObjectMonitor from the `_head` ObjectMonitor > but fails to ever return the `_head` ObjectMonitor. > The current impleme

Re: RFR: 8314021: HeapDump: Optimize segmented heap file merging phase [v2]

2023-09-18 Thread Kevin Walls
On Thu, 7 Sep 2023 02:19:10 GMT, Yi Yang wrote: >> This patch reduce ~16%(24s->20s) pahse 2 merge time during dumping 32g heap >> with 96threads and fixes a memory leak of compressor >> >> You might argue why this is Linux-only optimization, because sendfile >> requires at least socket fd in o

Re: RFR: JDK-8315706: com/sun/tools/attach/warnings/DynamicLoadWarningTest.java real fix for failure on AIX [v5]

2023-09-18 Thread Matthias Baesken
On Fri, 15 Sep 2023 07:22:32 GMT, Joachim Kern wrote: >> After push of [JDK-8307478](https://bugs.openjdk.org/browse/JDK-8307478) , >> the following test started to fail on AIX : >> com/sun/tools/attach/warnings/DynamicLoadWarningTest.java; >> The problem was described in >> [JDK-8309549](https

RFR: 8316417: ObjectMonitorIterator does not return the most recent monitor and is incorrect if no monitors exists

2023-09-18 Thread Axel Boldt-Christmas
ObjectMonitorIterator fails to return the most resent monitor added. It start with returning the `nextOM()` ObjectMonitor from the `_head` ObjectMonitor but fails to ever return the `_head` ObjectMonitor. The current implementation can also not handle that the `_head` is nullptr (no monitors in

Re: RFR: 8312498: Thread::getState and JVM TI GetThreadState should return TIMED_WAITING virtual thread is timed parked [v3]

2023-09-18 Thread Ron Pressler
On Thu, 14 Sep 2023 13:30:28 GMT, Alan Bateman wrote: >> Thread::getState is an API for monitoring and management purposes to report >> the thread state. If a virtual thread is parked with LockSupport.parkNanos, >> its state is reported as WAITING when it should be TIMED_WAITING. JVM TI >> Ge

Re: RFR: 8316142: Enable parallelism in vmTestbase/nsk/monitoring/stress/lowmem tests

2023-09-18 Thread David Holmes
On Tue, 12 Sep 2023 19:20:16 GMT, Aleksey Shipilev wrote: > Similar to [JDK-8315437](https://bugs.openjdk.org/browse/JDK-8315437), > current vmTestbase/nsk/monitoring/stress/lowmem tests contains 36 tests, each > running exclusively. This drags the tier4 test times up. There seem to be no > re