Re: RFR: 8314021: HeapDump: Optimize segmented heap file merging phase

2023-09-05 Thread Yi Yang
On Fri, 11 Aug 2023 09:31:56 GMT, Yi Yang wrote: > This patch reduce ~16%(24s->20s) pahse 2 merge time during dumping 32g heap > with 96threads and fixes a memory leak of compressor > > You might argue why this is Linux-only optimization, because sendfile > requires at least socket fd in other

Re: RFR: 8315373: Change VirtualThread to unmount after freezing, re-mount before thawing [v2]

2023-09-05 Thread Serguei Spitsyn
On Mon, 4 Sep 2023 08:24:19 GMT, Alan Bateman wrote: >> In the virtual thread implementation, thread identity switches to the >> carrier before freezing and switches back to the virtual thread after >> thawing. This was a forced move due to issues getting JVMTI to work with >> virtual threads.

Integrated: 8315406: [REDO] serviceability/jdwp/AllModulesCommandTest.java ignores VM flags

2023-09-05 Thread Leonid Mesnik
On Fri, 1 Sep 2023 20:38:28 GMT, Leonid Mesnik wrote: > The fix changes test serviceability/jdwp/AllModulesCommandTest.java to accept > VM flags. > 1) The 'ProcessTools.createTestJvm(JDWP_OPT, DEBUGGEE);' is used to start > debugee > 2) The stderr is just logging and tests doesn't check if it

Re: RFR: 8267174: Many test files have the wrong Copyright header

2023-09-05 Thread Valerie Peng
On Tue, 5 Sep 2023 22:49:41 GMT, Erik Joelsson wrote: > There are a number of files in the `test` directory that have an incorrect > copyright header, which includes the "classpath" exception text. This patch > removes that text from all test files that I could find it in. I did this > using a

Re: RFR: 8267174: Many test files have the wrong Copyright header

2023-09-05 Thread Jonathan Gibbons
On Tue, 5 Sep 2023 22:49:41 GMT, Erik Joelsson wrote: > There are a number of files in the `test` directory that have an incorrect > copyright header, which includes the "classpath" exception text. This patch > removes that text from all test files that I could find it in. I did this > using a

Re: RFR: 8267174: Many test files have the wrong Copyright header

2023-09-05 Thread Chris Plummer
On Tue, 5 Sep 2023 22:49:41 GMT, Erik Joelsson wrote: > There are a number of files in the `test` directory that have an incorrect > copyright header, which includes the "classpath" exception text. This patch > removes that text from all test files that I could find it in. I did this > using a

RFR: 8267174: Many test files have the wrong Copyright header

2023-09-05 Thread Erik Joelsson
There are a number of files in the `test` directory that have an incorrect copyright header, which includes the "classpath" exception text. This patch removes that text from all test files that I could find it in. I did this using a combination of `sed` and `grep`. Reviewing this patch is probab

Integrated: 8315563: Remove references to JDK-8226420 from problem list

2023-09-05 Thread Alex Menkov
On Sat, 2 Sep 2023 00:50:08 GMT, Alex Menkov wrote: > JDK-8226420 has been closed as a duplicate. > The fix removes references to 8226420 from problemlist (the tests remain > problem-listed due other issues). This pull request has now been integrated. Changeset: d3ee704b Author:Alex Menkov

Re: RFR: 8315097: Rename createJavaProcessBuilder [v3]

2023-09-05 Thread Mark Sheppard
On Wed, 30 Aug 2023 09:23:55 GMT, Leo Korinth wrote: >> Rename createJavaProcessBuilder so that it is not used by mistake instead of >> createTestJvm. >> >> I have used the following sed script: `find -name "*.java" | xargs -n 1 sed >> -i -e >> "s/createJavaProcessBuilder(/createJavaProcessBu

Re: RFR: 8315563: Remove references to JDK-8226420 from problem list

2023-09-05 Thread Chris Plummer
On Sat, 2 Sep 2023 00:50:08 GMT, Alex Menkov wrote: > JDK-8226420 has been closed as a duplicate. > The fix removes references to 8226420 from problemlist (the tests remain > problem-listed due other issues). Marked as reviewed by cjplummer (Reviewer). - PR Review: https://git.ope

Re: RFR: 8315648: No tests were modified after JDK-8309979

2023-09-05 Thread Chris Plummer
On Mon, 4 Sep 2023 14:18:55 GMT, Roman Marchenko wrote: > This change added a simple check in > test/hotspot/jtreg/serviceability/sa/ClhsdbDumpclass.java if BootstrapMethods > attribute was dumped. (similar to test changes in PR #14556) Marked as reviewed by cjplummer (Reviewer). I think the

Re: RFR: 8315406: [REDO] serviceability/jdwp/AllModulesCommandTest.java ignores VM flags [v3]

2023-09-05 Thread Daniel D . Daugherty
On Fri, 1 Sep 2023 23:06:15 GMT, Leonid Mesnik wrote: >> The fix changes test serviceability/jdwp/AllModulesCommandTest.java to >> accept VM flags. >> 1) The 'ProcessTools.createTestJvm(JDWP_OPT, DEBUGGEE);' is used to start >> debugee >> 2) The stderr is just logging and tests doesn't check

Re: RFR: 8315097: Rename createJavaProcessBuilder [v3]

2023-09-05 Thread Roger Riggs
On Mon, 4 Sep 2023 11:01:23 GMT, Leo Korinth wrote: > What do you prefer? Do you have a better alternative? Do someone still think > the current code is good? I think what we have today is inferior to all these > improvements, and I would like to make it harder to develop bad test ca The curre

Integrated: 8315717: ProblemList serviceability/sa/TestHeapDumpForInvokeDynamic.java with ZGC

2023-09-05 Thread Daniel D . Daugherty
On Tue, 5 Sep 2023 17:17:25 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList > serviceability/sa/TestHeapDumpForInvokeDynamic.java with ZGC. This pull request has now been integrated. Changeset: ebe31277 Author:Daniel D. Daugherty URL: https://git.openjdk.org/jdk/comm

Re: RFR: 8315717: ProblemList serviceability/sa/TestHeapDumpForInvokeDynamic.java with ZGC

2023-09-05 Thread Daniel D . Daugherty
On Tue, 5 Sep 2023 17:17:25 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList > serviceability/sa/TestHeapDumpForInvokeDynamic.java with ZGC. It still hasn't integrated... The bot must be unhappy today... One more time: - PR Comment: https://git.openjdk.org/jdk/pull/1

Re: RFR: 8315717: ProblemList serviceability/sa/TestHeapDumpForInvokeDynamic.java with ZGC

2023-09-05 Thread Daniel D . Daugherty
On Tue, 5 Sep 2023 17:17:25 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList > serviceability/sa/TestHeapDumpForInvokeDynamic.java with ZGC. This is weird... The "/integrate" didn't work... - PR Comment: https://git.openjdk.org/jdk/pull/15570#issuecomment-1707036410

Re: RFR: 8315717: ProblemList serviceability/sa/TestHeapDumpForInvokeDynamic.java with ZGC

2023-09-05 Thread Daniel D . Daugherty
On Tue, 5 Sep 2023 17:20:29 GMT, Alexander Zvegintsev wrote: >> A trivial fix to ProblemList >> serviceability/sa/TestHeapDumpForInvokeDynamic.java with ZGC. > > Marked as reviewed by azvegint (Reviewer). @azvegint and @kevinjwalls - Thanks for the reviews! I did a fast "/integrate" so your re

Re: RFR: 8315717: ProblemList serviceability/sa/TestHeapDumpForInvokeDynamic.java with ZGC

2023-09-05 Thread Kevin Walls
On Tue, 5 Sep 2023 17:17:25 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList > serviceability/sa/TestHeapDumpForInvokeDynamic.java with ZGC. Marked as reviewed by kevinw (Committer). Thanks Dan! - PR Review: https://git.openjdk.org/jdk/pull/15570#pullrequestreview-1

Re: RFR: 8315717: ProblemList serviceability/sa/TestHeapDumpForInvokeDynamic.java with ZGC

2023-09-05 Thread Daniel D . Daugherty
On Tue, 5 Sep 2023 17:20:03 GMT, Tobias Hartmann wrote: >> A trivial fix to ProblemList >> serviceability/sa/TestHeapDumpForInvokeDynamic.java with ZGC. > > Looks good and trivial. @TobiHartmann - Thanks for the lightning fast review! - PR Comment: https://git.openjdk.org/jdk/pull

RFR: 8315717: ProblemList serviceability/sa/TestHeapDumpForInvokeDynamic.java with ZGC

2023-09-05 Thread Daniel D . Daugherty
A trivial fix to ProblemList serviceability/sa/TestHeapDumpForInvokeDynamic.java with ZGC. - Commit messages: - 8315717: ProblemList serviceability/sa/TestHeapDumpForInvokeDynamic.java with ZGC Changes: https://git.openjdk.org/jdk/pull/15570/files Webrev: https://webrevs.openjdk.

Re: RFR: 8315717: ProblemList serviceability/sa/TestHeapDumpForInvokeDynamic.java with ZGC

2023-09-05 Thread Tobias Hartmann
On Tue, 5 Sep 2023 17:17:25 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList > serviceability/sa/TestHeapDumpForInvokeDynamic.java with ZGC. Looks good and trivial. - Marked as reviewed by thartmann (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/15570#pullr

Re: RFR: 8315717: ProblemList serviceability/sa/TestHeapDumpForInvokeDynamic.java with ZGC

2023-09-05 Thread Alexander Zvegintsev
On Tue, 5 Sep 2023 17:17:25 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList > serviceability/sa/TestHeapDumpForInvokeDynamic.java with ZGC. Marked as reviewed by azvegint (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/15570#pullrequestreview-1611581278

Re: RFR: 8315373: Change VirtualThread to unmount after freezing, re-mount before thawing [v2]

2023-09-05 Thread Serguei Spitsyn
On Mon, 4 Sep 2023 08:24:19 GMT, Alan Bateman wrote: >> In the virtual thread implementation, thread identity switches to the >> carrier before freezing and switches back to the virtual thread after >> thawing. This was a forced move due to issues getting JVMTI to work with >> virtual threads.

Integrated: 8315442: Enable parallelism in vmTestbase/nsk/monitoring/stress/thread tests

2023-09-05 Thread Aleksey Shipilev
On Thu, 31 Aug 2023 08:40:58 GMT, Aleksey Shipilev wrote: > Current vmTestbase/nsk/monitoring/stress/thread tests contains 21 tests, each > running exclusively. This drags the tier4 test times up. There seem to be no > reason to run these tests exclusively, though: they complete in reasonable

Re: RFR: 8315437: Enable parallelism in vmTestbase/nsk/monitoring/stress/classload tests

2023-09-05 Thread Aleksey Shipilev
On Thu, 31 Aug 2023 07:55:01 GMT, Aleksey Shipilev wrote: > Current vmTestbase/nsk/monitoring/stress/classload tests contains 24 tests, > each running exclusively. This drags the tier4 test times up. There seem to > be no reason to run these tests exclusively, though: they complete in > reason

Re: RFR: 8315442: Enable parallelism in vmTestbase/nsk/monitoring/stress/thread tests

2023-09-05 Thread Aleksey Shipilev
On Thu, 31 Aug 2023 08:40:58 GMT, Aleksey Shipilev wrote: > Current vmTestbase/nsk/monitoring/stress/thread tests contains 21 tests, each > running exclusively. This drags the tier4 test times up. There seem to be no > reason to run these tests exclusively, though: they complete in reasonable