On Sat, 2 Sep 2023 00:50:08 GMT, Alex Menkov wrote:
> JDK-8226420 has been closed as a duplicate.
> The fix removes references to 8226420 from problemlist (the tests remain
> problem-listed due other issues).
test/jdk/ProblemList.txt line 727:
> 725: sun/tools/jstatd/TestJstatdDefaults.java
JDK-8226420 has been closed as a duplicate.
The fix removes references to 8226420 from problemlist (the tests remain
problem-listed due other issues).
-
Commit messages:
- Removed 8226420 from problem list
Changes: https://git.openjdk.org/jdk/pull/15548/files
Webrev: https://webre
On Fri, 1 Sep 2023 22:02:10 GMT, Alex Menkov wrote:
> Logic to detect "port in use" case and retry was implemented in the test by
> JDK-8240711.
> Infra issue with some test host when system software listened on port 1099
> was resolved long time ago.
>
> So JDK-8226420 has been closed as a du
On Fri, 1 Sep 2023 22:55:44 GMT, Leonid Mesnik wrote:
>> I don't like approach to compare handlers. Better to just add logging into
>> these listeners.
>
> updated
stdout logging could be improved if needed when test fails.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/155
On Fri, 1 Sep 2023 23:01:01 GMT, Leonid Mesnik wrote:
>> The fix changes test serviceability/jdwp/AllModulesCommandTest.java to
>> accept VM flags.
>> 1) The 'ProcessTools.createTestJvm(JDWP_OPT, DEBUGGEE);' is used to start
>> debugee
>> 2) The stderr is just logging and tests doesn't check
> The fix changes test serviceability/jdwp/AllModulesCommandTest.java to accept
> VM flags.
> 1) The 'ProcessTools.createTestJvm(JDWP_OPT, DEBUGGEE);' is used to start
> debugee
> 2) The stderr is just logging and tests doesn't check if it is empty. stderr
> might contain some VM output which
On Fri, 1 Sep 2023 22:55:36 GMT, Leonid Mesnik wrote:
>> test/hotspot/jtreg/serviceability/jdwp/DebuggeeLauncher.java line 100:
>>
>>> 98:
>>> 99: @Override
>>> 100: public void onStringRead(String line) {
>>
>> Is there a reason not to also echo the stdout output? Seems it would be
>
On Fri, 1 Sep 2023 21:46:13 GMT, Chris Plummer wrote:
>> Leonid Mesnik has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> logging
>
> test/hotspot/jtreg/serviceability/jdwp/DebuggeeLauncher.java line 100:
>
>> 98:
>> 99: @Override
>>
Logic to detect "port in use" case and retry was implemented in the test by
JDK-8240711.
Infra issue with some test host when system software listened on port 1099 was
resolved long time ago.
So JDK-8226420 can be closed as a duplicate, but problemlist entries for
sun/tools/jstatd tests mention
On Fri, 1 Sep 2023 22:02:10 GMT, Alex Menkov wrote:
> So JDK-8226420 can be closed as a duplicate
You can't both close the CR as a duplicate and also use it as the CR to remove
the problem list references. Perhaps you should use a subtask of JDK-8240711 or
JDK-8226420 for this problem list clea
On Fri, 1 Sep 2023 21:47:53 GMT, Leonid Mesnik wrote:
>> The fix changes test serviceability/jdwp/AllModulesCommandTest.java to
>> accept VM flags.
>> 1) The 'ProcessTools.createTestJvm(JDWP_OPT, DEBUGGEE);' is used to start
>> debugee
>> 2) The stderr is just logging and tests doesn't check
> The fix changes test serviceability/jdwp/AllModulesCommandTest.java to accept
> VM flags.
> 1) The 'ProcessTools.createTestJvm(JDWP_OPT, DEBUGGEE);' is used to start
> debugee
> 2) The stderr is just logging and tests doesn't check if it is empty. stderr
> might contain some VM output which
On Wed, 23 Aug 2023 22:58:05 GMT, Leonid Mesnik wrote:
> Mark 3 tests as flagless to don't run them if not needed. Also, small clean
> up.
As long as we have other test coverage for passing the flags to the sub process
then I think these can do without.
-
PR Comment: https://git.
On Fri, 1 Sep 2023 21:11:03 GMT, Jiangli Zhou wrote:
>> Please review this simple change from @cjmoon1 for resolving static linking
>> issue caused by multiple definition of 'normalize'. @cjmoon1's branch can be
>> found at:
>> https://github.com/openjdk/jdk/compare/master...cjmoon1:jdk:fix_no
On Wed, 23 Aug 2023 22:58:05 GMT, Leonid Mesnik wrote:
> Mark 3 tests as flagless to don't run them if not needed. Also, small clean
> up.
these 3 tests verifies command-line options only like help, version, invalid
versions. I don't think they any value by runnign with different flags. But
> Please review this simple change from @cjmoon1 for resolving static linking
> issue caused by multiple definition of 'normalize'. @cjmoon1's branch can be
> found at:
> https://github.com/openjdk/jdk/compare/master...cjmoon1:jdk:fix_normalize.
>
> The change incorporated suggestions from both
On Fri, 1 Sep 2023 02:00:04 GMT, Yi Yang wrote:
>> This is a follow-up patch of #13667. verifyHeapDump is duplicated in several
>> tests, this patch tries to consolidate them into one method.
>
> Yi Yang has updated the pull request incrementally with one additional commit
> since the last revi
On Wed, 23 Aug 2023 22:58:05 GMT, Leonid Mesnik wrote:
> Mark 3 tests as flagless to don't run them if not needed. Also, small clean
> up.
Is there a reason we don't want to run the subprocess with the test flags?
-
PR Comment: https://git.openjdk.org/jdk/pull/15407#issuecomment-1
The fix changes test serviceability/jdwp/AllModulesCommandTest.java to accept
VM flags.
1) The 'ProcessTools.createTestJvm(JDWP_OPT, DEBUGGEE);' is used to start
debugee
2) The stderr is just logging and tests doesn't check if it is empty. stderr
might contain some VM output which doesn't mean
On Wed, 30 Aug 2023 21:03:17 GMT, Leonid Mesnik wrote:
> Test failed because of unexpected output of version string.
> The standard convention for tests is to skip any unexpected output (version
> string, VM warning, vm logging) and only fail on expected error patterns.
> Fix is tested by runn
On Fri, 1 Sep 2023 02:00:04 GMT, Yi Yang wrote:
>> This is a follow-up patch of #13667. verifyHeapDump is duplicated in several
>> tests, this patch tries to consolidate them into one method.
>
> Yi Yang has updated the pull request incrementally with one additional commit
> since the last revi
On Fri, 1 Sep 2023 18:07:04 GMT, Leonid Mesnik wrote:
>> Test failed because of unexpected output of version string.
>> The standard convention for tests is to skip any unexpected output (version
>> string, VM warning, vm logging) and only fail on expected error patterns.
>> Fix is tested by r
On Fri, 1 Sep 2023 18:07:04 GMT, Leonid Mesnik wrote:
>> Test failed because of unexpected output of version string.
>> The standard convention for tests is to skip any unexpected output (version
>> string, VM warning, vm logging) and only fail on expected error patterns.
>> Fix is tested by r
> Test failed because of unexpected output of version string.
> The standard convention for tests is to skip any unexpected output (version
> string, VM warning, vm logging) and only fail on expected error patterns.
> Fix is tested by running with default options and with '-showversion' vm
> o
On Fri, 1 Sep 2023 11:26:48 GMT, Alan Bateman wrote:
>> Ok. If the thread can run native code as part of the mount / unmount, and
>> the sampler can see the intermediary state there too, the check is needed.
>
> Thanks. One other thing that I see when more testing with generational ZGC is
> tha
On Fri, 1 Sep 2023 10:47:25 GMT, Markus Grönlund wrote:
>> Just to add that Patricio suggested today to run the stress tests with
>> -Xint and that does lead to triggering the assert quickly when the thread is
>> sampled in native. There are several native methods that are
>> @IntrinsicCandid
On Wed, 30 Aug 2023 13:56:42 GMT, Alan Bateman wrote:
> In the virtual thread implementation, thread identity switches to the carrier
> before freezing and switches back to the virtual thread after thawing. This
> was a forced move due to issues getting JVMTI to work with virtual threads.
> JV
On Thu, 31 Aug 2023 19:28:50 GMT, Alan Bateman wrote:
>> There are some native methods that we execute during mount/unmount
>> transitions. From what I see they all seem to be defined as
>> `@IntrinsicCandidate`, but if for some reason we don't execute the intrinsic
>> version (interp only mod
On Thu, 31 Aug 2023 07:55:01 GMT, Aleksey Shipilev wrote:
> Current vmTestbase/nsk/monitoring/stress/classload tests contains 24 tests,
> each running exclusively. This drags the tier4 test times up. There seem to
> be no reason to run these tests exclusively, though: they complete in
> reason
29 matches
Mail list logo
