On Thu, 24 Aug 2023 23:31:56 GMT, Chris Plummer wrote:
> On some macosx-aarch64 systems, not all mapped pages are dumped to the core
> file. This first turned up with
> [JDK-8293563](https://bugs.openjdk.org/browse/JDK-8293563) where large parts
> of the ZGC heap would not be in the core file,
On Thu, 24 Aug 2023 23:31:56 GMT, Chris Plummer wrote:
> On some macosx-aarch64 systems, not all mapped pages are dumped to the core
> file. This first turned up with
> [JDK-8293563](https://bugs.openjdk.org/browse/JDK-8293563) where large parts
> of the ZGC heap would not be in the core file,
On Thu, 24 Aug 2023 23:31:56 GMT, Chris Plummer wrote:
> On some macosx-aarch64 systems, not all mapped pages are dumped to the core
> file. This first turned up with
> [JDK-8293563](https://bugs.openjdk.org/browse/JDK-8293563) where large parts
> of the ZGC heap would not be in the core file,
On Fri, 25 Aug 2023 02:54:05 GMT, David Holmes wrote:
> As `AlwaysPreTouch` is false by default, and we don't explicitly turn it on
> for CI testing, what tests will actually be affected by this change? And for
> applications that already enable `AlwaysPreTouch` (would they?) what impact
> mig
On Thu, 24 Aug 2023 23:31:56 GMT, Chris Plummer wrote:
> On some macosx-aarch64 systems, not all mapped pages are dumped to the core
> file. This first turned up with
> [JDK-8293563](https://bugs.openjdk.org/browse/JDK-8293563) where large parts
> of the ZGC heap would not be in the core file,
On Thu, 24 Aug 2023 14:09:46 GMT, Afshin Zafari wrote:
> The `find` method now is
> ```C++
> template
> int find(T* token, bool f(T*, E)) const {
> ...
>
> Any other functions which use this are also changed.
> Local linux-x64-debug hotspot:tier1 passed. Mach5 tier1 build on linux and
> Window
On some macosx-aarch64 systems, not all mapped pages are dumped to the core
file. This first turned up with
[JDK-8293563](https://bugs.openjdk.org/browse/JDK-8293563) where large parts of
the ZGC heap would not be in the core file, leading to various SA address
errors. For JDK-8293563 the issue
On Wed, 23 Aug 2023 22:58:05 GMT, Leonid Mesnik wrote:
> Mark 3 tests as flagless to don't run them if not needed. Also, small clean
> up.
We certainly could do it. I just don't know what would be the 'expected"
behaviour here.
-
PR Comment: https://git.openjdk.org/jdk/pull/1540
On Wed, 23 Aug 2023 22:58:05 GMT, Leonid Mesnik wrote:
> Mark 3 tests as flagless to don't run them if not needed. Also, small clean
> up.
Ok, so it sounds like you already have the needed flag in place, although I
would suggest by default it be set false and require that CI set true. The goal
On Wed, 23 Aug 2023 22:58:05 GMT, Leonid Mesnik wrote:
> Mark 3 tests as flagless to don't run them if not needed. Also, small clean
> up.
You could use TEST_VM_FLAGLESS=false to forcibly ignore any vm.flagless and run
them in testing. Or configure behavior in VMProps file. Currently, options
On Wed, 23 Aug 2023 22:58:05 GMT, Leonid Mesnik wrote:
> Mark 3 tests as flagless to don't run them if not needed. Also, small clean
> up.
So vm.flagless is to be used for any test that spawns a process and does not
pass the vm flags on to that process? I understand the rationale, but still
h
On Thu, 24 Aug 2023 21:38:41 GMT, Kevin Walls wrote:
>> Several tests from test/jdk/sun/tools/jstatd are intermittent.
>>
>> Port clashes when run at the same time on the same machine have been a
>> problem.
>> The RMI error "no such object in table" can mean a reference on the RMI
>> server h
On Wed, 23 Aug 2023 22:58:05 GMT, Leonid Mesnik wrote:
> Mark 3 tests as flagless to don't run them if not needed. Also, small clean
> up.
It is the original intention of vm.flagless to mark all tests that ignore VM
flags. See https://bugs.openjdk.org/browse/JDK-8151707 and
https://bugs.openj
On Thu, 24 Aug 2023 18:08:13 GMT, Mark Sheppard wrote:
>> Kevin Walls has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Less specific error message, could be ports or other failure..
>
> test/jdk/sun/tools/jstatd/JstatdTest.java line 327:
> Several tests from test/jdk/sun/tools/jstatd are intermittent.
>
> Port clashes when run at the same time on the same machine have been a
> problem.
> The RMI error "no such object in table" can mean a reference on the RMI
> server has been GC'd.
> Either way, jstatd fails to startup and and t
On Wed, 23 Aug 2023 22:58:05 GMT, Leonid Mesnik wrote:
> Mark 3 tests as flagless to don't run them if not needed. Also, small clean
> up.
Is this proper use of `vm.flagless`? From existing uses, it seems to be
actually specifying a real requirement. In other words, the test may not run
prope
On Thu, 24 Aug 2023 14:39:22 GMT, Daniel D. Daugherty
wrote:
> Would be nice to have an explanation for why "@library /vmTestbase" is no
> longer needed. A comment in the PR would suffice.
It is just not used, probably someone forgot to remove it or added by mistake.
-
PR Comment
On Thu, 24 Aug 2023 09:16:08 GMT, Aleksey Shipilev wrote:
> Please test with all current GCs? We have seen regressions in this test with
> Shenandoah previously.
Passed with G1, Z, ZGenerational, Shenandoah, Serial, and Parallel.
-
PR Comment: https://git.openjdk.org/jdk/pull/1536
On Thu, 24 Aug 2023 14:57:47 GMT, Kevin Walls wrote:
>> Several tests from test/jdk/sun/tools/jstatd are intermittent.
>>
>> Port clashes when run at the same time on the same machine have been a
>> problem.
>> The RMI error "no such object in table" can mean a reference on the RMI
>> server h
On Thu, 24 Aug 2023 14:57:47 GMT, Kevin Walls wrote:
>> Several tests from test/jdk/sun/tools/jstatd are intermittent.
>>
>> Port clashes when run at the same time on the same machine have been a
>> problem.
>> The RMI error "no such object in table" can mean a reference on the RMI
>> server h
On Thu, 24 Aug 2023 14:09:46 GMT, Afshin Zafari wrote:
> The `find` method now is
> ```C++
> template
> int find(T* token, bool f(T*, E)) const {
> ...
>
> Any other functions which use this are also changed.
> Local linux-x64-debug hotspot:tier1 passed. Mach5 tier1 build on linux and
> Window
On Thu, 24 Aug 2023 16:37:44 GMT, Johan Sjölen wrote:
>> The `find` method now is
>> ```C++
>> template
>> int find(T* token, bool f(T*, E)) const {
>> ...
>>
>> Any other functions which use this are also changed.
>> Local linux-x64-debug hotspot:tier1 passed. Mach5 tier1 build on linux and
>
> Port clashes happening when several tests from test/jdk/sun/tools/jstatd run
> at the same time on the same machine.
>
> There is logic in here for detecting this, but it's not working.
>
> We recently saw this fail with a port in use, and the failure is:
>
> [Jstatd-Thread] Could not bind //
On Thu, 24 Aug 2023 13:37:36 GMT, Alan Bateman wrote:
> Something fishy here, is this working around a bug in GraaVM native image or
> why does this change need to be in JDK?
I've now realized that the bug had an incorrect statement in the description.
The cycle happens due to the `Runtime.get
On Wed, 23 Aug 2023 22:58:05 GMT, Leonid Mesnik wrote:
> Mark 3 tests as flagless to don't run them if not needed. Also, small clean
> up.
Would be nice to have an explanation for why "@library /vmTestbase" is no
longer needed.
A comment in the PR would suffice.
I fixed the typo in the bug's
The `find` method now is
```C++
template
int find(T* token, bool f(T*, E)) const {
...
Any other functions which use this are also changed.
Local linux-x64-debug hotspot:tier1 passed. Mach5 tier1 build on linux and
Windows passed.
-
Commit messages:
- 8314502: GrowableArray: Make
On Thu, 24 Aug 2023 13:16:16 GMT, Severin Gehwolf wrote:
> Please review this rather trivial fix to not use `nio` in `CgroupUtil`, part
> of the
> JDK's Metrics API. The primary motivating factor is that it allows one to use
> the
> JDK's version of `Metrics` in GraalVM. See the bug for details
Please review this rather trivial fix to not use `nio` in `CgroupUtil`, part of
the
JDK's Metrics API. The primary motivating factor is that it allows one to use
the
JDK's version of `Metrics` in GraalVM. See the bug for details as to why this is
needed.
Testing:
- [x] GraalVM builds with/withou
> Compiler Control (https://openjdk.org/jeps/165) provides method-context
> dependent control of the JVM compilers (C1 and C2). The active directive
> stack is built from the directive files passed with the
> `-XX:CompilerDirectivesFile` diagnostic command-line option and the
> Compiler.add_dir
On Mon, 12 Jun 2023 12:00:48 GMT, Andrei Pangin wrote:
>> Dmitry Chuyko has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 23 commits:
>>
>> - jcheck
>> - Unnecessary import
>> - force_update->refresh
>> - Merge branch 'openjdk:m
On Thu, 24 Aug 2023 11:34:13 GMT, Kevin Walls wrote:
> Port clashes happening when several tests from test/jdk/sun/tools/jstatd run
> at the same time on the same machine.
>
> There is logic in here for detecting this, but it's not working.
>
> We recently saw this fail with a port in use, and
Port clashes happening when several tests from test/jdk/sun/tools/jstatd run at
the same time on the same machine.
There is logic in here for detecting this, but it's not working.
We recently saw this fail with a port in use, and the failure is:
[Jstatd-Thread] Could not bind //:33859/TestJstat
On Mon, 21 Aug 2023 19:25:25 GMT, Chris Plummer wrote:
> The test tries to match up various GC -XX:+PrintFlagsFinal values with the
> output of jhsdb -jmap --pid --heap. With ZGC, MaxNewSize set to
> (size_t)-1, but PrintFlagsFinal prints it as an unsigned long:
>
> size_t MaxNewSize = 18
33 matches
Mail list logo
